CI: Get 32-bit Node via the official NodeTool task (atom#21490)

The official NodeTool@0 task can now download 32-bit Node even on Windows x64 hosts. (As of this PR: microsoft/azure-pipelines-tasks#13399)

Author: DeeDeeG

script/vsts/platforms/templates/bootstrap.yml

@@ -17,12 +17,7 @@ steps:
       }
 
       # Bootstrap
-      if (($env:AGENT_OS  -eq "Windows_NT") -and ($env:BUILD_ARCH -eq "x86")) {
-        node 'script\vsts\windows-run.js' 'script\bootstrap.cmd'
-      }
-      else {
-        script/bootstrap
-      }
+      script/bootstrap
     displayName: Bootstrap build environment
     env:
       GITHUB_TOKEN: $(GITHUB_TOKEN)

script/vsts/platforms/templates/build.yml

@@ -29,11 +29,7 @@ steps:
 
       # Build
       $esc = '--%'
-      if (($env:AGENT_OS  -eq "Windows_NT") -and ($env:BUILD_ARCH -eq "x86")) {
-        node 'script\vsts\windows-run.js' 'script\build.cmd' --no-bootstrap --compress-artifacts $esc $CodeSign $CreateWindowsInstallaer
-      } else {
-        script/build --no-bootstrap --compress-artifacts $esc $env:LinuxArgs $CodeSign $CreateWindowsInstallaer
-      }
+      script/build --no-bootstrap --compress-artifacts $esc $env:LinuxArgs $CodeSign $CreateWindowsInstallaer
     displayName: Build Atom
     env:
       GITHUB_TOKEN: $(GITHUB_TOKEN)

script/vsts/platforms/templates/preparation.yml

@@ -20,9 +20,19 @@ steps:
     condition: eq(variables['Agent.OS'], 'Linux')
 
   # Common
+  - pwsh: |
+      if ($env:BUILD_ARCH -eq "x86") {
+        echo "##vso[task.setvariable variable=IsWinX86]true"
+      }
+    displayName: Set "IsWinX86" based on "BUILD_ARCH"
+    # Convert "BUILD_ARCH" to a boolean ("IsWinX86") for the following NodeTool task.
+    # Templates evaluate too early for the matrix variable "BUILD_ARCH" to be available in ${{ template expressions }}.
+    # Scripts are interpreted at runtime, so "BUILD_ARCH" will be available to this script, and we can set "IsWinX86".
+
   - task: NodeTool@0
     inputs:
       versionSpec: 12.16.3
+      force32bit: $(IsWinX86)
     displayName: Install Node.js 12.16.3
 
   - script: npm install --global npm@6.14.8

script/vsts/platforms/templates/test.yml

@@ -10,8 +10,6 @@ steps:
       if ($env:AGENT_OS -eq "Darwin") {
         osascript -e 'tell application "System Events" to keystroke "x"' # clear screen saver
         caffeinate -s script/test # Run with caffeinate to prevent screen saver
-      } elseif (($env:AGENT_OS -eq "Windows_NT") -and ($env:BUILD_ARCH -eq "x86")) {
-        node 'script\vsts\windows-run.js' 'script\test.cmd'
       } else {
         script/test
       }
@@ -28,12 +26,7 @@ steps:
     condition: and(succeeded(), ne(variables['Atom.SkipTests'], 'true'))
 
   # Test results
-  - pwsh: |
-      if (($env:AGENT_OS -eq "Windows_NT") -and ($env:BUILD_ARCH -eq "x86")) {
-        node 'script\vsts\windows-run.js' 'script\postprocess-junit-results.cmd' --search-folder "$env:TEST_JUNIT_XML_ROOT" --test-results-files "**/*.xml"
-      } else {
-        script/postprocess-junit-results --search-folder "$env:TEST_JUNIT_XML_ROOT" --test-results-files "**/*.xml"
-      }
+  - pwsh: script/postprocess-junit-results --search-folder "$env:TEST_JUNIT_XML_ROOT" --test-results-files "**/*.xml"
     env:
       TEST_JUNIT_XML_ROOT: $(Common.TestResultsDirectory)/junit
     displayName: Post-process test results

script/vsts/platforms/windows.yml

@@ -43,8 +43,6 @@ jobs:
             $env:FileID=""
           }
           echo "##vso[task.setvariable variable=FileID]$env:FileID" # Azure syntax
-        env:
-          BUILD_ARCH: $(BUILD_ARCH)
         displayName: Set FileID based on the arch
 
       - template: templates/publish.yml
@@ -111,8 +109,6 @@ jobs:
             $env:FileID=""
           }
           echo "##vso[task.setvariable variable=FileID]$env:FileID" # Azure syntax
-        env:
-          BUILD_ARCH: $(BUILD_ARCH)
         displayName: Set FileID based on the arch
 
       - template: templates/download-unzip.yml