Commit 03a2a02
committed
Don't return an unresolved Promise on beforeEach()
The `editor.update()` method returns a Promise, which under some
circumstances (on specs mostly) never gets resolved.
Because of CoffeeScript's implicit returns, this Promise was returned on
the `beforeEach()` method of these tests.
Before atom/atom#18917, any Promise that was
returned by a spec method was just discarded, so this behaviour didn't
cause any issue, but once we merge that PR this test is going to start
failing because jasmine will wait indefinitely until the Promise is
resolved.1 parent f1386c5 commit 03a2a02
1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
481 | 481 | | |
482 | 482 | | |
483 | 483 | | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
484 | 488 | | |
485 | 489 | | |
486 | 490 | | |
| |||
0 commit comments