fix: use const candidates_size

Author: aminya

src/filter.cc

@@ -61,30 +61,28 @@ std::vector<CandidateIndex> sort_priority_queue(CandidateScorePriorityQueue &&ca
 
 std::vector<CandidateIndex> filter(const vector<std::vector<CandidateString>> &candidates, const Element &query, const Options &options) {
     const auto candidates_size = candidates.size();
-
     assert(1 <= candidates_size);// TODO handled outside
 
-    CandidateScorePriorityQueue top_k;
     auto max_results = options.max_results;
     if (max_results == 0u) {
         max_results = std::numeric_limits<size_t>::max();
     }
 
     // Split the dataset and pass down to multiple threads.
     vector<thread> threads;
-    threads.reserve(candidates.size() - 1);// 1 less thread
+    threads.reserve(candidates_size - 1);// 1 less thread
 
-    auto results = vector<CandidateScorePriorityQueue>(candidates.size());
+    auto results = vector<CandidateScorePriorityQueue>(candidates_size);
 
     size_t start_index = 0;
     for (size_t i = 1; i < candidates_size; i++) {
-        assert(1 <= i && i < candidates.size() && i < results.size());
+        assert(1 <= i && i < candidates_size && i < results.size());
         start_index += candidates[i - 1].size();//inbounds
         threads.emplace_back(filter_internal, ref(candidates[i]), start_index, ref(query), ref(options), max_results, ref(results[i]));// inbounds
     }
+    assert(threads.size() == candidates_size - 1 && results.size() == candidates_size);
 
-    assert(threads.size() == candidates.size() - 1 && results.size() == candidates.size());
-
+    CandidateScorePriorityQueue top_k;
     // Do the work for first thread.
     filter_internal(candidates[0], 0, query, options, max_results, top_k);//inbounds (candidate_size >= 1)
     // Wait for threads to complete and merge the results.