Tidy Validation Adapter (#278)

* Tidy Validation Adapter

* Update ConstraintAdapter.java

* doc

Author: SentryMan

validator/src/main/java/io/avaje/validation/adapter/AbstractConstraintAdapter.java

@@ -20,7 +20,7 @@ protected AbstractConstraintAdapter(AdapterCreateRequest request) {
   }
 
   /**
-   * Execute Constraint validations for the given object.
+   * Execute constraint validations for the given object.
    *
    * @param value the object to validate
    * @return false if a violation error should be added

validator/src/main/java/io/avaje/validation/adapter/ConstraintAdapter.java

@@ -38,7 +38,7 @@
  *
  *     return isValid;
  *   }
- *
+ *}
  * }</pre>
  */
 @Target(TYPE)

validator/src/main/java/io/avaje/validation/adapter/IterableValidationAdapter.java

@@ -12,7 +12,6 @@ public boolean validate(T value, ValidationRequest req, String propertyName) {
     if (initalAdapter.validate(value, req, propertyName)) {
       validateAll((Iterable<Object>) value, req, propertyName);
     }
-
     return true;
   }
 }

validator/src/main/java/io/avaje/validation/adapter/ValidationAdapter.java

@@ -34,7 +34,7 @@ default boolean validate(T value, ValidationRequest req) {
     return validate(value, req, null);
   }
 
-  /** Return a primitive adapter. Supports int, long with Range, Min, Max, Positive. */
+  /** Return primitive-handling version of this adapter. */
   default Primitive primitive() {
     throw new UnsupportedOperationException();
   }
@@ -93,12 +93,7 @@ default ContainerAdapter<T> optional() {
    */
   default ValidationAdapter<T> andThen(ValidationAdapter<? super T> after) {
     Objects.requireNonNull(after, "after cannot be null");
-    return (value, req, propertyName) -> {
-      if (validate(value, req, propertyName)) {
-        return after.validate(value, req, propertyName);
-      }
-      return false;
-    };
+    return (value, req, propertyName) -> validate(value, req, propertyName) && after.validate(value, req, propertyName);
   }
 
   /**
@@ -119,7 +114,7 @@ default boolean checkGroups(Set<Class<?>> adapterGroups, ValidationRequest reque
     return false;
   }
 
-  /** Validation adapter that supports and uses the primitive type. */
+  /** Validation adapter that supports and uses the primitive types. */
   interface Primitive {
 
     /** Validate using primitive boolean. */

validator/src/main/java/io/avaje/validation/core/CoreAdapterBuilder.java

@@ -82,10 +82,7 @@ <T> ValidationAdapter<T> annotationAdapter(
 
   /**
    * Build given type and annotations.
-   *
-   * @param groups
    */
-  // TODO understand that lookup chain stuff
   @SuppressWarnings("unchecked")
   <T> ValidationAdapter<T> buildAnnotation(
       Class<? extends Annotation> cls,
@@ -155,7 +152,6 @@ public <T> T attribute(String key) {
     public Request withValue(long value) {
       Map<String, Object> newAttributes = new HashMap<>(attributes);
       newAttributes.put("value", value);
-      //newAttributes.put("_type", "Long");
       return new Request(ctx, annotationType, groups, newAttributes);
     }