Skip to content

Commit b219983

Browse files
authored
Better Soak Test Naming and Env Variables (#50)
1 parent e872feb commit b219983

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/soak-testing.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ env:
2525
CPU_LOAD_THRESHOLD: 75
2626
TOTAL_MEMORY_THRESHOLD: 2684354560 # 2.5 GiB
2727
MAX_BENCHMARKS_TO_KEEP: 100
28+
LISTEN_ADDRESS_PORT: 8080
2829
# TODO: We might be able to adapt the "Soak Tests" to be "Overhead Tests".
2930
# This means monitoring the Sample App's performance using high levels of TPS
3031
# for the Load Generator over a shorter period of testing time. For example:
@@ -33,7 +34,7 @@ env:
3334

3435
jobs:
3536
test_apps_and_publish_results:
36-
name: Publish app and Soak Performance Test - (${{ matrix.app-platform }}, ${{ matrix.instrumentation-type }})
37+
name: Soak Performance Test - (${{ matrix.app-platform }}, ${{ matrix.instrumentation-type }})
3738
runs-on: ubuntu-latest
3839
permissions:
3940
contents: write
@@ -130,14 +131,14 @@ jobs:
130131
working-directory: .github/docker-performance-tests
131132
env:
132133
INSTANCE_ID: ${{ github.run_id }}-${{ github.run_number }}
133-
LISTEN_ADDRESS_PORT: 8080
134134
LOG_GROUP_NAME: otel-sdk-performance-tests
135135
# Also uses:
136136
# AWS_ACCESS_KEY_ID
137137
# AWS_SECRET_ACCESS_KEY
138138
# AWS_SESSION_TOKEN
139139
# APP_PATH
140140
# TARGET_SHA
141+
# LISTEN_ADDRESS_PORT
141142
# LOGS_NAMESPACE
142143
# APP_PROCESS_COMMAND_LINE_DIMENSION_VALUE
143144
# APP_PROCESS_EXECUTABLE_NAME

0 commit comments

Comments
 (0)