chore: update visibility timeout and add deletion policies in templates

Author: sliedig

unicorn_contracts/template.yaml

@@ -204,7 +204,7 @@ Resources:
       RedrivePolicy:
         deadLetterTargetArn: !GetAtt UnicornContractsIngestDLQ.Arn
         maxReceiveCount: 1
-      VisibilityTimeout: 40
+      VisibilityTimeout: 20
       Tags:
         - Key: stage
           Value: !Ref Stage

unicorn_properties/template.yaml

@@ -72,13 +72,17 @@ Resources:
   # Services share their event bus name and arn
   UnicornPropertiesEventBusNameParam:
     Type: AWS::SSM::Parameter
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       Type: String
       Name: !Sub /uni-prop/${Stage}/UnicornPropertiesEventBus
       Value: !GetAtt UnicornPropertiesEventBus.Name
 
   UnicornPropertiesEventBusArnParam:
     Type: AWS::SSM::Parameter
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       Type: String
       Name: !Sub /uni-prop/${Stage}/UnicornPropertiesEventBusArn
@@ -196,6 +200,8 @@ Resources:
   #### STATE MACHINE
   ApprovalStateMachine:
     Type: AWS::Serverless::StateMachine
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       Name: !Sub "${AWS::StackName}-ApprovalStateMachine"
       DefinitionUri: state_machine/property_approval.asl.yaml
@@ -251,7 +257,7 @@ Resources:
               Destination: !GetAtt PropertiesServiceDLQ.Arn
       DefinitionSubstitutions:
         WaitForContractApprovalArn: !GetAtt WaitForContractApprovalFunction.Arn
-        TableName: !Ref ContractStatusTable  
+        TableName: !Ref ContractStatusTable
         ImageUploadBucketName: !Sub "{{resolve:ssm:/uni-prop/${Stage}/ImagesBucket}}"
         EventBusName: !GetAtt UnicornPropertiesEventBus.Name
         ServiceName: "{{resolve:ssm:/uni-prop/UnicornPropertiesNamespace}}"
@@ -315,7 +321,7 @@ Resources:
       BillingMode: PAY_PER_REQUEST
       Tags:
         - Key: project
-          Value: !FindInMap [ Constants, ProjectName, Value ]
+          Value: !FindInMap [Constants, ProjectName, Value]
         - Key: namespace
           Value: "{{resolve:ssm:/uni-prop/UnicornPropertiesNamespace}}"
         - Key: stage
@@ -325,12 +331,16 @@ Resources:
   # Event bus for Unicorn Properties Service, used to publish and consume events
   UnicornPropertiesEventBus:
     Type: AWS::Events::EventBus
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       Name: !Sub UnicornPropertiesBus-${Stage}
 
   # Event bus policy to restrict who can publish events (should only be services from UnicornPropertiesNamespace)
   UnicornPropertiesEventsBusPublishPolicy:
     Type: AWS::Events::EventBusPolicy
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       EventBusName: !Ref UnicornPropertiesEventBus
       StatementId: !Sub OnlyPropertiesServiceCanPublishToEventBus-${Stage}
@@ -349,6 +359,8 @@ Resources:
   # Catchall rule used for development purposes. Logs all events matching any of the services to CloudWatch Logs
   UnicornPropertiesCatchAllRule:
     Type: AWS::Events::Rule
+    DeletionPolicy: Delete
+    UpdateReplacePolicy: Delete
     Properties:
       Name: properties.catchall
       Description: Catchall rule used for development purposes.

unicorn_shared/uni-prop-images.yaml

@@ -22,7 +22,7 @@ Parameters:
 Globals:
   Function:
     Timeout: 15
-    Runtime: python3.11
+    Runtime: python3.12
     MemorySize: 512
     Tracing: Active
     Architectures:
@@ -55,7 +55,7 @@ Resources:
     Type: AWS::Serverless::Function
     Properties:
       Handler: index.lambda_handler
-      Runtime: python3.11
+      Runtime: python3.13
       Policies:
         - S3CrudPolicy:
             BucketName: !Ref UnicornPropertiesImagesBucket

unicorn_web/template.yaml

@@ -14,6 +14,7 @@ Metadata:
         - ES6000 # Rule disabled because SQS DLQs don't need a RedrivePolicy
         - WS2001 # Rule disabled because check does not support !ToJsonString transform
         - ES1001 # Rule disabled because our Lambda functions don't need DestinationConfig.OnFailure
+        - W3002  # Rule disabled as nested templates are being packaged 
         - W3002  # Rule disabled as nested templates are being packaged
         - E3030  # Rule disabled due to using cfn-lint-serverless rules v0.3
 
@@ -182,10 +183,7 @@ Resources:
         - MetricsEnabled: true
           ResourcePath: /*
           HttpMethod: "*"
-          LoggingLevel: !If
-            - IsProd
-            - ERROR
-            - INFO
+          LoggingLevel: !If [IsProd, ERROR, INFO]
           ThrottlingBurstLimit: 10
           ThrottlingRateLimit: 100
       AccessLogSetting:
@@ -452,7 +450,7 @@ Outputs:
   BaseUrl:
     Description: Web service API endpoint
     Value: !Sub "https://${UnicornWebApi}.execute-api.${AWS::Region}.${AWS::URLSuffix}"
-  UnicornWebRestApiUrl:
+  UnicornWebApiUrl:
     Description: Web service API endpoint
     Value: !Sub "https://${UnicornWebApi}.execute-api.${AWS::Region}.${AWS::URLSuffix}/${Stage}/"