Fixing a few probe scan criticals I introduced. Nothing major

Author: kaleko

lib/idp_common_pkg/idp_common/agents/README.md

@@ -153,15 +153,15 @@ The agent requires credentials stored in AWS Secrets Manager at `{StackName}/ext
     "mcp_url": "https://your-first-mcp-server.com/mcp",
     "cognito_user_pool_id": "us-east-1_XXXXXXXXX",
     "cognito_client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxx", 
-    "cognito_username": "mcp-user-1",
-    "cognito_password": "secure-password-1"
+    "cognito_username": "<your first user here>",
+    "cognito_password": "<your first password here>"
   },
   {
     "mcp_url": "https://your-second-mcp-server.com/mcp",
     "cognito_user_pool_id": "us-east-1_YYYYYYYYY",
     "cognito_client_id": "yyyyyyyyyyyyyyyyyyyyyyyyyy", 
-    "cognito_username": "mcp-user-2",
-    "cognito_password": "secure-password-2"
+    "cognito_username": "<your second user here>",
+    "cognito_password": "<your second password here>"
   }
 ]
 ```

lib/idp_common_pkg/idp_common/agents/analytics/tools/athena_tool.py

@@ -83,7 +83,9 @@ def run_athena_query(
                 logger.debug(
                     f"Query state: {state}, sleeping for 2 seconds (attempt {attempts + 1}/{max_polling_attempts})"
                 )
-                time.sleep(2)
+                time.sleep(  # semgrep-ignore: arbitrary-sleep - Intentional delay. Duration is hardcoded and not user-controlled.
+                    2
+                )  # semgrep-ignore: arbitrary-sleep - Intentional delay. Duration is hardcoded and not user-controlled.
                 attempts += 1
 
         # Check final state

src/lambda/agent_processor/index.py

@@ -347,7 +347,7 @@ def handler(event, context):
 
                 if attempt < max_retries - 1:  # Not the last attempt
                     logger.info(f"Waiting {retry_delay} seconds before retry {attempt + 2}/{max_retries} for job {job_id}")
-                    time.sleep(retry_delay)
+                    time.sleep(retry_delay) # semgrep-ignore: arbitrary-sleep - Intentional delay. Duration is hardcoded and not user-controlled.
                 else:
                     # Last attempt failed
                     logger.error(f"All {max_retries} attempts failed for agent query processing, job {job_id}: {str(e)}")