Skip to content

Commit 387e374

Browse files
committed
fix: fixes after review
1 parent 925b4e2 commit 387e374

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

config_library/pattern-2/default/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ summarization:
605605
assessment:
606606
image:
607607
target_width: '951'
608-
target_height: 1268
608+
target_height: '1268'
609609
default_confidence_threshold: '0.9'
610610
top_p: '0.1'
611611
max_tokens: '10000'

lib/idp_common_pkg/idp_common/classification/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,7 @@ def classify_page_bedrock(
608608
# Load image content from URI with configurable dimensions
609609
if image_uri:
610610
try:
611-
image_config = self.config.get("image", {})
611+
image_config = self.config.get("classification", {}).get("image", {})
612612
target_width = image_config.get("target_width")
613613
target_height = image_config.get("target_height")
614614

lib/idp_common_pkg/tests/unit/classification/test_classification_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ def test_classify_page_bedrock_success(
232232

233233
# Verify calls
234234
mock_get_text.assert_called_once_with("s3://bucket/text.txt")
235-
mock_prepare_image.assert_called_once_with("s3://bucket/image.jpg", 951, 1268)
235+
mock_prepare_image.assert_called_once_with("s3://bucket/image.jpg")
236236
mock_prepare_bedrock_image.assert_called_once_with(b"image_data")
237237
mock_invoke.assert_called_once()
238238

patterns/pattern-2/template.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,14 @@ Resources:
147147
description: "Target image width in pixels. Images larger than this will be resized. Default: 951"
148148
default: 951
149149
minimum: 100
150-
maximum: 4000
150+
maximum: 3500
151151
order: 0
152152
target_height:
153153
type: number
154154
description: "Target image height in pixels. Images larger than this will be resized. Default: 1268"
155155
default: 1268
156156
minimum: 100
157-
maximum: 4000
157+
maximum: 3500
158158
order: 1
159159
features:
160160
type: array
@@ -402,14 +402,14 @@ Resources:
402402
description: "Target image width in pixels. Images larger than this will be resized. Default: 951"
403403
default: 951
404404
minimum: 100
405-
maximum: 4000
405+
maximum: 3500
406406
order: 0
407407
target_height:
408408
type: number
409409
description: "Target image height in pixels. Images larger than this will be resized. Default: 1268"
410410
default: 1268
411411
minimum: 100
412-
maximum: 4000
412+
maximum: 3500
413413
order: 1
414414
model:
415415
type: string
@@ -485,14 +485,14 @@ Resources:
485485
description: "Target image width in pixels. Images larger than this will be resized. Default: 951"
486486
default: 951
487487
minimum: 100
488-
maximum: 4000
488+
maximum: 3500
489489
order: 0
490490
target_height:
491491
type: number
492492
description: "Target image height in pixels. Images larger than this will be resized. Default: 1268"
493493
default: 1268
494494
minimum: 100
495-
maximum: 4000
495+
maximum: 3500
496496
order: 1
497497
model:
498498
type: string
@@ -554,14 +554,14 @@ Resources:
554554
description: "Target image width in pixels. Images larger than this will be resized. Default: 951"
555555
default: 951
556556
minimum: 100
557-
maximum: 4000
557+
maximum: 3500
558558
order: 0
559559
target_height:
560560
type: number
561561
description: "Target image height in pixels. Images larger than this will be resized. Default: 1268"
562562
default: 1268
563563
minimum: 100
564-
maximum: 4000
564+
maximum: 3500
565565
order: 1
566566
default_confidence_threshold:
567567
type: number

0 commit comments

Comments
 (0)