> Fix agentic extraction to ensure temperature and top_p are mutually...

Author: rstrahan

Makefile

@@ -129,14 +129,14 @@ ui-build:
 
 commit: lint test
 	$(info Generating commit message...)
-	export COMMIT_MESSAGE="$(shell q chat --no-interactive --trust-all-tools "Understand pending local git change and changes to be committed, then infer a commit message. Return this commit message only" | tail -n 1 | sed 's/\x1b\[[0-9;]*m//g')" && \
+	export COMMIT_MESSAGE="$(shell kiro-cli chat --no-interactive --trust-all-tools "Understand pending local git change and changes to be committed, then infer a commit message. Return this commit message only on a single line." | grep ">" | tail -n 1 | sed 's/\x1b\[[0-9;]*m//g')" && \
 	git add . && \
 	git commit -am "$${COMMIT_MESSAGE}" && \
 	git push
 
 fastcommit: fastlint
 	$(info Generating commit message...)
-	export COMMIT_MESSAGE="$(shell q chat --no-interactive --trust-all-tools "Understand pending local git change and changes to be committed, then infer a commit message. Return this commit message only" | tail -n 1 | sed 's/\x1b\[[0-9;]*m//g')" && \
+	export COMMIT_MESSAGE="$(shell kiro-cli chat --no-interactive --trust-all-tools "Understand pending local git change and changes to be committed, then infer a commit message. Return this commit message only on a single line." | grep ">" | tail -n 1 | sed 's/\x1b\[[0-9;]*m//g')" && \
 	git add . && \
 	git commit -am "$${COMMIT_MESSAGE}" && \
 	git push

lib/idp_common_pkg/idp_common/extraction/agentic_idp.py

@@ -691,6 +691,37 @@ def _build_model_config(
     return model_config
 
 
+def _get_inference_params(temperature: float, top_p: float | None) -> dict[str, float]:
+    """
+    Get inference parameters ensuring temperature and top_p are mutually exclusive.
+
+    Some Bedrock models don't allow both temperature and top_p to be specified.
+    This follows the same logic as bedrock/client.py lines 348-364.
+
+    Args:
+        temperature: Temperature value from config
+        top_p: Top_p value from config (may be None)
+
+    Returns:
+        Dict with only one of temperature or top_p
+    """
+    params = {}
+
+    # Only use top_p if temperature is 0.0
+    if top_p is not None and temperature == 0.0:
+        params["top_p"] = top_p
+        logger.debug(
+            "Using top_p for inference (temperature is 0.0)", extra={"top_p": top_p}
+        )
+    else:
+        params["temperature"] = temperature
+        logger.debug(
+            "Using temperature for inference", extra={"temperature": temperature}
+        )
+
+    return params
+
+
 def _prepare_prompt_content(
     prompt: str | Message | Image.Image,
     page_images: list[bytes] | None,
@@ -1001,11 +1032,16 @@ async def structured_output_async(
 
     # Track token usage
     token_usage = _initialize_token_usage()
+
+    # Get inference params ensuring temperature and top_p are mutually exclusive
+    inference_params = _get_inference_params(
+        temperature=config.extraction.temperature, top_p=config.extraction.top_p
+    )
+
     agent = Agent(
         model=BedrockModel(
             **model_config,
-            temperature=config.extraction.temperature,
-            top_p=config.extraction.top_p,
+            **inference_params,
         ),  # pyright: ignore[reportArgumentType]
         tools=tools,
         system_prompt=final_system_prompt,
@@ -1078,8 +1114,17 @@ async def structured_output_async(
             connect_timeout=connect_timeout,
             read_timeout=read_timeout,
         )
+
+        # Get inference params for review agent ensuring temperature and top_p are mutually exclusive
+        review_inference_params = _get_inference_params(
+            temperature=config.extraction.temperature, top_p=config.extraction.top_p
+        )
+
         agent = Agent(
-            model=BedrockModel(**review_model_config),  # pyright: ignore[reportArgumentType]
+            model=BedrockModel(
+                **review_model_config,
+                **review_inference_params,
+            ),  # pyright: ignore[reportArgumentType]
             tools=tools,
             system_prompt=f"{final_system_prompt}",
             state={