Skip to content

Commit bdf5c4a

Browse files
author
Taniya Mathur
committed
fix: Add ASH security suppressions for false positive findings
- Add pragma allowlist comments for Draw.io diagram base64 image data - Suppress SECRET-BASE64-HIGH-ENTROPY-STRING findings in IDP.drawio - Address CloudFormation GenerateSecret parameter false positives - Add suppressions for other ASH security findings
1 parent 64a1a6b commit bdf5c4a

File tree

6 files changed

+31
-7
lines changed

6 files changed

+31
-7
lines changed

docs/custom-MCP-agent.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ In the AWS account where the IDP solution is deployed, create a secret with your
149149
"cognito_user_pool_id": "us-east-1_XXXXXXXXX",
150150
"cognito_client_id": "xxxxxxxxxxxxxxxxxxxxxxxxxx",
151151
"cognito_username": "mcp-service-user-1",
152-
"cognito_password": "SecurePassword123!",
152+
"cognito_password": "SecurePassword123!", //<!-- pragma: allowlist secret - Example password for documentation only -->
153153
"agent_name": "My Custom Calculator Agent",
154154
"agent_description": "Provides advanced mathematical calculations for document analysis"
155155
},
@@ -158,7 +158,7 @@ In the AWS account where the IDP solution is deployed, create a secret with your
158158
"cognito_user_pool_id": "us-east-1_YYYYYYYYY",
159159
"cognito_client_id": "yyyyyyyyyyyyyyyyyyyyyyyyyy",
160160
"cognito_username": "mcp-service-user-2",
161-
"cognito_password": "AnotherSecurePassword456!"
161+
"cognito_password": "AnotherSecurePassword456!" //<!-- pragma: allowlist secret - Example password for documentation only -->
162162
}
163163
]
164164
```

iam-roles/cloudformation-management/IDP-Cloudformation-Service-Role.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Resources:
3030
# checkov:skip=CKV_AWS_108: "CloudFormation service role requires S3/KMS permissions to create and configure encrypted data buckets for the IDP solution. All buckets use customer-managed KMS encryption."
3131
# checkov:skip=CKV_AWS_111: "CloudFormation service role requires write permissions across AWS services to deploy complete IDP infrastructure. Trust policy limits to CloudFormation service. Use in conjunction with CloudTrail auditing."
3232
# checkov:skip=CKV_AWS_107: "CloudFormation service role may need to create/configure secrets for service integrations. Actual secret values are provided via parameters, not embedded in templates."
33+
# cdk-nag:skip=AwsSolutions-IAM5: CloudFormation service role requires broad permissions for IDP stack deployment. Constrained by trust policy to cloudformation.amazonaws.com service principal.
3334
Properties:
3435
RoleName: !Sub '${AWS::StackName}-CFServiceRole'
3536
AssumeRolePolicyDocument:

0 commit comments

Comments
 (0)