Skip to content

Commit d265594

Browse files
author
Taniya Mathur
committed
Fix TestSets GraphQL query and error handling
- Add missing bucketType parameter to ADD_TEST_SET mutation - Improve error handling to properly display GraphQL errors - Fix 'Failed to add test set: undefined' issue - Add comprehensive error message extraction for all test set operations - All 481 unit tests passing
1 parent 4fc0809 commit d265594

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

src/ui/src/components/test-studio/TestSets.jsx

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ const TestSets = () => {
185185
setConfirmReplacement(false);
186186
}
187187
} catch (err) {
188-
setError(`Failed to validate test set name: ${err.message}`);
188+
console.error('Error validating test set name:', err);
189+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
190+
setError(`Failed to validate test set name: ${errorMessage}`);
189191
return;
190192
}
191193

@@ -231,7 +233,9 @@ const TestSets = () => {
231233
setError('Failed to create test set - no data returned');
232234
}
233235
} catch (err) {
234-
setError(`Failed to add test set: ${err.message}`);
236+
console.error('Error adding test set:', err);
237+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
238+
setError(`Failed to add test set: ${errorMessage}`);
235239
} finally {
236240
setLoading(false);
237241
}
@@ -269,7 +273,9 @@ const TestSets = () => {
269273
setConfirmReplacement(false);
270274
}
271275
} catch (err) {
272-
setError(`Failed to validate test set name: ${err.message}`);
276+
console.error('Error validating test set name:', err);
277+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
278+
setError(`Failed to validate test set name: ${errorMessage}`);
273279
return;
274280
}
275281

@@ -342,7 +348,9 @@ const TestSets = () => {
342348
setNewTestSetName('');
343349
setZipFile(null);
344350
} catch (err) {
345-
setError(`Failed to create test set: ${err.message}`);
351+
console.error('Error creating test set:', err);
352+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
353+
setError(`Failed to create test set: ${errorMessage}`);
346354
} finally {
347355
setLoading(false);
348356
}
@@ -357,7 +365,9 @@ const TestSets = () => {
357365
const result = await client.graphql({ query: GET_TEST_SETS });
358366
setTestSets(result.data.getTestSets || []);
359367
} catch (err) {
360-
setError(`Failed to refresh test sets: ${err.message}`);
368+
console.error('Error refreshing test sets:', err);
369+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
370+
setError(`Failed to refresh test sets: ${errorMessage}`);
361371
} finally {
362372
setRefreshing(false);
363373
}
@@ -378,7 +388,9 @@ const TestSets = () => {
378388
setSuccessMessage(`Successfully deleted ${deleteCount} test set${deleteCount > 1 ? 's' : ''}`);
379389
setError('');
380390
} catch (err) {
381-
setError(`Failed to delete test sets: ${err.message}`);
391+
console.error('Error deleting test sets:', err);
392+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
393+
setError(`Failed to delete test sets: ${errorMessage}`);
382394
} finally {
383395
setLoading(false);
384396
}
@@ -722,7 +734,9 @@ const TestSets = () => {
722734
setWarningMessage('');
723735
}
724736
} catch (err) {
725-
setError(`Failed to validate test set name: ${err.message}`);
737+
console.error('Error validating test set name:', err);
738+
const errorMessage = err?.message || err?.errors?.[0]?.message || JSON.stringify(err) || 'Unknown error';
739+
setError(`Failed to validate test set name: ${errorMessage}`);
726740
setZipFile(null);
727741
setNewTestSetName('');
728742
return;

src/ui/src/graphql/queries/addTestSet.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// SPDX-License-Identifier: Apache-2.0
33

44
const ADD_TEST_SET = `
5-
mutation AddTestSet($name: String!, $filePattern: String!, $fileCount: Int!) {
6-
addTestSet(name: $name, filePattern: $filePattern, fileCount: $fileCount) {
5+
mutation AddTestSet($name: String!, $filePattern: String!, $bucketType: String!, $fileCount: Int!) {
6+
addTestSet(name: $name, filePattern: $filePattern, bucketType: $bucketType, fileCount: $fileCount) {
77
id
88
name
99
filePattern

0 commit comments

Comments
 (0)