Skip to content

Commit e6a72fd

Browse files
committed
Merge branch 'feature/vincilb/credential-vendor-cicd' into 'develop'
Migrated CICD Integration Account See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!181
2 parents 9a009b8 + ab44120 commit e6a72fd

File tree

5 files changed

+11
-16
lines changed

5 files changed

+11
-16
lines changed

.gitlab-ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ developer_tests:
4646

4747
integration_tests:
4848
stage: integration_tests
49-
variables:
50-
# In order to run tests in another account, add a AWS_CREDS_TARGET_ROLE variable to the Gitlab pipeline variables.
51-
AWS_CREDS_TARGET_ROLE: ${AWS_CREDS_TARGET_ROLE}
52-
AWS_DEFAULT_REGION: ${AWS_DEFAULT_REGION}
53-
IDP_ACCOUNT_ID: ${IDP_ACCOUNT_ID}
49+
# variables:
50+
# # In order to run tests in another account, add a AWS_CREDS_TARGET_ROLE variable to the Gitlab pipeline variables.
51+
# AWS_CREDS_TARGET_ROLE: ${AWS_CREDS_TARGET_ROLE}
52+
# AWS_DEFAULT_REGION: ${AWS_DEFAULT_REGION}
53+
# IDP_ACCOUNT_ID: ${IDP_ACCOUNT_ID}
5454

5555
# Add rules to only run on develop branch
5656
rules:

scripts/sdlc/cfn/codepipeline-s3.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Parameters:
1313
BucketName:
1414
Type: String
1515
Description: 'Name of the S3 bucket containing the deployment assets'
16-
Default: idp-sdlc-source-code-YOUR_AWS_ACCOUNT-YOUR_REGION
16+
Default: idp-sdlc-sourcecode-YOUR_AWS_ACCOUNT-YOUR_REGION
1717

1818
FileKey:
1919
Type: String

scripts/sdlc/cfn/credential-vendor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Parameters:
2727
Type: String
2828
Description: Source code bucket name
2929
AllowedPattern: .+
30-
Default: idp-sdlc-source-code-YOUR_AWS_ACCOUNT-YOUR_REGION
30+
Default: idp-sdlc-sourcecode-YOUR_AWS_ACCOUNT-YOUR_REGION
3131
ConstraintDescription: Source code bucket must be provided
3232

3333
Resources:

scripts/sdlc/cfn/s3-sourcecode.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ Parameters:
88
BucketName:
99
Type: String
1010
Description: Name of the S3 bucket to create
11-
Default: idp-sdlc-source-code-YOUR_AWS_ACCOUNT-YOUR_REGION
11+
Default: idp-sdlc-sourcecode-YOUR_AWS_ACCOUNT-YOUR_REGION
1212

1313
Resources:
14-
IdkInitialInstallAsset:
14+
InitialInstallBucket:
1515
Type: 'AWS::S3::Bucket'
1616
Metadata:
1717
cfn_nag:
@@ -34,8 +34,3 @@ Resources:
3434
ServerSideEncryptionConfiguration:
3535
- ServerSideEncryptionByDefault:
3636
SSEAlgorithm: AES256
37-
38-
Outputs:
39-
BucketName:
40-
Description: Name of the created S3 bucket
41-
Value: !Ref IdkInitialInstallAsset

scripts/sdlc/idp-cli/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
IDP_ACCOUNT_ID?=715841340161
22
AWS_REGION?=us-east-1
3-
IDP_ADMIN_EMAIL?=vincilb@amazon.com
3+
IDP_ADMIN_EMAIL?=strahanr@amazon.com
44
IDP_CWD?=../../../
55
DEBUG?=True
66

77
INSTALL_BUCKET?=none
8-
SDLC_SOURCE_CODE_BUCKET?=idp-sdlc-source-code-$(IDP_ACCOUNT_ID)-$(AWS_REGION)
8+
SDLC_SOURCE_CODE_BUCKET?=idp-sdlc-sourcecode-$(IDP_ACCOUNT_ID)-$(AWS_REGION)
99
IDP_CFN_PREFIX?=idp-dev
1010
IDP_STACK_NAME?=$(IDP_CFN_PREFIX)
1111
IDP_PIPELINE_NAME?=idp-sdlc-deploy-pipeline

0 commit comments

Comments
 (0)