Fixed type checking issues

Author: webarch-ai

lib/idp_common_pkg/idp_common/agents/error_analyzer/tools/cloudwatch_tool.py

@@ -527,8 +527,8 @@ def _search_cloudwatch_logs(
     filter_pattern: str = "",
     hours_back: int = 24,
     max_events: int = 10,
-    start_time: datetime = None,
-    end_time: datetime = None,
+    start_time: Optional[datetime] = None,
+    end_time: Optional[datetime] = None,
     request_id: str = "",
 ) -> Dict[str, Any]:
     """

lib/idp_common_pkg/idp_common/agents/error_analyzer/tools/dynamodb_tool.py

@@ -194,7 +194,7 @@ def _get_tracking_table():
         return None, None
 
     dynamodb = boto3.resource("dynamodb")
-    table = dynamodb.Table(table_name)
+    table = dynamodb.Table(table_name)  # type: ignore[attr-defined]
     return table, table_name
 
 

lib/idp_common_pkg/idp_common/agents/error_analyzer/tools/xray_tool.py

@@ -8,7 +8,7 @@
 import json
 import logging
 import os
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, timezone
 from typing import Any, Dict, List, Optional
 
 import boto3
@@ -129,7 +129,7 @@ def analyze_system_performance(
         # hours_back already has proper default
         xray_client = boto3.client("xray")
 
-        end_time = datetime.utcnow()
+        end_time = datetime.now(timezone.utc)
         start_time = end_time - timedelta(hours=hours_back)
 
         # Try stack-specific analysis first if stack_name provided
@@ -246,7 +246,7 @@ def _get_trace_id_from_xray_annotations(document_id: str, xray_client) -> Option
     """
     logger.info(f"Searching X-Ray traces by annotation for document {document_id}")
 
-    end_time = datetime.utcnow()
+    end_time = datetime.now(timezone.utc)
     start_time = end_time - timedelta(hours=24)
 
     response = xray_client.get_trace_summaries(

lib/idp_common_pkg/tests/unit/agents/error_analyzer/test_agent.py

@@ -40,7 +40,7 @@ def test_create_error_analyzer_agent(
 
         assert agent is not None
         assert hasattr(agent, "tools")
-        assert len(agent.tools) == 7  # All specific tools
+        assert len(agent.tools) == 7  # All specific tools  # type: ignore[attr-defined]
 
     @patch("idp_common.agents.error_analyzer.agent.strands.Agent")
     @patch("boto3.Session")
@@ -64,7 +64,7 @@ def test_create_error_analyzer_agent_with_defaults(
 
         assert agent is not None
         assert hasattr(agent, "tools")
-        assert len(agent.tools) == 7
+        assert len(agent.tools) == 7  # type: ignore[attr-defined]
 
     @patch("idp_common.agents.error_analyzer.agent.strands.Agent")
     @patch("boto3.Session")