Update code based on review comments

Author: anajmi07

README.md

@@ -91,13 +91,15 @@ curl -X POST http://localhost:8080/invocations \
   -H "Content-Type: application/json" \
   -d '{"input": {"prompt": "Hello", "conversation_id": "<conversation_id>"}}' 
 
-curl -X POST http://localhost:8080/api/v1/feedback \
+curl -X POST http://localhost:8080/api/v1/invocations \
   -H "Content-Type: application/json" \
   -d '{
-    "run_id": "<run-id>",
-    "session_id": "<session-id>", 
-    "score": 1.0,
-    "comment": "Great response!"
+    "feedback": {
+      "run_id": "<run-id>",
+      "session_id": "<session-id>", 
+      "score": 1.0,
+      "comment": "Great response!"
+    }
   }'
 
 

cx-agent-backend/src/domain/services/agent_service.py

@@ -24,6 +24,7 @@ class AgentRequest:
     user_id: str
     model: str
     session_id: str | None = None
+    trace_id: str | None = None
 
 
 @dataclass(frozen=True)

cx-agent-backend/src/domain/services/conversation_service.py

@@ -72,6 +72,7 @@ async def send_message(
             user_id=conversation.user_id,
             model=model,
             session_id=str(conversation.id),
+            trace_id=None,  # Can be set from FastAPI layer
         )
         agent_response = await self._agent_service.process_request(agent_request)
 
@@ -126,7 +127,9 @@ async def log_feedback(self, user_id: str, session_id: str, message_id: str, sco
 
         try:
 
-            logger.info("[FEEDBACK] Langfuse config: %s", self._langfuse_config)
+            logger.info("[FEEDBACK] Langfuse config - enabled: %s, host: %s", 
+                       self._langfuse_config.get("enabled"), 
+                       self._langfuse_config.get("host"))
 
             if self._langfuse_config.get("enabled"):
                 logger.info("[FEEDBACK] Langfuse is enabled, setting environment variables")
@@ -152,5 +155,5 @@ async def log_feedback(self, user_id: str, session_id: str, message_id: str, sco
                 logger.info("[FEEDBACK] Successfully created score: %s", result)
             else:
                 logger.info("[FEEDBACK] Langfuse is not enabled in config")
-        except Exception:
-            logger.exception("[FEEDBACK] Failed to log feedback to Langfuse")
+        except Exception as e:
+            logger.error(f"[FEEDBACK] Failed to log feedback to Langfuse: {e}")

cx-agent-backend/src/infrastructure/adapters/langgraph_agent_service.py

@@ -3,7 +3,6 @@
 from langchain_core.messages import AIMessage, HumanMessage
 from langchain_core.runnables import RunnableConfig
 import os
-import base64
 import logging
 from langgraph.prebuilt import create_react_agent
 from langfuse import get_client, Langfuse
@@ -84,6 +83,14 @@ async def process_request(self, request: AgentRequest) -> AgentResponse:
             request.agent_type,
         )
 
+        # Use trace_id from request if provided, otherwise create one
+        langfuse = None
+        predefined_trace_id = getattr(request, 'trace_id', None)
+        if self._langfuse_config.get("enabled"):
+            langfuse = get_client()
+            if not predefined_trace_id:
+                predefined_trace_id = Langfuse.create_trace_id(seed=request.session_id)
+        
         # Check input guardrails if enabled
         if self._guardrail_service and request.messages:
             last_user_message = None
@@ -128,8 +135,6 @@ async def process_request(self, request: AgentRequest) -> AgentResponse:
             os.environ["LANGFUSE_PUBLIC_KEY"] = self._langfuse_config.get("public_key")
             os.environ["LANGFUSE_HOST"] = self._langfuse_config.get("host")
 
-            langfuse = get_client()
-            predefined_trace_id = Langfuse.create_trace_id(seed=request.session_id)
             trace_id = predefined_trace_id
 
             langfuse_handler = CallbackHandler()
@@ -145,7 +150,7 @@ async def process_request(self, request: AgentRequest) -> AgentResponse:
 
                 config = RunnableConfig(
                     configurable={
-                        "thread_id": f"{request.user_id}_{request.session_id}",
+                        "thread_id": f"{request.session_id}",
                         "user_id": request.user_id,
                     },
                     callbacks=[langfuse_handler],

cx-agent-backend/src/infrastructure/adapters/openai_llm_service.py

@@ -3,7 +3,7 @@
 from langchain_core.messages import AIMessage, HumanMessage, SystemMessage
 from langchain_openai import ChatOpenAI
 
-from domain.entities.conversation import Message, MessageRole
+from domain.entities.conversation import MessageRole
 from domain.services.llm_service import LLMRequest, LLMResponse, LLMService
 
 

cx-agent-backend/src/infrastructure/adapters/tools.py

@@ -3,14 +3,12 @@
 import boto3
 from langchain_aws import AmazonKnowledgeBasesRetriever
 from langchain_core.tools import tool
-from langchain.tools import tool as langchain_tool
 import logging
 import json
 
 from infrastructure.config.settings import settings
 from infrastructure.aws.secret_reader import AWSSecretsReader
 from infrastructure.aws.parameter_store_reader import AWSParameterStoreReader
-import os
 
 logger = logging.getLogger(__name__)
 

cx-agent-backend/src/main.py

@@ -2,7 +2,6 @@
 
 import structlog
 from fastapi import FastAPI, Request
-from fastapi.middleware.cors import CORSMiddleware
 
 from infrastructure.config.container import Container
 from infrastructure.config.settings import settings
@@ -60,7 +59,7 @@ async def ping():
 
     @app.post("/invocations")
     async def invocations(request: dict, http_request: Request):
-        from fastapi import HTTPException, Request
+        from fastapi import HTTPException
         from presentation.api.conversation_router import send_message
         from presentation.schemas.conversation_schemas import SendMessageRequest
         from datetime import datetime

cx-agent-backend/src/presentation/api/conversation_router.py

@@ -11,8 +11,6 @@
 from presentation.schemas.conversation_schemas import (
     ConversationSchema,
     CreateConversationRequest,
-    FeedbackRequest,
-    FeedbackResponse,
     MessageSchema,
     SendMessageRequest,
     SendMessageResponse,
@@ -154,25 +152,4 @@ async def get_user_conversations(
     return [_conversation_to_schema(conv) for conv in conversations]
 
 
-@router.post("/feedback", response_model=FeedbackResponse)
-@inject
-async def submit_feedback(
-    request: FeedbackRequest,
-    conversation_service: ConversationService = Depends(
-        Provide[Container.conversation_service]
-    ),
-) -> FeedbackResponse:
-    """Submit user feedback for a message."""
-    try:
-        # Convert score to 1/0 format
-        feedback_score = 1 if request.score > 0.5 else 0
-        
-        # Log feedback to Langfuse
-        await conversation_service.log_feedback("default_user", request.session_id, request.run_id, feedback_score, request.comment)
-        
-        return FeedbackResponse()
-    except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to submit feedback: {str(e)}",
-        )
+

cx-agent-frontend/src/services/agentcore_client.py

@@ -4,7 +4,6 @@
 import urllib.parse
 import json
 import uuid
-import streamlit as st
 
 
 class AgentCoreClient: