Deprecated filter methods (#133)

* fixed issue with OD pricing for european regions

* made string replacement more readable in getRegionForPricingAPI

* implemented sorting of instance types

* fixed typo in filtering error message

* moved sort to selector.go and refactored FilterVerbose tests

* brought back FilterWithOutput() in selector.go

* working implementation of refactoring solution

* Deprecated the filter methods in selector.go

* added the names of replacement functions to deprecated comments

Co-authored-by: Rodrigo Okamoto <rodocp@amazon.com>

Author: digocorbellini

pkg/selector/selector.go

@@ -132,6 +132,9 @@ func (itf Selector) Save() error {
 
 // Filter accepts a Filters struct which is used to select the available instance types
 // matching the criteria within Filters and returns a simple list of instance type strings
+//
+// Deprecated: This function will be replaced with GetFilteredInstanceTypes() and
+// OutputInstanceTypes() in the next major version.
 func (itf Selector) Filter(filters Filters) ([]string, error) {
 	outputFn := InstanceTypesOutputFn(outputs.SimpleInstanceTypeOutput)
 	output, _, err := itf.FilterWithOutput(filters, outputFn)
@@ -140,6 +143,9 @@ func (itf Selector) Filter(filters Filters) ([]string, error) {
 
 // FilterVerbose accepts a Filters struct which is used to select the available instance types
 // matching the criteria within Filters and returns a list instanceTypeInfo
+//
+// Deprecated: This function will be replaced with GetFilteredInstanceTypes() in the next
+// major version.
 func (itf Selector) FilterVerbose(filters Filters) ([]*instancetypes.Details, error) {
 	instanceTypeInfoSlice, err := itf.rawFilter(filters)
 	if err != nil {
@@ -151,6 +157,9 @@ func (itf Selector) FilterVerbose(filters Filters) ([]*instancetypes.Details, er
 
 // FilterWithOutput accepts a Filters struct which is used to select the available instance types
 // matching the criteria within Filters and returns a list of strings based on the custom outputFn
+//
+// Deprecated: This function will be replaced with GetFilteredInstanceTypes() and
+// OutputInstanceTypes() in the next major version.
 func (itf Selector) FilterWithOutput(filters Filters, outputFn InstanceTypesOutput) ([]string, int, error) {
 	instanceTypeInfoSlice, err := itf.rawFilter(filters)
 	if err != nil {