fix tf validation and docker binary building (#94)

Author: bwagner5

Dockerfile

@@ -2,11 +2,11 @@
 FROM public.ecr.aws/bitnami/golang:1.16 as builder
 
 ## GOLANG env
-ENV GOPROXY="https://proxy.golang.org|direct"
-ENV GO111MODULE="on"
-ENV CGO_ENABLED=0
-ENV GOOS=linux 
-ENV GOARCH=amd64 
+ARG GOPROXY="https://proxy.golang.org|direct"
+ARG GO111MODULE="on"
+ARG CGO_ENABLED=0
+ARG GOOS=linux 
+ARG GOARCH=amd64 
 
 # Copy go.mod and download dependencies
 WORKDIR /amazon-ec2-instance-selector

Makefile

@@ -41,7 +41,7 @@ docker-push:
 	docker push ${IMG_W_TAG}
 
 build-docker-images:
-	${MAKEFILE_PATH}/scripts/build-docker-images -p ${SUPPORTED_PLATFORMS} -r ${IMG} -v ${VERSION}
+	${MAKEFILE_PATH}/scripts/build-docker-images -d -p ${SUPPORTED_PLATFORMS} -r ${IMG} -v ${VERSION}
 
 push-docker-images:
 	@docker login -u ${DOCKERHUB_USERNAME} -p="${DOCKERHUB_TOKEN}"
@@ -80,7 +80,7 @@ output-validation-test:
 	${MAKEFILE_PATH}/test/output-validation-test/test-output-validation
 
 build-binaries:
-	${MAKEFILE_PATH}/scripts/build-binaries -p ${SUPPORTED_PLATFORMS} -v ${VERSION}
+	${MAKEFILE_PATH}/scripts/build-binaries -d -p ${SUPPORTED_PLATFORMS} -v ${VERSION}
 
 ## requires a github token
 upload-resources-to-github:

test/output-validation-test/test-output-validation

@@ -29,8 +29,8 @@ docker run --rm -v $BUILD_DIR:/data cfn-lint /data/cfn.yaml
 echo "✅ Passed CFN YAML and JSON Validation"
 
 ## Terraform Validation
-$BUILD_DIR/bin/ec2-instance-selector-$PLATFORM -o terraform-hcl > $BUILD_DIR/terraform.hcl
-docker run -it --rm -v $BUILD_DIR:/data hashicorp/terraform:light init -backend=false /data/
-docker run -it --rm -v $BUILD_DIR:/data hashicorp/terraform:light validate -json /data/
+$BUILD_DIR/bin/ec2-instance-selector-$PLATFORM -o terraform-hcl > $BUILD_DIR/terraform.tf
+docker run -it --rm -v $BUILD_DIR:/data -w /data hashicorp/terraform:light init -backend=false 
+docker run -it --rm -v $BUILD_DIR:/data -w /data hashicorp/terraform:light validate -json
 
 echo "✅ Passed Terraform HCL Validation"