Skip to content

Commit e319f7f

Browse files
authored
Make localName optional in getV3ClientImportSpecifier (#395)
1 parent ba2488e commit e319f7f

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

src/transforms/v2-to-v3/modules/addV3ClientImports.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export const addV3ClientImports = (
3636
addV3ClientNamedImport(j, source, {
3737
...options,
3838
importedName: v3WaiterApiName,
39-
localName: v3WaiterApiName,
4039
});
4140
}
4241
};

src/transforms/v2-to-v3/modules/addV3ClientNamedImport.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,11 @@ import { V3ClientImportSpecifierOptions, V3ClientModulesOptions } from "./types"
99
export const addV3ClientNamedImport = (
1010
j: JSCodeshift,
1111
source: Collection<unknown>,
12-
{
13-
localName,
14-
importedName,
15-
v2ClientName,
16-
v2ClientLocalName,
17-
v3ClientPackageName,
18-
}: V3ClientModulesOptions & V3ClientImportSpecifierOptions
12+
options: V3ClientModulesOptions & V3ClientImportSpecifierOptions
1913
) => {
14+
const { importedName, v2ClientName, v2ClientLocalName, v3ClientPackageName } = options;
15+
const localName = options.localName ?? importedName;
16+
2017
const importDeclarations = source.find(j.ImportDeclaration, {
2118
source: { value: v3ClientPackageName },
2219
});

src/transforms/v2-to-v3/modules/getV3ClientImportSpecifier.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ export const getV3ClientImportSpecifier = (
66
j: JSCodeshift,
77
{ importedName, localName }: V3ClientImportSpecifierOptions
88
) =>
9-
importedName === localName
10-
? j.importSpecifier(j.identifier(importedName))
11-
: j.importSpecifier(j.identifier(importedName), j.identifier(localName));
9+
localName
10+
? j.importSpecifier(j.identifier(importedName), j.identifier(localName))
11+
: j.importSpecifier(j.identifier(importedName));

src/transforms/v2-to-v3/modules/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export interface V3ClientRequirePropertyOptions {
1313

1414
export interface V3ClientImportSpecifierOptions {
1515
importedName: string;
16-
localName: string;
16+
localName?: string;
1717
}

0 commit comments

Comments
 (0)