From d3e61b5dc0d42258cbd493e162e1a6b6f76978ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dietmar=20K=C3=BChl?= <dietmar.kuehl@me.com>
Date: Fri, 3 Jan 2025 00:13:03 +0000
Subject: [PATCH 1/5] started to implement on

---
 include/beman/execution26/detail/on.hpp       |  85 ++++++++++++++
 .../detail/sender_adaptor_closure.hpp         |   8 ++
 include/beman/execution26/execution.hpp       |   3 +-
 src/beman/execution26/CMakeLists.txt          |   1 +
 tests/beman/execution26/CMakeLists.txt        |   3 +-
 tests/beman/execution26/exec-on.test.cpp      |  57 +++++++++
 .../execution26/include/test/thread_pool.hpp  | 108 ++++++++++++++++++
 7 files changed, 263 insertions(+), 2 deletions(-)
 create mode 100644 include/beman/execution26/detail/on.hpp
 create mode 100644 tests/beman/execution26/exec-on.test.cpp
 create mode 100644 tests/beman/execution26/include/test/thread_pool.hpp

diff --git a/include/beman/execution26/detail/on.hpp b/include/beman/execution26/detail/on.hpp
new file mode 100644
index 00000000..1290efc0
--- /dev/null
+++ b/include/beman/execution26/detail/on.hpp
@@ -0,0 +1,85 @@
+// include/beman/execution26/detail/on.hpp                            -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+#ifndef INCLUDED_INCLUDE_BEMAN_EXECUTION26_DETAIL_ON
+#define INCLUDED_INCLUDE_BEMAN_EXECUTION26_DETAIL_ON
+
+#include <beman/execution26/detail/scheduler.hpp>
+#include <beman/execution26/detail/sender.hpp>
+#include <beman/execution26/detail/sender_adaptor_closure.hpp>
+#include <beman/execution26/detail/transform_sender.hpp>
+#include <beman/execution26/detail/query_with_default.hpp>
+#include <beman/execution26/detail/get_domain.hpp>
+#include <beman/execution26/detail/get_domain_early.hpp>
+#include <beman/execution26/detail/default_domain.hpp>
+#include <beman/execution26/detail/make_sender.hpp>
+#include <beman/execution26/detail/product_type.hpp>
+#include <beman/execution26/detail/sender_for.hpp>
+#include <beman/execution26/detail/join_env.hpp>
+#include <beman/execution26/detail/forward_like.hpp>
+#include <beman/execution26/detail/fwd_env.hpp>
+#include <beman/execution26/detail/sched_env.hpp>
+#include <utility>
+
+// ----------------------------------------------------------------------------
+
+namespace beman::execution26::detail {
+struct on_t {
+    template <::beman::execution26::detail::sender_for<on_t> OutSndr, typename Env>
+    auto transform_env(OutSndr&& out_sndr, Env&& env) const -> decltype(auto) {
+        // auto&&[_, data, _] = out_sndr;
+        auto&& data{out_sndr.template get<1>()};
+
+        if constexpr (::beman::execution26::scheduler<decltype(data)>)
+            return ::beman::execution26::detail::join_env(
+                ::beman::execution26::detail::sched_env(::beman::execution26::detail::forward_like<OutSndr>(data)
+
+                                                            ),
+                ::beman::execution26::detail::fwd_env(::std::forward<Env>(env)));
+        else
+            return std::forward<Env>(env);
+    }
+
+    template <::beman::execution26::scheduler Sch, ::beman::execution26::sender Sndr>
+        requires ::beman::execution26::detail::is_sender_adaptor_closure<Sndr>
+    auto operator()(Sch&&, Sndr&&) const -> void =
+        BEMAN_EXECUTION26_DELETE("on(sch, sndr) requires that sndr isn't both a sender and sender adaptor closure");
+
+    template <::beman::execution26::scheduler                         Sch,
+              ::beman::execution26::sender                            Sndr,
+              ::beman::execution26::detail::is_sender_adaptor_closure Closure>
+        requires ::beman::execution26::detail::is_sender_adaptor_closure<Sndr>
+    auto operator()(Sndr&&, Sch&&, Closure&&) const -> void =
+        BEMAN_EXECUTION26_DELETE("on(sch, sndr) requires that sndr isn't both a sender and sender adaptor closure");
+
+    template <::beman::execution26::scheduler Sch, ::beman::execution26::sender Sndr>
+    auto operator()(Sch&& sch, Sndr&& sndr) const {
+        auto domain{::beman::execution26::detail::query_with_default(
+            ::beman::execution26::get_domain, sch, ::beman::execution26::default_domain{})};
+        return ::beman::execution26::transform_sender(
+            domain,
+            ::beman::execution26::detail::make_sender(*this, ::std::forward<Sch>(sch), ::std::forward<Sndr>(sndr)));
+    }
+    template <::beman::execution26::scheduler                         Sch,
+              ::beman::execution26::sender                            Sndr,
+              ::beman::execution26::detail::is_sender_adaptor_closure Closure>
+    auto operator()(Sndr&& sndr, Sch&& sch, Closure&& closure) const {
+        auto domain{::beman::execution26::detail::get_domain_early(sndr)};
+        return ::beman::execution26::transform_sender(
+            domain,
+            ::beman::execution26::detail::make_sender(
+                *this,
+                ::beman::execution26::detail::product_type{::std::forward<Sch>(sch), ::std::forward<Closure>(closure)},
+                ::std::forward<Sndr>(sndr)));
+    }
+};
+} // namespace beman::execution26::detail
+
+namespace beman::execution26 {
+using on_t = ::beman::execution26::detail::on_t;
+inline constexpr ::beman::execution26::on_t on{};
+} // namespace beman::execution26
+
+// ----------------------------------------------------------------------------
+
+#endif
diff --git a/include/beman/execution26/detail/sender_adaptor_closure.hpp b/include/beman/execution26/detail/sender_adaptor_closure.hpp
index 53945dc2..23da0705 100644
--- a/include/beman/execution26/detail/sender_adaptor_closure.hpp
+++ b/include/beman/execution26/detail/sender_adaptor_closure.hpp
@@ -20,8 +20,16 @@ namespace beman::execution26 {
 template <typename>
 struct sender_adaptor_closure : ::beman::execution26::detail::pipeable::sender_adaptor_closure_base {};
 // NOLINTEND(bugprone-crtp-constructor-accessibility)
+
 } // namespace beman::execution26
 
+namespace beman::execution26::detail {
+template <typename Closure>
+concept is_sender_adaptor_closure =
+    ::std::derived_from<::std::decay_t<Closure>,
+                        ::beman::execution26::sender_adaptor_closure<::std::decay_t<Closure>>>;
+}
+
 namespace beman::execution26::detail::pipeable {
 template <::beman::execution26::sender Sender, typename Adaptor>
     requires(not::beman::execution26::sender<Adaptor>) &&
diff --git a/include/beman/execution26/execution.hpp b/include/beman/execution26/execution.hpp
index 10f33ede..7d88ffa9 100644
--- a/include/beman/execution26/execution.hpp
+++ b/include/beman/execution26/execution.hpp
@@ -42,15 +42,16 @@
 #include <beman/execution26/detail/into_variant.hpp>
 #include <beman/execution26/detail/just.hpp>
 #include <beman/execution26/detail/let.hpp>
+// #include <beman/execution26/detail/on.hpp>
 #include <beman/execution26/detail/read_env.hpp>
 #include <beman/execution26/detail/schedule_from.hpp>
 #include <beman/execution26/detail/starts_on.hpp>
 #include <beman/execution26/detail/sync_wait.hpp>
 #include <beman/execution26/detail/then.hpp>
-#include <beman/execution26/detail/write_env.hpp>
 #include <beman/execution26/detail/when_all.hpp>
 #include <beman/execution26/detail/when_all_with_variant.hpp>
 #include <beman/execution26/detail/with_awaitable_senders.hpp>
+#include <beman/execution26/detail/write_env.hpp>
 
 // ----------------------------------------------------------------------------
 
diff --git a/src/beman/execution26/CMakeLists.txt b/src/beman/execution26/CMakeLists.txt
index a7463994..1c02b30a 100644
--- a/src/beman/execution26/CMakeLists.txt
+++ b/src/beman/execution26/CMakeLists.txt
@@ -123,6 +123,7 @@ target_sources(
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/nostopstate.hpp
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/nothrow_callable.hpp
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/notify.hpp
+         ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/on.hpp
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/on_stop_request.hpp
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/operation_state.hpp
          ${PROJECT_SOURCE_DIR}/include/beman/execution26/detail/operation_state_task.hpp
diff --git a/tests/beman/execution26/CMakeLists.txt b/tests/beman/execution26/CMakeLists.txt
index 068148df..0166c7e3 100644
--- a/tests/beman/execution26/CMakeLists.txt
+++ b/tests/beman/execution26/CMakeLists.txt
@@ -11,6 +11,7 @@ endif()
 list(
   APPEND
   execution_tests
+  exec-on.test
   notify.test
   exec-scounting.test
   exec-awaitable.test
@@ -128,7 +129,7 @@ foreach(test ${execution_tests})
   add_test(NAME ${TEST_EXE} COMMAND $<TARGET_FILE:${TEST_EXE}>)
 endforeach()
 
-if(NOT PROJECT_IS_TOP_LEVEL)
+if(PROJECT_IS_TOP_LEVEL)
   # test if the targets are findable from the build directory
   # cmake-format: off
   add_test(NAME find-package-test
diff --git a/tests/beman/execution26/exec-on.test.cpp b/tests/beman/execution26/exec-on.test.cpp
new file mode 100644
index 00000000..cfd8a995
--- /dev/null
+++ b/tests/beman/execution26/exec-on.test.cpp
@@ -0,0 +1,57 @@
+// tests/beman/execution26/exec-on.test.cpp                           -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+#include <beman/execution26/detail/on.hpp>
+#include <beman/execution26/detail/just.hpp>
+#include <beman/execution26/detail/sender_adaptor_closure.hpp>
+#include <beman/execution26/detail/then.hpp>
+#include <test/execution.hpp>
+#include <test/thread_pool.hpp>
+#include <concepts>
+
+// ----------------------------------------------------------------------------
+
+namespace {
+struct both : test_std::sender_adaptor_closure<both> {
+    using sender_concept = test_std::sender_t;
+};
+
+static_assert(test_std::sender<both>);
+static_assert(test_detail::is_sender_adaptor_closure<both>);
+
+template <test_std::scheduler                    Sch,
+          test_std::sender                       Sndr,
+          test_detail::is_sender_adaptor_closure Closure,
+          typename Both>
+auto test_interface(Sch sch, Sndr sndr, Closure closure, Both both) -> void {
+    static_assert(requires {
+        { test_std::on(sch, sndr) } -> test_std::sender;
+    });
+    static_assert(not requires { test_std::on(sch, both); });
+    static_assert(requires {
+        { test_std::on(sndr, sch, closure) } -> test_std::sender;
+    });
+    static_assert(not requires { test_std::on(both, sch, closure); });
+
+    auto sndr1{test_std::on(sch, sndr)};
+    auto sndr2{test_std::on(sndr, sch, closure)};
+    test::use(sndr1, sndr2);
+}
+
+template <test_detail::sender_for<test_std::on_t> OutSndr>
+auto test_transform_env(OutSndr out_sndr) -> void {
+    auto e{test_std::on.transform_env(out_sndr, test_std::empty_env{})};
+}
+} // namespace
+
+TEST(exec_on) {
+    test::thread_pool pool{};
+
+    static_assert(std::same_as<const test_std::on_t, decltype(test_std::on)>);
+    static_assert(test_detail::is_sender_adaptor_closure<decltype(test_std::then([] {}))>);
+    static_assert(not test_detail::is_sender_adaptor_closure<decltype(test_std::just([] {}))>);
+    test_interface(pool.get_scheduler(), test_std::just(), test_std::then([] {}), both{});
+
+    test_transform_env(test_std::on(pool.get_scheduler(), test_std::just()));
+    test_transform_env(test_std::on(test_std::just(), pool.get_scheduler(), test_std::then([] {})));
+}
\ No newline at end of file
diff --git a/tests/beman/execution26/include/test/thread_pool.hpp b/tests/beman/execution26/include/test/thread_pool.hpp
new file mode 100644
index 00000000..4758795e
--- /dev/null
+++ b/tests/beman/execution26/include/test/thread_pool.hpp
@@ -0,0 +1,108 @@
+// tests/beman/execution26/include/test/thread_pool.hpp               -*-C++-*-
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+// ----------------------------------------------------------------------------
+
+#ifndef INCLUDED_TESTS_BEMAN_EXECUTION26_INCLUDE_TEST_THREAD_POOL
+#define INCLUDED_TESTS_BEMAN_EXECUTION26_INCLUDE_TEST_THREAD_POOL
+
+#include <beman/execution26/execution.hpp>
+#include <test/execution.hpp>
+
+#include <mutex>
+#include <condition_variable>
+#include <thread>
+#include <memory>
+// ----------------------------------------------------------------------------
+
+namespace test {
+struct thread_pool;
+}
+
+struct test::thread_pool {
+    struct node {
+        node*        next;
+        virtual void run() = 0;
+
+      protected:
+        ~node() = default;
+    };
+
+    std::mutex              mutex;
+    std::condition_variable condition;
+    node*                   stack{};
+    bool                    stopped{false};
+    std::thread             driver{[this] {
+        while (std::optional<node*> n = [this] {
+            std::unique_lock cerberus(mutex);
+            condition.wait(cerberus, [this] { return stopped || stack; });
+            return this->stack ? std::optional<node*>(std::exchange(this->stack, this->stack->next))
+                                           : std::optional<node*>();
+        }()) {
+            (*n)->run();
+        }
+    }};
+
+    thread_pool()              = default;
+    thread_pool(thread_pool&&) = delete;
+    ~thread_pool() {
+        this->stop();
+        this->driver.join();
+    }
+    void stop() {
+        {
+            std::lock_guard cerberus(this->mutex);
+            stopped = true;
+        }
+        this->condition.notify_one();
+    }
+
+    struct scheduler {
+        using scheduler_concept = test_std::scheduler_t;
+        struct env {
+            test::thread_pool* pool;
+
+            template <typename T>
+            scheduler query(const test_std::get_completion_scheduler_t<T>&) const noexcept {
+                return {this->pool};
+            }
+        };
+        template <typename Receiver>
+        struct state final : test::thread_pool::node {
+            using operation_state_concept = test_std::operation_state_t;
+            std::remove_cvref_t<Receiver> receiver;
+            test::thread_pool*            pool;
+
+            template <typename R>
+            state(R&& r, test::thread_pool* p) : node{}, receiver(std::forward<R>(r)), pool(p) {}
+            void start() & noexcept {
+                {
+                    std::lock_guard cerberus(this->pool->mutex);
+                    this->next = std::exchange(this->pool->stack, this);
+                }
+                this->pool->condition.notify_one();
+            }
+            void run() override { test_std::set_value(std::move(this->receiver)); }
+        };
+        struct sender {
+            using sender_concept        = test_std::sender_t;
+            using completion_signatures = test_std::completion_signatures<test_std::set_value_t()>;
+            test::thread_pool* pool;
+            template <typename Receiver>
+            state<Receiver> connect(Receiver&& receiver) {
+                return state<Receiver>(std::forward<Receiver>(receiver), pool);
+            }
+
+            env get_env() const noexcept { return {this->pool}; }
+        };
+        test::thread_pool* pool;
+        sender             schedule() { return {this->pool}; }
+        bool               operator==(const scheduler&) const = default;
+    };
+    scheduler get_scheduler() { return {this}; }
+};
+
+static_assert(test_std::scheduler<test::thread_pool::scheduler>);
+
+// ----------------------------------------------------------------------------
+
+#endif

From 2560003f8e24e865b97c8f2106eb876c0cd20d85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dietmar=20K=C3=BChl?= <dietmar.kuehl@me.com>
Date: Fri, 3 Jan 2025 21:57:39 +0000
Subject: [PATCH 2/5] added structured binding support for types derived from
 product type

---
 .../beman/execution26/detail/product_type.hpp | 23 +++++++++++++------
 tests/beman/execution26/CMakeLists.txt        |  2 +-
 .../beman/execution26/exec-snd-expos.test.cpp | 21 +++++++++++++++++
 3 files changed, 38 insertions(+), 8 deletions(-)

diff --git a/include/beman/execution26/detail/product_type.hpp b/include/beman/execution26/detail/product_type.hpp
index 8b1d9e49..c0b218b6 100644
--- a/include/beman/execution26/detail/product_type.hpp
+++ b/include/beman/execution26/detail/product_type.hpp
@@ -10,7 +10,8 @@
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
-template <::std::size_t, typename T>
+
+template <::std::size_t I, typename T>
 struct product_type_element {
     T    value;
     auto operator==(const product_type_element&) const -> bool = default;
@@ -23,6 +24,7 @@ template <::std::size_t... I, typename... T>
 struct product_type_base<::std::index_sequence<I...>, T...>
     : ::beman::execution26::detail::product_type_element<I, T>... {
     static constexpr ::std::size_t size() { return sizeof...(T); }
+    static constexpr bool is_product_type{true};
 
     template <::std::size_t J, typename S>
     static auto element_get(::beman::execution26::detail::product_type_element<J, S>& self) noexcept -> S& {
@@ -64,6 +66,10 @@ struct product_type_base<::std::index_sequence<I...>, T...>
     auto operator==(const product_type_base&) const -> bool = default;
 };
 
+template <typename T>
+concept is_product_type_c = requires(T const& t){ T::is_product_type; };
+
+
 template <typename... T>
 struct product_type : ::beman::execution26::detail::product_type_base<::std::index_sequence_for<T...>, T...> {
     template <typename Allocator, typename Product, std::size_t... I>
@@ -108,13 +114,16 @@ constexpr auto is_product_type(const ::beman::execution26::detail::product_type<
 } // namespace beman::execution26::detail
 
 namespace std {
-template <typename... T>
-struct tuple_size<::beman::execution26::detail::product_type<T...>>
-    : ::std::integral_constant<std::size_t, sizeof...(T)> {};
-template <::std::size_t I, typename... T>
-struct tuple_element<I, ::beman::execution26::detail::product_type<T...>> {
+template <typename T>
+     requires ::beman::execution26::detail::is_product_type_c<T>
+struct tuple_size<T>
+    : ::std::integral_constant<std::size_t, T::size()> {};
+
+template <::std::size_t I, typename T>
+     requires ::beman::execution26::detail::is_product_type_c<T>
+struct tuple_element<I, T> {
     using type =
-        ::std::decay_t<decltype(::std::declval<::beman::execution26::detail::product_type<T...>>().template get<I>())>;
+        ::std::decay_t<decltype(::std::declval<T>().template get<I>())>;
 };
 } // namespace std
 
diff --git a/tests/beman/execution26/CMakeLists.txt b/tests/beman/execution26/CMakeLists.txt
index 0166c7e3..b9130f6e 100644
--- a/tests/beman/execution26/CMakeLists.txt
+++ b/tests/beman/execution26/CMakeLists.txt
@@ -129,7 +129,7 @@ foreach(test ${execution_tests})
   add_test(NAME ${TEST_EXE} COMMAND $<TARGET_FILE:${TEST_EXE}>)
 endforeach()
 
-if(PROJECT_IS_TOP_LEVEL)
+if(NOT PROJECT_IS_TOP_LEVEL)
   # test if the targets are findable from the build directory
   # cmake-format: off
   add_test(NAME find-package-test
diff --git a/tests/beman/execution26/exec-snd-expos.test.cpp b/tests/beman/execution26/exec-snd-expos.test.cpp
index 27c1e12e..42015083 100644
--- a/tests/beman/execution26/exec-snd-expos.test.cpp
+++ b/tests/beman/execution26/exec-snd-expos.test.cpp
@@ -858,6 +858,27 @@ auto test_product_type() -> void {
     ASSERT(p5.get<2>() == nm(3));
     ASSERT(p5.get<3>() == nm(4));
     ASSERT(p5.get<4>() == nm(5));
+
+    test_detail::product_type prod{1, true, 'c'};
+    static_assert(test_detail::is_product_type_c<decltype(prod)>);
+    static_assert(3u == std::tuple_size<decltype(prod)>::value);
+    static_assert(std::same_as<int, std::tuple_element<0u, decltype(prod)>::type>);
+    static_assert(std::same_as<bool, std::tuple_element<1u, decltype(prod)>::type>);
+    static_assert(std::same_as<char, std::tuple_element<2u, decltype(prod)>::type>);
+    auto&&[i, b, c] = prod;
+    test::use(i, b, c);
+
+    struct derived: decltype(prod) {};
+    static_assert(3u == std::tuple_size<derived>::value);
+    static_assert(std::same_as<int, std::tuple_element<0u, derived>::type>);
+    static_assert(std::same_as<bool, std::tuple_element<1u, derived>::type>);
+    static_assert(std::same_as<char, std::tuple_element<2u, derived>::type>);
+    derived d{1, true, 'c'};
+    auto&&[di, db, dc] = d;
+    assert(di == d.get<0>());
+    assert(db == d.get<1>());
+    assert(dc == d.get<2>());
+    test::use(di, db, dc);
 }
 auto test_connect_all() -> void {
     static_assert(test_std::operation_state<operation_state<receiver>>);

From 00cce593960c3c6e4623fb063f9bb532313e923e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dietmar=20K=C3=BChl?= <dietmar.kuehl@me.com>
Date: Sat, 4 Jan 2025 14:42:54 +0000
Subject: [PATCH 3/5] added on algorithm and applies various fixes

---
 .../beman/execution26/detail/basic_sender.hpp |  6 +-
 include/beman/execution26/detail/connect.hpp  |  4 +-
 include/beman/execution26/detail/on.hpp       | 84 ++++++++++++++++++-
 .../beman/execution26/detail/product_type.hpp | 15 ++--
 .../execution26/detail/schedule_from.hpp      | 26 ++++--
 .../execution26/detail/transform_sender.hpp   | 25 +++---
 include/beman/execution26/execution.hpp       |  2 +-
 tests/beman/execution26/exec-on.test.cpp      | 78 ++++++++++++++++-
 .../beman/execution26/exec-snd-expos.test.cpp |  6 +-
 .../execution26/include/test/thread_pool.hpp  | 17 +++-
 10 files changed, 219 insertions(+), 44 deletions(-)

diff --git a/include/beman/execution26/detail/basic_sender.hpp b/include/beman/execution26/detail/basic_sender.hpp
index af0d0272..ce765f1e 100644
--- a/include/beman/execution26/detail/basic_sender.hpp
+++ b/include/beman/execution26/detail/basic_sender.hpp
@@ -74,7 +74,7 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
         return {::std::forward<Self>(self), ::std::move(receiver)};
     }
 #endif
-#if __cpp_explicit_this_parameter < 202110L
+#if __cpp_explicit_this_parameter < 302110L
     template <typename Env>
     auto
     get_completion_signatures(Env&&) && -> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env> {
@@ -82,7 +82,7 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
     }
     template <typename Env>
     auto get_completion_signatures(
-        Env&&) const&& -> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env> {
+        Env&&) const&& -> ::beman::execution26::detail::completion_signatures_for<const basic_sender, Env> {
         return {};
     }
     template <typename Env>
@@ -92,7 +92,7 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
     }
     template <typename Env>
     auto get_completion_signatures(
-        Env&&) const& -> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env> {
+        Env&&) const& -> ::beman::execution26::detail::completion_signatures_for<const basic_sender, Env> {
         return {};
     }
 #else
diff --git a/include/beman/execution26/detail/connect.hpp b/include/beman/execution26/detail/connect.hpp
index 0ec5a2c8..f47b3631 100644
--- a/include/beman/execution26/detail/connect.hpp
+++ b/include/beman/execution26/detail/connect.hpp
@@ -23,7 +23,9 @@ namespace beman::execution26::detail {
 struct connect_t {
   private:
     template <typename Sender, typename Receiver>
-    static auto make_new_sender(Sender&& sender, Receiver&& receiver) noexcept(true) -> decltype(auto) {
+    static auto make_new_sender(Sender&& sender, Receiver&& receiver)
+        //-dk:TODO this noexcept needs to get confirmed/fixed
+        noexcept(true) -> decltype(auto) {
         return ::beman::execution26::transform_sender(
             decltype(::beman::execution26::detail::get_domain_late(::std::forward<Sender>(sender),
                                                                    ::beman::execution26::get_env(receiver))){},
diff --git a/include/beman/execution26/detail/on.hpp b/include/beman/execution26/detail/on.hpp
index 1290efc0..4a7eb772 100644
--- a/include/beman/execution26/detail/on.hpp
+++ b/include/beman/execution26/detail/on.hpp
@@ -19,15 +19,17 @@
 #include <beman/execution26/detail/forward_like.hpp>
 #include <beman/execution26/detail/fwd_env.hpp>
 #include <beman/execution26/detail/sched_env.hpp>
+#include <beman/execution26/detail/starts_on.hpp>
+#include <beman/execution26/detail/continues_on.hpp>
+#include <beman/execution26/detail/write_env.hpp>
 #include <utility>
 
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
-struct on_t {
+struct on_t : ::beman::execution26::sender_adaptor_closure<on_t> {
     template <::beman::execution26::detail::sender_for<on_t> OutSndr, typename Env>
     auto transform_env(OutSndr&& out_sndr, Env&& env) const -> decltype(auto) {
-        // auto&&[_, data, _] = out_sndr;
         auto&& data{out_sndr.template get<1>()};
 
         if constexpr (::beman::execution26::scheduler<decltype(data)>)
@@ -40,6 +42,56 @@ struct on_t {
             return std::forward<Env>(env);
     }
 
+    template <typename>
+    struct env_needs_get_scheduler {
+        using sender_concept = ::beman::execution26::sender_t;
+        template <typename Env>
+        auto get_completion_signatures(Env&&) const {
+            return env_needs_get_scheduler<Env>{};
+        }
+    };
+
+    template <::beman::execution26::detail::sender_for<on_t> OutSndr, typename Env>
+    auto transform_sender(OutSndr&& out_sndr, Env&& env) const -> decltype(auto) {
+        struct not_a_scheduler {};
+        auto&& [_, data, child] = out_sndr;
+
+        if constexpr (::beman::execution26::scheduler<decltype(data)>) {
+            auto sch{::beman::execution26::detail::query_with_default(
+                ::beman::execution26::get_scheduler, env, not_a_scheduler{})};
+            if constexpr (::std::same_as<not_a_scheduler, decltype(sch)>) {
+                return env_needs_get_scheduler<Env>{};
+            } else {
+                return ::beman::execution26::continues_on(
+                    ::beman::execution26::starts_on(::beman::execution26::detail::forward_like<OutSndr>(data),
+                                                    ::beman::execution26::detail::forward_like<OutSndr>(child)),
+                    ::std::move(sch));
+            }
+        } else {
+            auto& [sch, closure] = data;
+            auto orig_sch{::beman::execution26::detail::query_with_default(
+                ::beman::execution26::get_completion_scheduler<::beman::execution26::set_value_t>,
+                ::beman::execution26::get_env(child),
+                ::beman::execution26::detail::query_with_default(
+                    ::beman::execution26::get_scheduler, env, not_a_scheduler{}))};
+
+            if constexpr (::std::same_as<not_a_scheduler, decltype(orig_sch)>) {
+                return env_needs_get_scheduler<Env>{};
+            } else {
+                return ::beman::execution26::detail::write_env(
+                    ::beman::execution26::continues_on(
+                        ::beman::execution26::detail::forward_like<OutSndr>(closure)(
+                            ::beman::execution26::continues_on(
+                                ::beman::execution26::detail::write_env(
+                                    ::beman::execution26::detail::forward_like<OutSndr>(child),
+                                    ::beman::execution26::detail::sched_env(orig_sch)),
+                                sch)),
+                        orig_sch),
+                    ::beman::execution26::detail::sched_env(env));
+            }
+        }
+    }
+
     template <::beman::execution26::scheduler Sch, ::beman::execution26::sender Sndr>
         requires ::beman::execution26::detail::is_sender_adaptor_closure<Sndr>
     auto operator()(Sch&&, Sndr&&) const -> void =
@@ -72,7 +124,35 @@ struct on_t {
                 ::beman::execution26::detail::product_type{::std::forward<Sch>(sch), ::std::forward<Closure>(closure)},
                 ::std::forward<Sndr>(sndr)));
     }
+    template <::beman::execution26::scheduler Sch, ::beman::execution26::detail::is_sender_adaptor_closure Closure>
+    auto operator()(Sch&& sch, Closure&& closure) const {
+        return ::beman::execution26::detail::sender_adaptor{
+            *this, ::std::forward<Sch>(sch), ::std::forward<Closure>(closure)};
+    }
+};
+
+#if 0
+template <typename Data, typename Sender, typename Env>
+struct completion_signatures_for_impl<
+    ::beman::execution26::detail::basic_sender<::beman::execution26::detail::on_t, Data, Sender>,
+    Env> {
+        //-dk:TODO pick up scheduler errors and merge them in?
+    using type =
+#if 0
+    ::beman::execution26::detail::meta::combine<
+        ::beman::execution26::completion_signatures_of_t<Sender, Env>,
+        ::beman::execution26::completion_signatures<::beman::execution26::set_error_t(::std::exception_ptr)>
+        >
+#else
+        ::beman::execution26::completion_signatures<
+            ::beman::execution26::set_value_t(),
+            ::beman::execution26::set_error_t(::std::exception_ptr)
+            >
+#endif
+        ;
 };
+#endif
+
 } // namespace beman::execution26::detail
 
 namespace beman::execution26 {
diff --git a/include/beman/execution26/detail/product_type.hpp b/include/beman/execution26/detail/product_type.hpp
index c0b218b6..fdfaec3b 100644
--- a/include/beman/execution26/detail/product_type.hpp
+++ b/include/beman/execution26/detail/product_type.hpp
@@ -24,7 +24,7 @@ template <::std::size_t... I, typename... T>
 struct product_type_base<::std::index_sequence<I...>, T...>
     : ::beman::execution26::detail::product_type_element<I, T>... {
     static constexpr ::std::size_t size() { return sizeof...(T); }
-    static constexpr bool is_product_type{true};
+    static constexpr bool          is_product_type{true};
 
     template <::std::size_t J, typename S>
     static auto element_get(::beman::execution26::detail::product_type_element<J, S>& self) noexcept -> S& {
@@ -67,8 +67,7 @@ struct product_type_base<::std::index_sequence<I...>, T...>
 };
 
 template <typename T>
-concept is_product_type_c = requires(T const& t){ T::is_product_type; };
-
+concept is_product_type_c = requires(const T& t) { T::is_product_type; };
 
 template <typename... T>
 struct product_type : ::beman::execution26::detail::product_type_base<::std::index_sequence_for<T...>, T...> {
@@ -115,15 +114,13 @@ constexpr auto is_product_type(const ::beman::execution26::detail::product_type<
 
 namespace std {
 template <typename T>
-     requires ::beman::execution26::detail::is_product_type_c<T>
-struct tuple_size<T>
-    : ::std::integral_constant<std::size_t, T::size()> {};
+    requires ::beman::execution26::detail::is_product_type_c<T>
+struct tuple_size<T> : ::std::integral_constant<std::size_t, T::size()> {};
 
 template <::std::size_t I, typename T>
-     requires ::beman::execution26::detail::is_product_type_c<T>
+    requires ::beman::execution26::detail::is_product_type_c<T>
 struct tuple_element<I, T> {
-    using type =
-        ::std::decay_t<decltype(::std::declval<T>().template get<I>())>;
+    using type = ::std::decay_t<decltype(::std::declval<T>().template get<I>())>;
 };
 } // namespace std
 
diff --git a/include/beman/execution26/detail/schedule_from.hpp b/include/beman/execution26/detail/schedule_from.hpp
index b0ac6e20..9894e830 100644
--- a/include/beman/execution26/detail/schedule_from.hpp
+++ b/include/beman/execution26/detail/schedule_from.hpp
@@ -5,11 +5,13 @@
 #define INCLUDED_BEMAN_EXECUTION26_DETAIL_SCHEDULE_FROM
 
 #include <beman/execution26/detail/child_type.hpp>
+#include <beman/execution26/detail/meta_combine.hpp>
 #include <beman/execution26/detail/completion_signatures_of_t.hpp>
 #include <beman/execution26/detail/connect.hpp>
 #include <beman/execution26/detail/decayed_tuple.hpp>
 #include <beman/execution26/detail/default_domain.hpp>
 #include <beman/execution26/detail/default_impls.hpp>
+#include <beman/execution26/detail/error_types_of_t.hpp>
 #include <beman/execution26/detail/env_of_t.hpp>
 #include <beman/execution26/detail/fwd_env.hpp>
 #include <beman/execution26/detail/get_domain.hpp>
@@ -144,10 +146,15 @@ struct impls_for<::beman::execution26::detail::schedule_from_t> : ::beman::execu
                 ::std::monostate,
                 ::beman::execution26::detail::meta::transform<
                     ::beman::execution26::detail::as_tuple_t,
-                    ::beman::execution26::detail::meta::to<::std::variant,
-                                                           ::beman::execution26::completion_signatures_of_t<
-                                                               ::beman::execution26::detail::child_type<Sender>,
-                                                               ::beman::execution26::env_of_t<Receiver>>>>>>;
+                    ::beman::execution26::detail::meta::to<
+                        ::std::variant,
+                        ::beman::execution26::detail::meta::combine<
+                            ::beman::execution26::completion_signatures_of_t<
+                                ::beman::execution26::detail::child_type<Sender>,
+                                ::beman::execution26::env_of_t<Receiver>>,
+                            //-dk:TODO get proper error completion signatures
+                            ::beman::execution26::completion_signatures<::beman::execution26::set_error_t(
+                                ::std::exception_ptr)>>>>>>;
 
             return state_type<Receiver, sched_t, variant_t>(sch, receiver);
         }};
@@ -176,8 +183,15 @@ template <typename Scheduler, typename Sender, typename Env>
 struct completion_signatures_for_impl<
     ::beman::execution26::detail::basic_sender<::beman::execution26::detail::schedule_from_t, Scheduler, Sender>,
     Env> {
-    using type =
-        decltype(::beman::execution26::get_completion_signatures(::std::declval<Sender>(), ::std::declval<Env>()));
+    using scheduler_sender = decltype(::beman::execution26::schedule(::std::declval<Scheduler>()));
+    template <typename... E>
+    using as_set_error = ::beman::execution26::completion_signatures<::beman::execution26::set_error_t(E)...>;
+    using type         = ::beman::execution26::detail::meta::combine<
+                decltype(::beman::execution26::get_completion_signatures(::std::declval<Sender>(), ::std::declval<Env>())),
+                ::beman::execution26::error_types_of_t<scheduler_sender, Env, as_set_error>,
+                ::beman::execution26::completion_signatures<::beman::execution26::set_error_t(
+            ::std::exception_ptr)> //-dk:TODO this one should be deduced
+                >;
 };
 } // namespace beman::execution26::detail
 
diff --git a/include/beman/execution26/detail/transform_sender.hpp b/include/beman/execution26/detail/transform_sender.hpp
index 376a3b6b..def72c09 100644
--- a/include/beman/execution26/detail/transform_sender.hpp
+++ b/include/beman/execution26/detail/transform_sender.hpp
@@ -16,9 +16,9 @@ template <typename Domain, ::beman::execution26::sender Sender, typename... Env>
             requires(Domain dom, Sender&& sender, const Env&... env) {
                 dom.transform_sender(::std::forward<Sender>(sender), env...);
             } &&
-            (::std::same_as<
-                ::std::remove_cvref_t<Sender>,
-                std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(::std::declval<Sender>()))>>)
+            (::std::same_as<::std::remove_cvref_t<Sender>,
+                            std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(
+                                ::std::declval<Sender>(), ::std::declval<const Env&>()...))>>)
 constexpr auto transform_sender(Domain, Sender&& sender, const Env&...) noexcept -> ::beman::execution26::sender auto {
     return ::std::forward<Sender>(sender);
 }
@@ -28,9 +28,9 @@ template <typename Domain, ::beman::execution26::sender Sender, typename... Env>
             requires(Domain dom, Sender&& sender, const Env&... env) {
                 dom.transform_sender(::std::forward<Sender>(sender), env...);
             } &&
-            (not::std::same_as<
-                ::std::remove_cvref_t<Sender>,
-                std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(::std::declval<Sender>()))>>)
+            (not::std::same_as<::std::remove_cvref_t<Sender>,
+                               std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(
+                                   ::std::declval<Sender>(), ::std::declval<const Env&>()...))>>)
 constexpr auto transform_sender(Domain dom, Sender&& sender, const Env&... env) noexcept
     -> ::beman::execution26::sender decltype(auto) {
     return ::beman::execution26::detail::transform_sender(
@@ -60,7 +60,6 @@ template <typename Domain, ::beman::execution26::sender Sender, typename... Env>
 constexpr auto transform_sender(Domain dom, Sender&& sender, const Env&... env) noexcept(noexcept(
     ::beman::execution26::default_domain{}.transform_sender(::std::declval<Sender>(), ::std::declval<Env>()...)))
     -> ::beman::execution26::sender decltype(auto) {
-    (void)dom;
     return ::beman::execution26::detail::transform_sender(
         dom, ::beman::execution26::default_domain{}.transform_sender(::std::forward<Sender>(sender), env...), env...);
 }
@@ -72,9 +71,9 @@ template <typename Domain, ::beman::execution26::sender Sender, typename... Env>
             requires(Domain dom, Sender&& sender, const Env&... env) {
                 dom.transform_sender(::std::forward<Sender>(sender), env...);
             } &&
-            (::std::same_as<
-                ::std::remove_cvref_t<Sender>,
-                std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(::std::declval<Sender>()))>>)
+            (::std::same_as<::std::remove_cvref_t<Sender>,
+                            std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(
+                                ::std::declval<Sender>(), ::std::declval<const Env&>()...))>>)
 constexpr auto transform_sender(Domain, Sender&& sender, const Env&...) noexcept -> ::beman::execution26::sender
     decltype(auto) {
     return ::std::forward<Sender>(sender);
@@ -85,9 +84,9 @@ template <typename Domain, ::beman::execution26::sender Sender, typename... Env>
             requires(Domain dom, Sender&& sender, const Env&... env) {
                 dom.transform_sender(::std::forward<Sender>(sender), env...);
             } &&
-            (not::std::same_as<
-                ::std::remove_cvref_t<Sender>,
-                std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(::std::declval<Sender>()))>>)
+            (not::std::same_as<::std::remove_cvref_t<Sender>,
+                               std::remove_cvref_t<decltype(::std::declval<Domain>().transform_sender(
+                                   ::std::declval<Sender>(), ::std::declval<const Env&>()...))>>)
 constexpr auto transform_sender(Domain dom, Sender&& sender, const Env&... env) noexcept
     -> ::beman::execution26::sender auto {
     return ::beman::execution26::detail::transform_sender(
diff --git a/include/beman/execution26/execution.hpp b/include/beman/execution26/execution.hpp
index 7d88ffa9..78cfd62e 100644
--- a/include/beman/execution26/execution.hpp
+++ b/include/beman/execution26/execution.hpp
@@ -42,7 +42,7 @@
 #include <beman/execution26/detail/into_variant.hpp>
 #include <beman/execution26/detail/just.hpp>
 #include <beman/execution26/detail/let.hpp>
-// #include <beman/execution26/detail/on.hpp>
+#include <beman/execution26/detail/on.hpp>
 #include <beman/execution26/detail/read_env.hpp>
 #include <beman/execution26/detail/schedule_from.hpp>
 #include <beman/execution26/detail/starts_on.hpp>
diff --git a/tests/beman/execution26/exec-on.test.cpp b/tests/beman/execution26/exec-on.test.cpp
index cfd8a995..bdc02a87 100644
--- a/tests/beman/execution26/exec-on.test.cpp
+++ b/tests/beman/execution26/exec-on.test.cpp
@@ -5,6 +5,8 @@
 #include <beman/execution26/detail/just.hpp>
 #include <beman/execution26/detail/sender_adaptor_closure.hpp>
 #include <beman/execution26/detail/then.hpp>
+#include <beman/execution26/detail/sync_wait.hpp>
+#include <beman/execution26/detail/get_completion_signatures.hpp>
 #include <test/execution.hpp>
 #include <test/thread_pool.hpp>
 #include <concepts>
@@ -42,6 +44,24 @@ template <test_detail::sender_for<test_std::on_t> OutSndr>
 auto test_transform_env(OutSndr out_sndr) -> void {
     auto e{test_std::on.transform_env(out_sndr, test_std::empty_env{})};
 }
+
+template <test_detail::sender_for<test_std::on_t> OutSndr>
+auto test_transform_sender(OutSndr out_sndr) -> void {
+    auto s{test_std::on.transform_sender(std::move(out_sndr), test_std::empty_env{})};
+    static_assert(test_std::sender<decltype(s)>);
+    auto ts{std::move(s) | test_std::then([](auto&&...) {})};
+    static_assert(test_std::sender<decltype(ts)>);
+}
+
+struct on_receiver {
+    using receiver_concept = test_std::receiver_t;
+    test::thread_pool& pool;
+    auto               set_value(auto&&...) && noexcept {}
+    auto               set_error(auto&&) && noexcept {}
+    auto               set_stopped() && noexcept {}
+    auto get_env() const noexcept { return test_detail::make_env(test_std::get_scheduler, pool.get_scheduler()); }
+};
+static_assert(test_std::receiver<on_receiver>);
 } // namespace
 
 TEST(exec_on) {
@@ -52,6 +72,60 @@ TEST(exec_on) {
     static_assert(not test_detail::is_sender_adaptor_closure<decltype(test_std::just([] {}))>);
     test_interface(pool.get_scheduler(), test_std::just(), test_std::then([] {}), both{});
 
-    test_transform_env(test_std::on(pool.get_scheduler(), test_std::just()));
-    test_transform_env(test_std::on(test_std::just(), pool.get_scheduler(), test_std::then([] {})));
+    test_transform_env(test_detail::make_sender(test_std::on, pool.get_scheduler(), test_std::just()));
+    test_transform_env(test_detail::make_sender(
+        test_std::on,
+        ::beman::execution26::detail::product_type{pool.get_scheduler(), test_std::then([] {})},
+        test_std::just()));
+
+    test_transform_sender(test_detail::make_sender(test_std::on, pool.get_scheduler(), test_std::just()));
+    test_transform_sender(test_detail::make_sender(
+        test_std::on,
+        ::beman::execution26::detail::product_type{pool.get_scheduler(), test_std::then([] {})},
+        test_std::just()));
+
+    std::thread::id on_id{};
+    std::thread::id pool_id{};
+    std::thread::id cont_id{};
+
+    test_std::sync_wait(test_std::starts_on(pool.get_scheduler(), test_std::just() | test_std::then([&pool_id] {
+                                                                      pool_id = std::this_thread::get_id();
+                                                                  })));
+    test_std::sync_wait(test_std::on(pool.get_scheduler(), test_std::just() | test_std::then([&on_id] {
+                                                               on_id = std::this_thread::get_id();
+                                                               return 42;
+                                                           })) |
+                        test_std::then([&cont_id](int val) {
+                            assert(val == 42);
+                            cont_id = std::this_thread::get_id();
+                        }));
+    assert(on_id == pool_id);
+    assert(cont_id == std::this_thread::get_id());
+    assert(on_id != std::this_thread::get_id());
+
+    test_std::sync_wait(test_std::on(test_std::just(17), pool.get_scheduler(), test_std::then([&on_id](int val) {
+                                         assert(val == 17);
+                                         on_id = std::this_thread::get_id();
+                                         return 42;
+                                     })) |
+                        test_std::then([&cont_id](int val) {
+                            assert(val == 42);
+                            cont_id = std::this_thread::get_id();
+                        }));
+    assert(on_id == pool_id);
+    assert(cont_id == std::this_thread::get_id());
+    assert(on_id != std::this_thread::get_id());
+
+    test_std::sync_wait(test_std::just(17) | test_std::on(pool.get_scheduler(), test_std::then([&on_id](int val) {
+                                                              assert(val == 17);
+                                                              on_id = std::this_thread::get_id();
+                                                              return 42;
+                                                          })) |
+                        test_std::then([&cont_id](int val) {
+                            assert(val == 42);
+                            cont_id = std::this_thread::get_id();
+                        }));
+    assert(on_id == pool_id);
+    assert(cont_id == std::this_thread::get_id());
+    assert(on_id != std::this_thread::get_id());
 }
\ No newline at end of file
diff --git a/tests/beman/execution26/exec-snd-expos.test.cpp b/tests/beman/execution26/exec-snd-expos.test.cpp
index 42015083..1dcfcc28 100644
--- a/tests/beman/execution26/exec-snd-expos.test.cpp
+++ b/tests/beman/execution26/exec-snd-expos.test.cpp
@@ -865,16 +865,16 @@ auto test_product_type() -> void {
     static_assert(std::same_as<int, std::tuple_element<0u, decltype(prod)>::type>);
     static_assert(std::same_as<bool, std::tuple_element<1u, decltype(prod)>::type>);
     static_assert(std::same_as<char, std::tuple_element<2u, decltype(prod)>::type>);
-    auto&&[i, b, c] = prod;
+    auto&& [i, b, c] = prod;
     test::use(i, b, c);
 
-    struct derived: decltype(prod) {};
+    struct derived : decltype(prod) {};
     static_assert(3u == std::tuple_size<derived>::value);
     static_assert(std::same_as<int, std::tuple_element<0u, derived>::type>);
     static_assert(std::same_as<bool, std::tuple_element<1u, derived>::type>);
     static_assert(std::same_as<char, std::tuple_element<2u, derived>::type>);
     derived d{1, true, 'c'};
-    auto&&[di, db, dc] = d;
+    auto&& [di, db, dc] = d;
     assert(di == d.get<0>());
     assert(db == d.get<1>());
     assert(dc == d.get<2>());
diff --git a/tests/beman/execution26/include/test/thread_pool.hpp b/tests/beman/execution26/include/test/thread_pool.hpp
index 4758795e..5313c128 100644
--- a/tests/beman/execution26/include/test/thread_pool.hpp
+++ b/tests/beman/execution26/include/test/thread_pool.hpp
@@ -20,10 +20,16 @@ struct thread_pool;
 
 struct test::thread_pool {
     struct node {
-        node*        next;
+        node*        next{};
         virtual void run() = 0;
 
+        node(const node&)            = delete;
+        node(node&&)                 = delete;
+        node& operator=(const node&) = delete;
+        node& operator=(node&&)      = delete;
+
       protected:
+        node()  = default;
         ~node() = default;
     };
 
@@ -42,13 +48,16 @@ struct test::thread_pool {
         }
     }};
 
-    thread_pool()              = default;
-    thread_pool(thread_pool&&) = delete;
+    thread_pool()                   = default;
+    thread_pool(thread_pool&&)      = delete;
+    thread_pool(const thread_pool&) = delete;
     ~thread_pool() {
         this->stop();
         this->driver.join();
     }
-    void stop() {
+    thread_pool& operator=(thread_pool&&)      = delete;
+    thread_pool& operator=(const thread_pool&) = delete;
+    void         stop() {
         {
             std::lock_guard cerberus(this->mutex);
             stopped = true;

From 326eb725a9af9e38a402df8041a7b666b3805422 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dietmar=20K=C3=BChl?= <dietmar.kuehl@me.com>
Date: Sat, 4 Jan 2025 14:52:16 +0000
Subject: [PATCH 4/5] fix a silly formatting error

---
 tests/beman/execution26/exec-on.test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/beman/execution26/exec-on.test.cpp b/tests/beman/execution26/exec-on.test.cpp
index bdc02a87..740575fe 100644
--- a/tests/beman/execution26/exec-on.test.cpp
+++ b/tests/beman/execution26/exec-on.test.cpp
@@ -128,4 +128,4 @@ TEST(exec_on) {
     assert(on_id == pool_id);
     assert(cont_id == std::this_thread::get_id());
     assert(on_id != std::this_thread::get_id());
-}
\ No newline at end of file
+}

From 8796a521714548eabf8100e0a7f96e33b86205fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dietmar=20K=C3=BChl?= <dietmar.kuehl@me.com>
Date: Sat, 4 Jan 2025 15:01:32 +0000
Subject: [PATCH 5/5] fixed a few warnings

---
 include/beman/execution26/detail/on.hpp  | 4 ++++
 tests/beman/execution26/exec-on.test.cpp | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/include/beman/execution26/detail/on.hpp b/include/beman/execution26/detail/on.hpp
index 4a7eb772..10d4a443 100644
--- a/include/beman/execution26/detail/on.hpp
+++ b/include/beman/execution26/detail/on.hpp
@@ -24,6 +24,8 @@
 #include <beman/execution26/detail/write_env.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
@@ -162,4 +164,6 @@ inline constexpr ::beman::execution26::on_t on{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/tests/beman/execution26/exec-on.test.cpp b/tests/beman/execution26/exec-on.test.cpp
index 740575fe..be930dc9 100644
--- a/tests/beman/execution26/exec-on.test.cpp
+++ b/tests/beman/execution26/exec-on.test.cpp
@@ -11,6 +11,8 @@
 #include <test/thread_pool.hpp>
 #include <concepts>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace {
@@ -43,6 +45,7 @@ auto test_interface(Sch sch, Sndr sndr, Closure closure, Both both) -> void {
 template <test_detail::sender_for<test_std::on_t> OutSndr>
 auto test_transform_env(OutSndr out_sndr) -> void {
     auto e{test_std::on.transform_env(out_sndr, test_std::empty_env{})};
+    test::use(e);
 }
 
 template <test_detail::sender_for<test_std::on_t> OutSndr>