From 07a96dd3e798d244a0b3438506a29576942d255c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Sat, 26 Apr 2025 19:20:47 -0600 Subject: [PATCH 1/4] added some tidy errors --- Makefile | 6 ++++-- include/beman/execution/detail/sched_attrs.hpp | 3 ++- src/beman/execution/CMakeLists.txt | 2 ++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 7a7add57..220880b4 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,8 @@ CXX_FLAGS ?= -g SANITIZER ?= default SOURCEDIR = $(CURDIR) BUILDROOT = build -BUILD = $(BUILDROOT)/$(SANITIZER) +SYSTEM = $(shell uname -s) +BUILD = $(BUILDROOT)/$(SYSTEM)/$(SANITIZER) EXAMPLE = beman.execution.examples.stop_token CMAKE_CXX_COMPILER=$(COMPILER) @@ -113,6 +114,7 @@ check: done | tsort > /dev/null build/$(SANITIZER)/compile_commands.json: $(SANITIZER) + clang-tidy: $(BUILD)/compile_commands.json run-clang-tidy -p $(BUILD) tests examples @@ -138,7 +140,7 @@ clean-doc: $(RM) -r docs/html docs/latex clean: clean-doc - $(RM) -r $(BUILD) + cmake --build $(BUILD) --target clean $(RM) mkerr olderr *~ distclean: clean diff --git a/include/beman/execution/detail/sched_attrs.hpp b/include/beman/execution/detail/sched_attrs.hpp index 67eb6501..3fe9184e 100644 --- a/include/beman/execution/detail/sched_attrs.hpp +++ b/include/beman/execution/detail/sched_attrs.hpp @@ -24,7 +24,8 @@ class sched_attrs { public: template - explicit sched_attrs(S s) : sched(::std::move(s)) {} + requires (not ::std::same_as>) + explicit sched_attrs(S&& s) : sched(::std::forward(s)) {} template auto query(const ::beman::execution::get_completion_scheduler_t&) const noexcept { diff --git a/src/beman/execution/CMakeLists.txt b/src/beman/execution/CMakeLists.txt index ea6aecae..37cae3a5 100644 --- a/src/beman/execution/CMakeLists.txt +++ b/src/beman/execution/CMakeLists.txt @@ -6,10 +6,12 @@ add_library(${TARGET_NAME} STATIC) add_library(${TARGET_ALIAS} ALIAS ${TARGET_NAME}) +if(FALSE) if(NOT BEMAN_EXECUTION_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES) target_link_libraries(${TARGET_NAME} PUBLIC $) target_link_libraries(${TARGET_NAME} PUBLIC $) endif() +endif() include(CMakePrintHelpers) cmake_print_variables(TARGET_ALIAS TARGET_NAME TARGET_PREFIX PROJECT_SOURCE_DIR) From 4117735e642eab997444c5fea32e749989556dc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Sat, 26 Apr 2025 19:34:26 -0600 Subject: [PATCH 2/4] restored src/beman/execution/CMakeLists.txt --- src/beman/execution/CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/beman/execution/CMakeLists.txt b/src/beman/execution/CMakeLists.txt index 37cae3a5..ea6aecae 100644 --- a/src/beman/execution/CMakeLists.txt +++ b/src/beman/execution/CMakeLists.txt @@ -6,12 +6,10 @@ add_library(${TARGET_NAME} STATIC) add_library(${TARGET_ALIAS} ALIAS ${TARGET_NAME}) -if(FALSE) if(NOT BEMAN_EXECUTION_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES) target_link_libraries(${TARGET_NAME} PUBLIC $) target_link_libraries(${TARGET_NAME} PUBLIC $) endif() -endif() include(CMakePrintHelpers) cmake_print_variables(TARGET_ALIAS TARGET_NAME TARGET_PREFIX PROJECT_SOURCE_DIR) From 041d47ec9ec957e8970e92d17dacb5bdb67d8ccc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Tue, 29 Apr 2025 10:18:08 -0600 Subject: [PATCH 3/4] fix a formatting issue --- include/beman/execution/detail/sched_attrs.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/beman/execution/detail/sched_attrs.hpp b/include/beman/execution/detail/sched_attrs.hpp index 3fe9184e..a221f1ca 100644 --- a/include/beman/execution/detail/sched_attrs.hpp +++ b/include/beman/execution/detail/sched_attrs.hpp @@ -24,7 +24,7 @@ class sched_attrs { public: template - requires (not ::std::same_as>) + requires(not ::std::same_as>) explicit sched_attrs(S&& s) : sched(::std::forward(s)) {} template From b443a25d919d0145f6c360ef7b8c49f082f87f60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dietmar=20K=C3=BChl?= Date: Tue, 29 Apr 2025 10:20:29 -0600 Subject: [PATCH 4/4] changed not by ! to avoid a formatting issue --- include/beman/execution/detail/sched_attrs.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/beman/execution/detail/sched_attrs.hpp b/include/beman/execution/detail/sched_attrs.hpp index a221f1ca..5d8e8372 100644 --- a/include/beman/execution/detail/sched_attrs.hpp +++ b/include/beman/execution/detail/sched_attrs.hpp @@ -24,7 +24,7 @@ class sched_attrs { public: template - requires(not ::std::same_as>) + requires(!::std::same_as>) explicit sched_attrs(S&& s) : sched(::std::forward(s)) {} template