Update VRCGuid, attempt to login all clients, update sample code.

Author: binn

VRChat.API.Client/VRCGuid.cs

@@ -71,6 +71,9 @@ public static VRCGuid NewGuid(VRCKind kind = VRCKind.File) =>
         /// <returns>A <see cref="bool"/> value representing the success of the operation</returns>
         public static bool TryParse(string incoming, out VRCGuid vrcid)
         {
+            if(incoming == null)
+                throw new ArgumentNullException(nameof(incoming));
+
             vrcid = VRCGuid.Empty;
             string[] parts = incoming.Split('_');
 

VRChat.API.Extensions.Hosting/DefaultVRChatClientFactory.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Threading.Tasks;
 using VRChat.API.Client;
 
 namespace VRChat.API.Extensions.Hosting
@@ -15,6 +16,16 @@ public DefaultVRChatClientFactory() =>
 
         internal bool IsDefaultRegistered => _builders.ContainsKey("vrc_default"); // Not sure where I was going with this, but I'll keep it in here for now
 
+        public async Task AttemptLoginForAllClients()
+        {
+            foreach(var client in _builders.Keys)
+                await this.LoginClientAsync(client);
+        }
+
+        public Task LoginClientAsync(string name = "vrc_default") =>
+            this.CreateClient(name).TryLoginAsync(); // There may be a fatal flaw and we should probably start storing actual IVRChat instances to 
+        // prevent logins and authtokens from being cleared out by the GC or if it's even being stored in the first place. Only one real way to find out.
+
         public IVRChat CreateClient() // Maybe we should throw an exception if the default was not registered? 
             // It'll ensure that users of the library don't end up accidentally using a client that isn't registered (inconsistent library design)
         {

VRChat.API.Extensions.Hosting/IVRChatClientFactory.cs

@@ -1,10 +1,14 @@
-using VRChat.API.Client;
+using System.Threading.Tasks;
+using VRChat.API.Client;
 
 namespace VRChat.API.Extensions.Hosting
 {
     public interface IVRChatClientFactory
     {
         IVRChat CreateClient();
         IVRChat CreateClient(string name);
+
+        Task AttemptLoginForAllClients();
+        Task LoginClientAsync(string name = "vrc_default");
     }
 }

VRChat.API.Extensions.Hosting/VRChatServiceCollectionExtensions.cs

@@ -69,7 +69,7 @@ public static IServiceCollection AddVRChat(this IServiceCollection services, str
                 TryFillVRChatFromEnv(ref vcb); // If they don't specify a config action, we'll just use env vars to try and set it up
 
             services.TryAddSingleton<DefaultVRChatClientFactory>();
-            services.TryAddSingleton<IVRChatClientFactory>(srv =>
+            services.AddSingleton<IVRChatClientFactory>(srv => // Had to change to AddSingleton to make it call multiple times
             {
                 IVRChat client = vcb.Build();
                 var factory = srv.GetRequiredService<DefaultVRChatClientFactory>();

VRChat.API.UnitSample.AspNetCore/Controllers/SampleController.cs

@@ -17,7 +17,7 @@ public SampleController(ILogger<SampleController> logger, IVRChat vrchat)
             _logger = logger;
         }
 
-        [HttpGet("/{id}")]
+        [HttpGet("/{userId}")]
         public async Task<IActionResult> GetCurrentUserAsync(string userId)
         {
             if (!VRCGuid.TryParse(userId, out VRCGuid id))

VRChat.API.UnitSample.AspNetCore/Properties/launchSettings.json

@@ -5,7 +5,7 @@
       "commandName": "Project",
       "dotnetRunMessages": "true",
       "launchBrowser": true,
-      "launchUrl": "",
+      "launchUrl": "usr_c1644b5b-3ca4-45b4-97c6-a2a0de70d469",
       "applicationUrl": "http://localhost:5000",
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"

VRChat.API.UnitSample.AspNetCore/Startup.cs

@@ -3,6 +3,7 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
+using Microsoft.VisualBasic;
 using VRChat.API.Extensions.Hosting;
 
 namespace VRChat.API.UnitSample.AspNetCore
@@ -24,7 +25,7 @@ public void ConfigureServices(IServiceCollection services)
         }
 
         // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
-        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
+        public void Configure(IApplicationBuilder app, IWebHostEnvironment env, IVRChatClientFactory factory)
         {
             if (env.IsDevelopment())
                 app.UseDeveloperExceptionPage();
@@ -36,6 +37,8 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
             {
                 endpoints.MapControllers();
             });
+
+            factory.AttemptLoginForAllClients().Wait(); // This will try to login all the VRChat clients
         }
     }
 }

VRChat.API.UnitSample/Program.cs

@@ -14,7 +14,6 @@ public static async Task Main(string[] args)
             var client = new VRChatClientBuilder()
                 .WithUsername(username)
                 .WithPassword(password)
-                .WithTimeout(TimeSpan.FromSeconds(10))
                 .Build();
 
             var user = await client.Authentication.GetCurrentUserAsync();