From 66f6b8c4b18146419094a90a26dd86c435c9147a Mon Sep 17 00:00:00 2001 From: Yu Guo <82124926+yuguo68@users.noreply.github.com> Date: Thu, 13 Nov 2025 06:49:36 +0000 Subject: [PATCH 1/2] fix switch error --- csrc/kernels.cu | 2 ++ csrc/kernels.hip | 2 ++ 2 files changed, 4 insertions(+) diff --git a/csrc/kernels.cu b/csrc/kernels.cu index ff122d376..7d9f30add 100644 --- a/csrc/kernels.cu +++ b/csrc/kernels.cu @@ -557,6 +557,8 @@ __launch_bounds__(BLOCK_SIZE / NUM_VALS, 1) __global__ void kPreconditionOptimiz s1_vals[j] = s1_vals[j] / (sqrtf(s2_vals[j]) + eps); // update s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update) break; + case ADEMAMIX: + break; } } diff --git a/csrc/kernels.hip b/csrc/kernels.hip index 5959bd055..923a1eba1 100644 --- a/csrc/kernels.hip +++ b/csrc/kernels.hip @@ -594,6 +594,8 @@ __global__ void kPreconditionOptimizer32bit2State(T* g, T* p, s1_vals[j] = s1_vals[j]/(sqrtf(s2_vals[j])+eps); // update s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update) break; + case ADEMAMIX: + break; } } From 77cc99f62b785783fa59478874c18c62f5ab6749 Mon Sep 17 00:00:00 2001 From: Matthew Douglas <38992547+matthewdouglas@users.noreply.github.com> Date: Thu, 13 Nov 2025 10:23:08 -0500 Subject: [PATCH 2/2] Apply suggestion from @matthewdouglas --- csrc/kernels.cu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csrc/kernels.cu b/csrc/kernels.cu index 7d9f30add..f36f4a7e7 100644 --- a/csrc/kernels.cu +++ b/csrc/kernels.cu @@ -558,7 +558,7 @@ __launch_bounds__(BLOCK_SIZE / NUM_VALS, 1) __global__ void kPreconditionOptimiz s1_vals[j] *= s1_vals[j]; // update l2 norm (update*update) break; case ADEMAMIX: - break; + break; } }