fix(TS): Added some better error handling and removed an accidental default value for a field.

Author: bamandel

tasks/synopsys-detect-task/task.json

@@ -1,7 +1,7 @@
 {
   "id": "5e9b6b5e-3130-47dc-89c5-77a58949f2cf",
   "name": "SynopsysDetectTask",
-  "friendlyName": "Synopsys Detect QA",
+  "friendlyName": "Synopsys Detect Dev",
   "description": "Execute Synopsys Detect against your build",
   "author": "Synopsys",
   "category": "Utility",
@@ -13,7 +13,7 @@
   "version": {
     "Major": 7,
     "Minor": 0,
-    "Patch": 3
+    "Patch": 24
   },
   "minimumAgentVersion": "1.95.0",
   "instanceNameFormat": "Run Synopsys Detect for your build $(message)",
@@ -81,7 +81,7 @@
     {
       "name": "DetectAirGapJarDirectoryPath",
       "type": "string",
-      "defaultValue": "Agent.ToolsDirectory",
+      "defaultValue": "",
       "label": "Detect Air Gap Jar Directory Path",
       "required": true,
       "helpMarkDown": "The extracted Detect jar directory path that will be used for Air Gap mode.",
@@ -93,4 +93,4 @@
       "target": "detect-task.js"
     }
   }
-}
+}

tasks/synopsys-detect-task/ts/runner/DetectJarConfigurationRunner.ts

@@ -19,18 +19,17 @@ export class DetectJarConfigurationRunner extends DetectRunner {
     }
 
     createRunnerConfiguration(): IDetectRunnerConfiguration {
+        logger.info('Checking jar directory.')
+        if (!fileSystem.existsSync(this.jarDirectoryPath)) {
+            throw new Error(`Directory did not exist '${this.jarDirectoryPath}'`);
+        }
+
         const firstJarFile: string = fileSystem.readdirSync(this.jarDirectoryPath)
             .find(file => DetectJarConfigurationRunner.JAR_EXTENSION === path.parse(file).ext) || ''
 
         if (!firstJarFile || !firstJarFile.startsWith(DetectJarConfigurationRunner.JAR_PREFIX)) {
             logger.warn('Should have only the detect jar in this directory.')
-            logger.error(`Was unable to find valid jar in ${this.jarDirectoryPath}.`)
-
-            return {
-                fileName: '',
-                runCommands: [],
-                runnerTool: ''
-            }
+            throw new Error(`Was unable to find valid jar in ${this.jarDirectoryPath}.`)
         } else {
             logger.info(`Found jar file '${firstJarFile}'`)
         }

tasks/synopsys-detect-task/ts/runner/DetectRunner.ts

@@ -26,13 +26,15 @@ export abstract class DetectRunner {
         logger.info('Setting up the env to run Detect...')
         const detectSetup = this.setupDetect()
         const env = detectSetup.getEnv()
+
         logger.info('Parsing detect arguments...')
         const cleanedArguments: string[] = detectSetup.convertArgumentsToPassableValues()
         const config: IDetectRunnerConfiguration = this.createRunnerConfiguration()
+
         logger.info('Determining folder where Detect is located...')
         const artifactFolder: string = await this.retrieveOrCreateArtifactFolder(config.fileName)
-        const toolRunner = new ADOToolRunner(config)
 
+        const toolRunner = new ADOToolRunner(config)
         return await toolRunner.invoke(cleanedArguments, artifactFolder, env)
     }
 }

vss-extension.json

@@ -1,8 +1,8 @@
 {
   "manifestVersion": 1,
-  "id": "synopsys-detect-qa",
-  "version": "7.0.3",
-  "name": "Synopsys Detect QA",
+  "id": "synopsys-detect-dev",
+  "version": "7.0.24",
+  "name": "Synopsys Detect Dev",
   "publisher": "synopsys-detect",
   "public": false,
   "targets": [
@@ -146,4 +146,4 @@
       }
     }
   ]
-}
+}