Skip to content

Commit 242db29

Browse files
committed
testing
1 parent c9b0081 commit 242db29

File tree

4 files changed

+22
-23
lines changed

4 files changed

+22
-23
lines changed

.github/workflows/build.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103

104104
build-wheel:
105105
name: Build and test wheel for ${{ matrix.config.name }}
106-
needs: build-dll
106+
# needs: build-dll
107107
runs-on: ${{ matrix.config.os }}
108108
strategy:
109109
fail-fast: false
@@ -129,19 +129,25 @@ jobs:
129129
- run: choco install just # no Github cargo action for windows-11-arm yet; use choco:
130130
if: matrix.config.os == 'windows-11-arm'
131131

132-
# By default, uv still uses the x86_64 python in emulation on Windows.
133-
# https://github.com/astral-sh/uv/issues/12906
134-
# Override this behavior to build an actual aarch64 wheel:
135-
- run: echo "UV_PYTHON=arm64" >> $env:GITHUB_ENV
136-
if: matrix.config.os == 'windows-11-arm'
137-
138132
- uses: astral-sh/setup-uv@v7
139133

140134
- uses: actions/checkout@v3
141135
with:
142136
# Fetch all tags
143137
fetch-depth: 0
144138

139+
# By default, uv still uses the x86_64 python in emulation on Windows.
140+
# https://github.com/astral-sh/uv/issues/12906
141+
# Override this behavior to build an actual aarch64 wheel:
142+
# temp hack remove this
143+
- run: UV_PYTHON=arm64 just build-wheel
144+
if: matrix.config.os == 'windows-11-arm'
145+
146+
# temp hack remove this too
147+
- name: Test wheel (force aarch64)
148+
if: matrix.config.os == 'windows-11-arm'
149+
run: UV_PYTHON=arm64 just test-matrix --python-platform aarch64-pc-windows-msvc
150+
145151
- uses: actions/download-artifact@v4
146152
with:
147153
name: dll-${{ matrix.config.name }}

ARCHITECTURE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,8 @@ Alpine without extensive patching (or just dispensing with the V8 build system
261261
entirely!).
262262

263263
So instead we build a on Ubuntu with glibc and then put that into a wheel on Alpine. To
264-
use the resulting wheel, you must `apk add gcompat` and add the environment variable
265-
`LD_PRELOAD="/lib/libgcompat.so.0"`.
264+
use the resulting wheel, you must `apk add gcompat libgcc` and add the environment
265+
variable `LD_PRELOAD="/lib/libgcompat.so.0"`.
266266

267267
### Build V8 _with_ our frontend (`v8_py_frontend`) as a snuck-in component
268268

Justfile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ build: build-dll build-wheel
6969
test:
7070
uv run pytest tests
7171

72-
test-matrix:
73-
uv run --python 3.10 pytest tests
74-
uv run --python 3.11 pytest tests
75-
uv run --python 3.12 pytest tests
76-
uv run --python 3.13 pytest tests
77-
uv run --python 3.14 pytest tests
72+
test-matrix *args:
73+
uv run --python 3.10 {{args}} pytest tests
74+
uv run --python 3.11 {{args}} pytest tests
75+
uv run --python 3.12 {{args}} pytest tests
76+
uv run --python 3.13 {{args}} pytest tests
77+
uv run --python 3.14 {{args}} pytest tests
7878

7979
git-config-global:
8080
git config --global core.symlinks true

builder/v8_build.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,14 +247,7 @@ def run_build(build_dir: Path, args: Args) -> None:
247247
# unsupported relocation type 1032"
248248
# when running ubuntu-built aarch64 shared objects on Alpine:
249249
# https://gitlab.alpinelinux.org/alpine/aports/-/issues/16210
250-
opts.update(
251-
{
252-
"v8_enable_partition_alloc": "false",
253-
"enable_backup_ref_ptr_support": "false",
254-
"use_allocator_shim": "false",
255-
"use_partition_alloc": "false",
256-
}
257-
)
250+
opts["v8_enable_partition_alloc"] = "false"
258251

259252
if is_linux() and target_cpu != get_local_v8_target_cpu():
260253
run(

0 commit comments

Comments
 (0)