Fix passing of strings with nulls from Py to JS (#24)

Author: bpcreech

src/v8_py_frontend/binary_value.cc

@@ -314,7 +314,10 @@ auto BinaryValueFactory::ToValue(v8::Local<v8::Context> context,
   }
 
   if (bv_ptr->type == type_str_utf8) {
-    return v8::String::NewFromUtf8(isolate, bv_ptr->bytes).ToLocalChecked();
+    return v8::String::NewFromUtf8(isolate, bv_ptr->bytes,
+                                   v8::NewStringType::kNormal,
+                                   static_cast<int>(bv_ptr->len))
+        .ToLocalChecked();
   }
 
   // Unknown type!

src/v8_py_frontend/binary_value.h

@@ -68,7 +68,6 @@ struct BinaryValue {
   union {
     char* backing_store_ptr;
     gsl::owner<char*> bytes;
-    gsl::owner<v8::Persistent<v8::Value>*> value_ptr;
     int64_t int_val;
     double double_val;
   };

tests/test_types.py

@@ -50,6 +50,7 @@ def test_str():
     v = Validator()
     v.validate("'a string'")
     v.validate("'a ' + 'string'")
+    v.validate("string with null \0 byte")
 
 
 def test_unicode():