Skip to content

Commit 0d8eec2

Browse files
authored
Merge pull request #95 from brefphp/v2-account-id
2 parents 77e5170 + b214480 commit 0d8eec2

File tree

3 files changed

+0
-13
lines changed

3 files changed

+0
-13
lines changed

README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ php artisan vendor:publish --tag=serverless-config
3030

3131
This will create the `serverless.yml` config file.
3232

33-
Next, we need to set up in the `AWS_ACCOUNT_ID` environment variable in your `serverless.yml`:
34-
35-
```yml
36-
provider:
37-
environment:
38-
AWS_ACCOUNT_ID: ${aws:accountId}
39-
```
40-
4133
Finally, deploy your app:
4234

4335
```bash

examples/getting-started/serverless.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ provider:
2323
APP_URL: ${param:appUrl}
2424
APP_ENV: ${sls:stage}
2525
APP_DEBUG: ${param:debug}
26-
AWS_ACCOUNT_ID: ${aws:accountId}
2726
ASSET_URL: https://${param:assetsBucket}/${sls:instanceId}
2827
LOG_LEVEL: ${param:logLevel}
2928
QUEUE_CONNECTION: ${param:queue, 'sqs'}

src/BrefServiceProvider.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,9 @@ public function register()
5353
Config::set('filesystems.disks.s3.secret');
5454
Config::set('filesystems.disks.s3.token', env('AWS_SESSION_TOKEN'));
5555

56-
$account = env('AWS_ACCOUNT_ID');
57-
$region = env('AWS_REGION', env('AWS_DEFAULT_REGION', 'us-east-1'));
58-
5956
Config::set('queue.connections.sqs.key');
6057
Config::set('queue.connections.sqs.secret');
6158
Config::set('queue.connections.sqs.token', env('AWS_SESSION_TOKEN'));
62-
Config::set('queue.connections.sqs.prefix', env('SQS_PREFIX', "https://sqs.{$region}.amazonaws.com/{$account}"));
6359

6460
$this->app->when(QueueHandler::class)
6561
->needs('$connection')

0 commit comments

Comments
 (0)