Skip to content

Commit d8bb1a1

Browse files
authored
fix: test
1 parent 0bdb19c commit d8bb1a1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/pg/lib/client.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -631,6 +631,7 @@ class Client extends EventEmitter {
631631

632632
// In pipeline mode, only extended query protocol is allowed
633633
if (this._pipelining) {
634+
// TODO: better check!
634635
if (typeof config === 'string') {
635636
throw new Error('Simple query protocol is not allowed in pipeline mode. Use parameterized queries instead.')
636637
}

packages/pg/test/unit/client/pipeline-tests.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,21 @@ suite.test('pipeline mode with multiple queries', (cb) => {
5252
let completed = 0
5353

5454
// Send multiple queries in pipeline mode
55-
client.query('SELECT 1 as num', (err, res) => {
55+
client.query({text: 'SELECT 1 as num'}, (err, res) => {
5656
if (err) return cb(err)
5757
results[0] = res.rows[0].num
5858
completed++
5959
if (completed === 3) checkResults()
6060
})
6161

62-
client.query('SELECT 2 as num', (err, res) => {
62+
client.query({text: 'SELECT 2 as num'}, (err, res) => {
6363
if (err) return cb(err)
6464
results[1] = res.rows[0].num
6565
completed++
6666
if (completed === 3) checkResults()
6767
})
6868

69-
client.query('SELECT 3 as num', (err, res) => {
69+
client.query({text: 'SELECT 3 as num'}, (err, res) => {
7070
if (err) return cb(err)
7171
results[2] = res.rows[0].num
7272
completed++
@@ -192,6 +192,7 @@ suite.test('pipeline mode performance benefit', (cb) => {
192192
// Pipeline should be faster or at least not significantly slower
193193
// In real network conditions with latency, pipeline would show more benefit
194194
console.log(`Normal mode: ${normalTime}ms, Pipeline mode: ${pipelineTime}ms`)
195+
assert(normalTime <= pipelineTime)
195196

196197
client.end(cb)
197198
}

0 commit comments

Comments
 (0)