diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 6b99a42..6449e80 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer:latest", + "image": "ghcr.io/bytecodealliance/sample-wasi-http-rust/devcontainer:latest", "features": { //"ghcr.io/devcontainers/features/rust:1": {}, "ghcr.io/devcontainers/features/azure-cli:1": {} diff --git a/.github/workflows/publish-devcontainer.yml b/.github/workflows/publish-devcontainer.yml index bba388b..cae661b 100644 --- a/.github/workflows/publish-devcontainer.yml +++ b/.github/workflows/publish-devcontainer.yml @@ -10,7 +10,7 @@ on: # Defines two custom environment variables for the workflow. These are used for the Container registry domain, and a name for the Docker image that this workflow builds. env: REGISTRY: ghcr.io - IMAGE_NAME: ${{ github.repository }}-devcontainer + IMAGE_NAME: ${{ github.repository }}/devcontainer # There is a single job in this workflow. It's configured to run on the latest available version of Ubuntu. jobs: diff --git a/_/PR-50.md b/_/PR-50.md new file mode 100644 index 0000000..9edfd9e --- /dev/null +++ b/_/PR-50.md @@ -0,0 +1,21 @@ +# Fix the dev container publish step + +## Summary + +Fixes #50 + +The devcontainer publish workflow was failing because the Dockerfile referenced a `scripts/` directory that was removed in #26. + +## Changes + +- **Dockerfile**: Inlined the installation commands directly instead of copying the deleted `scripts/` directory: + - Install wasmtime via the official install script + - Install `cargo-component` and `wkg` via cargo + +- **devcontainer.json**: Updated the image reference from `ghcr.io/asw101/rust-wasi-hello-devcontainer:latest` to `ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer:latest` to match the workflow's published image path. + +## Testing + +- [ ] Trigger the `publish-devcontainer.yml` workflow manually via `workflow_dispatch` +- [ ] Verify the image builds and pushes successfully to `ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer` +- [ ] Open the repository in a GitHub Codespace to confirm the devcontainer works