Skip to content

Commit c936963

Browse files
committed
fix: exhaustive metadata and path fixes for deb/rpm packaging
1 parent fcf3460 commit c936963

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ jobs:
4242
if: matrix.os == 'ubuntu-latest'
4343
run: |
4444
cargo install cargo-deb cargo-generate-rpm
45+
# Symlink or copy the target binary to where deb/rpm expect it
46+
mkdir -p target/release
47+
cp target/${{ matrix.target }}/release/image-diff target/release/image-diff
4548
cargo deb --target ${{ matrix.target }} --no-build
4649
cargo generate-rpm --target ${{ matrix.target }}
47-
# Use wildcards to find the versioned files and move them to standard names
4850
mv target/${{ matrix.target }}/debian/*.deb image-diff.deb
4951
mv target/${{ matrix.target }}/generate-rpm/*.rpm image-diff.rpm
5052

Cargo.toml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ authors = ["Aftaab Siddiqui <aftaab@aftaab.xyz>"]
66
description = "Visual Difference Detection CLI for Images"
77
license = "MIT"
88
repository = "https://github.com/cachevector/image-diff"
9+
homepage = "https://github.com/cachevector/image-diff"
910

1011
[dependencies]
11-
image = "0.25.1"
12+
image = "0.24.9"
1213
clap = { version = "4.5.4", features = ["derive"] }
1314
rayon = "1.10.0"
1415
walkdir = "2.5.0"
@@ -23,7 +24,10 @@ image-compare = "0.5.0"
2324
dialoguer = "0.11.0"
2425
viuer = "0.11.0"
2526
delta_e = "0.2.1"
26-
lab = "0.7.2" # Matches delta_e dependency
27+
lab = "0.7.2"
28+
29+
[dev-dependencies]
30+
tempfile = "3.10.1"
2731

2832
[package.metadata.deb]
2933
maintainer = "Aftaab Siddiqui <aftaab@aftaab.xyz>"
@@ -40,13 +44,9 @@ assets = [
4044
]
4145

4246
[package.metadata.generate-rpm]
43-
package = "image-diff"
47+
assets = [
48+
{ source = "target/release/image-diff", dest = "/usr/bin/image-diff", mode = "755" }
49+
]
4450

4551
[package.metadata.generate-rpm.cargo]
4652
buildflags = ["--release"]
47-
48-
[package.metadata.generate-rpm.targets]
49-
image-diff = { path = "/usr/bin/image-diff" }
50-
51-
[dev-dependencies]
52-
tempfile = "3.10.1"

0 commit comments

Comments
 (0)