fix some workflow instance bugs

Signed-off-by: Shijie Sheng <liouvetren@gmail.com>

Author: shijiesheng

cadence/_internal/workflow/workflow_intance.py

@@ -1,5 +1,5 @@
 from asyncio import Task
-from typing import Optional
+from typing import Any, Optional
 from cadence._internal.workflow.deterministic_event_loop import DeterministicEventLoop
 from cadence.api.v1.common_pb2 import Payload
 from cadence.data_converter import DataConverter
@@ -19,7 +19,8 @@ def __init__(
     def start(self, input: Payload):
         if self._task is None:
             run_method = self._definition.get_run_method(self._instance)
-            workflow_input = self._data_converter.from_data(input, [])
+            # TODO handle multiple inputs
+            workflow_input = self._data_converter.from_data(input, [Any])
             self._task = self._loop.create_task(run_method(*workflow_input))
 
     def is_started(self) -> bool:

tests/cadence/_internal/workflow/test_workflow_engine.py

@@ -1,14 +1,19 @@
 #!/usr/bin/env python3
 from typing import List
 import pytest
+from cadence.api.v1.common_pb2 import Payload
 from cadence.api.v1.history_pb2 import (
+    DecisionTaskCompletedEventAttributes,
+    DecisionTaskScheduledEventAttributes,
+    DecisionTaskStartedEventAttributes,
     HistoryEvent,
+    WorkflowExecutionCompletedEventAttributes,
+    WorkflowExecutionStartedEventAttributes,
 )
 from cadence._internal.workflow.workflow_engine import WorkflowEngine
 from cadence import workflow
 from cadence.data_converter import DefaultDataConverter
 from cadence.workflow import WorkflowInfo, WorkflowDefinition, WorkflowDefinitionOptions
-from tests.cadence._internal.workflow.utils import create_mock_history_event
 
 
 class TestWorkflow:
@@ -28,15 +33,36 @@ def echo_workflow_definition(self) -> WorkflowDefinition:
 
     @pytest.fixture
     def simple_workflow_events(self) -> List[HistoryEvent]:
-        return create_mock_history_event(
-            event_types=[
-                "workflow_execution_started",
-                "decision_task_scheduled",
-                "decision_task_started",
-                "decision_task_completed",
-                "workflow_execution_completed",
-            ]
-        )
+        return [
+            HistoryEvent(
+                event_id=1,
+                workflow_execution_started_event_attributes=WorkflowExecutionStartedEventAttributes(
+                    input=Payload(data=b'"test-input"')
+                ),
+            ),
+            HistoryEvent(
+                event_id=2,
+                decision_task_scheduled_event_attributes=DecisionTaskScheduledEventAttributes(),
+            ),
+            HistoryEvent(
+                event_id=3,
+                decision_task_started_event_attributes=DecisionTaskStartedEventAttributes(
+                    scheduled_event_id=2
+                ),
+            ),
+            HistoryEvent(
+                event_id=4,
+                decision_task_completed_event_attributes=DecisionTaskCompletedEventAttributes(
+                    scheduled_event_id=2,
+                ),
+            ),
+            HistoryEvent(
+                event_id=5,
+                workflow_execution_completed_event_attributes=WorkflowExecutionCompletedEventAttributes(
+                    result=Payload(data=b'"echo: test-input"')
+                ),
+            ),
+        ]
 
     def test_process_simple_workflow(
         self,
@@ -45,8 +71,12 @@ def test_process_simple_workflow(
     ):
         workflow_engine = create_workflow_engine(echo_workflow_definition)
         decision_result = workflow_engine.process_decision(simple_workflow_events[:3])
-
         assert len(decision_result.decisions) == 1
+        assert decision_result.decisions[
+            0
+        ].complete_workflow_execution_decision_attributes.result == Payload(
+            data=b'"echo: test-input"'
+        )
 
 
 def create_workflow_engine(workflow_definition: WorkflowDefinition) -> WorkflowEngine:

tests/cadence/worker/test_decision_task_handler.py

@@ -86,7 +86,10 @@ def test_initialization(self, mock_client, mock_registry):
 
     @pytest.mark.asyncio
     async def test_handle_task_implementation_success(
-        self, handler: DecisionTaskHandler, sample_decision_task: PollForDecisionTaskResponse, mock_registry
+        self,
+        handler: DecisionTaskHandler,
+        sample_decision_task: PollForDecisionTaskResponse,
+        mock_registry,
     ):
         """Test successful decision task handling."""
 
@@ -117,7 +120,9 @@ async def run(self):
         mock_registry.get_workflow.assert_called_once_with("TestWorkflow")
 
         # Verify workflow engine was created and used
-        mock_engine.process_decision.assert_called_once_with(sample_decision_task.history.events)
+        mock_engine.process_decision.assert_called_once_with(
+            sample_decision_task.history.events
+        )
 
         # Verify response was sent
         handler._client.worker_stub.RespondDecisionTaskCompleted.assert_called_once()

tests/cadence/worker/test_decision_task_handler_integration.py

@@ -124,7 +124,9 @@ async def test_handle_decision_task_success(
             await decision_task_handler._handle_task_implementation(decision_task)
 
             # Verify the workflow engine was called
-            mock_engine.process_decision.assert_called_once_with(decision_task.history.events)
+            mock_engine.process_decision.assert_called_once_with(
+                decision_task.history.events
+            )
 
             # Verify the response was sent
             mock_client.worker_stub.RespondDecisionTaskCompleted.assert_called_once()

tests/cadence/worker/test_task_handler_integration.py

@@ -95,7 +95,9 @@ async def run(self):
 
         # Verify the complete flow
         mock_registry.get_workflow.assert_called_once_with("TestWorkflow")
-        mock_engine.process_decision.assert_called_once_with(sample_decision_task.history.events)
+        mock_engine.process_decision.assert_called_once_with(
+            sample_decision_task.history.events
+        )
         handler._client.worker_stub.RespondDecisionTaskCompleted.assert_called_once()
 
     @pytest.mark.asyncio
@@ -277,7 +279,9 @@ async def run(self):
 
             # Verify engine was created and used
             mock_engine_class.assert_called_once()
-            mock_engine.process_decision.assert_called_once_with(sample_decision_task.history.events)
+            mock_engine.process_decision.assert_called_once_with(
+                sample_decision_task.history.events
+            )
 
     @pytest.mark.asyncio
     async def test_error_handling_with_context_cleanup(