Use package name and relative path when hashing

Author: kraenhansen

packages/react-native-node-api-modules/src/node/babel-plugin/plugin.test.ts

@@ -6,6 +6,7 @@ import { transformFileSync } from "@babel/core";
 
 import { plugin } from "./plugin.js";
 import { setupTempDirectory } from "../test-utils.js";
+import { getNodeApiRequireCallArgument } from "../path-utils.js";
 
 describe("plugin", () => {
   it("transforms require calls, regardless", (context) => {
@@ -37,10 +38,12 @@ describe("plugin", () => {
       `,
     });
 
-    const ADDON_1_REQUIRE_ARG =
-      "@rpath/node-api-eb5c6d4b.framework/node-api-eb5c6d4b";
-    const ADDON_2_REQUIRE_ARG =
-      "@rpath/node-api-6c4e5fed.framework/node-api-6c4e5fed";
+    const ADDON_1_REQUIRE_ARG = getNodeApiRequireCallArgument(
+      path.join(tempDirectoryPath, "addon-1")
+    );
+    const ADDON_2_REQUIRE_ARG = getNodeApiRequireCallArgument(
+      path.join(tempDirectoryPath, "addon-2")
+    );
 
     {
       const result = transformFileSync(

packages/react-native-node-api-modules/src/node/path-utils.test.ts

@@ -3,6 +3,7 @@ import { describe, it } from "node:test";
 import path from "node:path";
 
 import {
+  determineModuleContext,
   isNodeApiModule,
   replaceWithNodeExtension,
   stripExtension,
@@ -53,3 +54,28 @@ describe("isNodeApiModule", () => {
     assert.equal(isNodeApiModule(path.join(tempDirectoryPath, "nope")), false);
   });
 });
+
+describe("determineModuleContext", () => {
+  it("works", (context) => {
+    const tempDirectoryPath = setupTempDirectory(context, {
+      "package.json": `{ "name": "my-package" }`,
+      "sub-package/package.json": `{ "name": "my-sub-package" }`,
+    });
+
+    {
+      const { packageName, relativePath } = determineModuleContext(
+        path.join(tempDirectoryPath, "some-dir/some-file.js")
+      );
+      assert.equal(packageName, "my-package");
+      assert.equal(relativePath, "some-dir/some-file.js");
+    }
+
+    {
+      const { packageName, relativePath } = determineModuleContext(
+        path.join(tempDirectoryPath, "sub-package/some-file.js")
+      );
+      assert.equal(packageName, "my-sub-package");
+      assert.equal(relativePath, "some-file.js");
+    }
+  });
+});

packages/react-native-node-api-modules/src/node/path-utils.ts

@@ -1,3 +1,4 @@
+import assert from "node:assert/strict";
 import path from "node:path";
 import fs from "node:fs";
 import crypto from "node:crypto";
@@ -37,13 +38,54 @@ export function replaceWithNodeExtension(modulePath: string) {
   });
 }
 
+export type ModuleContext = {
+  packageName: string;
+  relativePath: string;
+};
+
+/**
+ * Traverse the filesystem upward to find a name for the package that which contains a file.
+ */
+export function determineModuleContext(
+  modulePath: string,
+  originalPath = modulePath
+): ModuleContext {
+  const candidatePackageJsonPath = path.join(modulePath, "package.json");
+  const parentDirectoryPath = path.dirname(modulePath);
+  if (fs.existsSync(candidatePackageJsonPath)) {
+    const packageJsonContent = fs.readFileSync(
+      candidatePackageJsonPath,
+      "utf8"
+    );
+    const packageJson = JSON.parse(packageJsonContent) as unknown;
+    assert(
+      typeof packageJson === "object" && packageJson !== null,
+      "Expected package.json to be an object"
+    );
+    assert(
+      "name" in packageJson && typeof packageJson.name === "string",
+      "Expected package.json to have a name"
+    );
+    return {
+      packageName: packageJson.name,
+      relativePath: path.relative(modulePath, originalPath),
+    };
+  } else if (parentDirectoryPath === modulePath) {
+    // We've reached the root of the filesystem
+    throw new Error("Could not find containing package");
+  } else {
+    return determineModuleContext(parentDirectoryPath, originalPath);
+  }
+}
+
 export function hashNodeApiModulePath(modulePath: string) {
   // Transforming platform specific paths to a common path
   if (path.extname(modulePath) !== ".node") {
     return hashNodeApiModulePath(replaceWithNodeExtension(modulePath));
   }
+  const { packageName, relativePath } = determineModuleContext(modulePath);
   const hash = crypto.createHash("sha256");
-  hash.update(path.normalize(modulePath));
+  hash.update(path.resolve(packageName, relativePath));
   const result = hash.digest("hex").slice(0, 8);
   return result;
 }