removed trailing comma from linter

Author: dougg0k

apps/test-app/App.tsx

@@ -3,7 +3,7 @@ import {
   ConnectionText,
   MochaRemoteProvider,
   StatusEmoji,
-  StatusText,
+  StatusText
 } from "mocha-remote-react-native";
 // biome-ignore lint/correctness/noUnusedImports: Keep React
 import React from "react";
@@ -12,7 +12,7 @@ import { SafeAreaView, StyleSheet, View } from "react-native";
 function describeIf(
   condition: boolean,
   title: string,
-  fn: (this: Mocha.Suite) => void,
+  fn: (this: Mocha.Suite) => void
 ) {
   return condition ? describe(title, fn) : describe.skip(title, fn);
 }
@@ -26,11 +26,11 @@ type Context = {
 function loadTests({
   allTests = false,
   nodeAddonExamples = allTests,
-  ferricExample = allTests,
+  ferricExample = allTests
 }: Context) {
   describeIf(nodeAddonExamples, "Node Addon Examples", () => {
     for (const [suiteName, examples] of Object.entries(
-      nodeAddonExamplesSuites,
+      nodeAddonExamplesSuites
     )) {
       describe(suiteName, () => {
         for (const [exampleName, requireExample] of Object.entries(examples)) {
@@ -74,24 +74,24 @@ export default function App() {
 const styles = StyleSheet.create({
   container: {
     flex: 1,
-    backgroundColor: "#fff",
+    backgroundColor: "#fff"
   },
   statusContainer: {
     flex: 1,
     alignItems: "center",
-    justifyContent: "center",
+    justifyContent: "center"
   },
   statusEmoji: {
     fontSize: 30,
     margin: 30,
-    textAlign: "center",
+    textAlign: "center"
   },
   statusText: {
     fontSize: 20,
     margin: 20,
-    textAlign: "center",
+    textAlign: "center"
   },
   connectionText: {
-    textAlign: "center",
-  },
+    textAlign: "center"
+  }
 });

apps/test-app/babel.config.js

@@ -1,5 +1,5 @@
 module.exports = {
   presets: ["module:@react-native/babel-preset"],
   // plugins: [['module:react-native-node-api/babel-plugin', { stripPathSuffix: true }]],
-  plugins: ["module:react-native-node-api/babel-plugin"],
+  plugins: ["module:react-native-node-api/babel-plugin"]
 };

apps/test-app/metro.config.js

@@ -4,8 +4,8 @@ module.exports = makeMetroConfig({
     getTransformOptions: async () => ({
       transform: {
         experimentalImportSupport: false,
-        inlineRequires: false,
-      },
-    }),
-  },
+        inlineRequires: false
+      }
+    })
+  }
 });

apps/test-app/react-native.config.js

@@ -3,25 +3,25 @@ const project = (() => {
     const { configureProjects } = require("react-native-test-app");
     const project = configureProjects({
       android: {
-        sourceDir: "android",
+        sourceDir: "android"
       },
       ios: {
         sourceDir: "ios",
-        automaticPodsInstallation: false,
-      },
+        automaticPodsInstallation: false
+      }
       // windows: {
       //   sourceDir: "windows",
       //   solutionFile: "windows/react-native-node-api-example.sln",
       // },
     });
     return {
-      ...project,
+      ...project
     };
   } catch {
     return undefined;
   }
 })();
 
 module.exports = {
-  ...(project ? { project } : undefined),
+  ...(project ? { project } : undefined)
 };

biome.json

@@ -24,6 +24,11 @@
     "enabled": true,
     "indentStyle": "space"
   },
+  "javascript": {
+    "formatter": {
+      "trailingCommas": "none"
+    }
+  },
   "linter": {
     "enabled": true,
     "rules": {

packages/cmake-rn/src/cli.ts

@@ -13,7 +13,7 @@ import {
   allTargets,
   findPlatformForTarget,
   platformHasTarget,
-  platforms,
+  platforms
 } from "./platforms.js";
 import { getWeakNodeApiVariables } from "./weak-node-api.js";
 
@@ -24,12 +24,12 @@ EventEmitter.defaultMaxListeners = 100;
 
 const verboseOption = new Option(
   "--verbose",
-  "Print more output during the build",
+  "Print more output during the build"
 ).default(process.env.CI === "true");
 
 const sourcePathOption = new Option(
   "--source <path>",
-  "Specify the source directory containing a CMakeLists.txt file",
+  "Specify the source directory containing a CMakeLists.txt file"
 ).default(process.cwd());
 
 // TODO: Add "MinSizeRel" and "RelWithDebInfo"
@@ -47,40 +47,40 @@ const defaultTargets = CMAKE_RN_TARGETS ? CMAKE_RN_TARGETS.split(",") : [];
 for (const target of defaultTargets) {
   assert(
     (allTargets as string[]).includes(target),
-    `Unexpected target in CMAKE_RN_TARGETS: ${target}`,
+    `Unexpected target in CMAKE_RN_TARGETS: ${target}`
   );
 }
 
 const targetOption = new Option("--target <target...>", "Targets to build for")
   .choices(allTargets)
   .default(
     defaultTargets,
-    "CMAKE_RN_TARGETS environment variable split by ','",
+    "CMAKE_RN_TARGETS environment variable split by ','"
   );
 
 const buildPathOption = new Option(
   "--build <path>",
-  "Specify the build directory to store the configured CMake project",
+  "Specify the build directory to store the configured CMake project"
 );
 
 const cleanOption = new Option(
   "--clean",
-  "Delete the build directory before configuring the project",
+  "Delete the build directory before configuring the project"
 );
 
 const outPathOption = new Option(
   "--out <path>",
-  "Specify the output directory to store the final build artifacts",
+  "Specify the output directory to store the final build artifacts"
 ).default(false, "./{build}/{configuration}");
 
 const noAutoLinkOption = new Option(
   "--no-auto-link",
-  "Don't mark the output as auto-linkable by react-native-node-api",
+  "Don't mark the output as auto-linkable by react-native-node-api"
 );
 
 const noWeakNodeApiLinkageOption = new Option(
   "--no-weak-node-api-linkage",
-  "Don't pass the path of the weak-node-api library from react-native-node-api",
+  "Don't pass the path of the weak-node-api library from react-native-node-api"
 );
 
 let program = new Command("cmake-rn")
@@ -98,7 +98,7 @@ let program = new Command("cmake-rn")
 for (const platform of platforms) {
   const allOption = new Option(
     `--${platform.id}`,
-    `Enable all ${platform.name} triplets`,
+    `Enable all ${platform.name} triplets`
   );
   program = program.addOption(allOption);
   program = platform.amendCommand(program);
@@ -132,13 +132,13 @@ program = program.action(
         }
         if (targets.size === 0) {
           throw new Error(
-            "Found no default targets: Install some platform specific build tools",
+            "Found no default targets: Install some platform specific build tools"
           );
         } else {
           console.error(
             chalk.yellowBright("ℹ"),
             "Using default targets",
-            chalk.dim(`(${[...targets].join(", ")})`),
+            chalk.dim(`(${[...targets].join(", ")})`)
           );
         }
       }
@@ -155,26 +155,26 @@ program = program.action(
           platform,
           buildPath: targetBuildPath,
           outputPath: path.join(targetBuildPath, "out"),
-          options: baseOptions,
+          options: baseOptions
         };
       });
 
       // Configure every triplet project
       const targetsSummary = chalk.dim(
-        `(${getTargetsSummary(targetContexts)})`,
+        `(${getTargetsSummary(targetContexts)})`
       );
       await oraPromise(
         Promise.all(
           targetContexts.map(({ platform, ...context }) =>
-            configureProject(platform, context, baseOptions),
-          ),
+            configureProject(platform, context, baseOptions)
+          )
         ),
         {
           text: `Configuring projects ${targetsSummary}`,
           isSilent: baseOptions.verbose,
           successText: `Configured projects ${targetsSummary}`,
-          failText: ({ message }) => `Failed to configure projects: ${message}`,
-        },
+          failText: ({ message }) => `Failed to configure projects: ${message}`
+        }
       );
 
       // Build every triplet project
@@ -185,33 +185,33 @@ program = program.action(
             // This is important, since we might rename the output files
             await fs.promises.rm(context.outputPath, {
               recursive: true,
-              force: true,
+              force: true
             });
             await buildProject(platform, context, baseOptions);
-          }),
+          })
         ),
         {
           text: "Building projects",
           isSilent: baseOptions.verbose,
           successText: "Built projects",
-          failText: ({ message }) => `Failed to build projects: ${message}`,
-        },
+          failText: ({ message }) => `Failed to build projects: ${message}`
+        }
       );
 
       // Perform post-build steps for each platform in sequence
       for (const platform of platforms) {
         const relevantTargets = targetContexts.filter(({ target }) =>
-          platformHasTarget(platform, target),
+          platformHasTarget(platform, target)
         );
         if (relevantTargets.length === 0) {
           continue;
         }
         await platform.postBuild(
           {
             outputPath: baseOptions.out || baseOptions.source,
-            targets: relevantTargets,
+            targets: relevantTargets
           },
-          baseOptions,
+          baseOptions
         );
       }
     } catch (error) {
@@ -220,11 +220,11 @@ program = program.action(
       }
       throw error;
     }
-  },
+  }
 );
 
 function getTargetsSummary(
-  targetContexts: { target: string; platform: Platform }[],
+  targetContexts: { target: string; platform: Platform }[]
 ) {
   const targetsPerPlatform: Record<string, string[]> = {};
   for (const { target, platform } of targetContexts) {
@@ -256,7 +256,7 @@ function getTargetBuildPath(buildPath: string, target: unknown) {
 async function configureProject<T extends string>(
   platform: Platform<T[], Record<string, unknown>>,
   context: TargetContext<T>,
-  options: BaseOpts,
+  options: BaseOpts
 ) {
   const { target, buildPath, outputPath } = context;
   const { verbose, source, weakNodeApiLinkage } = options;
@@ -269,7 +269,7 @@ async function configureProject<T extends string>(
 
   const declarations = {
     ...nodeApiVariables,
-    CMAKE_LIBRARY_OUTPUT_DIRECTORY: outputPath,
+    CMAKE_LIBRARY_OUTPUT_DIRECTORY: outputPath
   };
 
   await spawn(
@@ -280,19 +280,19 @@ async function configureProject<T extends string>(
       "-B",
       buildPath,
       ...platform.configureArgs(context, options),
-      ...toDeclarationArguments(declarations),
+      ...toDeclarationArguments(declarations)
     ],
     {
       outputMode: verbose ? "inherit" : "buffered",
-      outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined,
-    },
+      outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined
+    }
   );
 }
 
 async function buildProject<T extends string>(
   platform: Platform<T[], Record<string, unknown>>,
   context: TargetContext<T>,
-  options: BaseOpts,
+  options: BaseOpts
 ) {
   const { target, buildPath } = context;
   const { verbose, configuration } = options;
@@ -304,19 +304,19 @@ async function buildProject<T extends string>(
       "--config",
       configuration,
       "--",
-      ...platform.buildArgs(context, options),
+      ...platform.buildArgs(context, options)
     ],
     {
       outputMode: verbose ? "inherit" : "buffered",
-      outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined,
-    },
+      outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined
+    }
   );
 }
 
 function toDeclarationArguments(declarations: Record<string, string>) {
   return Object.entries(declarations).flatMap(([key, value]) => [
     "-D",
-    `${key}=${value}`,
+    `${key}=${value}`
   ]);
 }