integration test on Windows CI

Author: matthargett

.github/workflows/check.yml

@@ -41,6 +41,34 @@ jobs:
       - run: npm run build
       - run: npm test --workspace gyp-to-cmake --workspace react-native-node-api-cmake --workspace react-native-node-api-modules
 
+  test-windows-addon-examples:
+    name: Run addon examples on Windows
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: lts/jod
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          java-version: "17"
+          distribution: "temurin"
+      - name: Setup Android SDK
+        uses: android-actions/setup-android@v3
+      # Version here should match the one in React Native template and packages/react-native-node-api-cmake/src/cli.ts
+      - run: sdkmanager --install "ndk;27.1.12297006"
+      - name: Install LLVM and Clang
+        uses: KyleMayes/install-llvm-action@v2
+        with:
+          version: "18.1"
+      - run: npm ci
+      - run: npm run build
+      - run: npm run copy-node-api-headers --workspace react-native-node-api-modules
+      - run: npm run build-weak-node-api --workspace react-native-node-api-modules
+      - run: npm run generate-weak-node-api-injector --workspace react-native-node-api-modules
+      - run: npm test --workspace react-native-node-addon-examples
+
   test-macos:
     name: Run tests which requires MacOS
     runs-on: macos-latest

packages/react-native-node-api-modules/scripts/generate-weak-node-api-injector.ts

@@ -1,6 +1,6 @@
 import fs from "node:fs";
 import path from "node:path";
-import cp from "node:child_process";
+import { spawnSyncCrossPlatform } from "./platform-utils.js";
 
 import { FunctionDecl, getNodeApiFunctions } from "./node-api-functions";
 
@@ -20,6 +20,8 @@ export function generateSource(functions: FunctionDecl[]) {
     #define WEAK_NODE_API_LIBRARY_NAME "@rpath/weak-node-api.framework/weak-node-api"
     #elif defined(__ANDROID__)
     #define WEAK_NODE_API_LIBRARY_NAME "libweak-node-api.so"
+    #elif defined(_WIN32)
+    #define WEAK_NODE_API_LIBRARY_NAME "weak-node-api.dll"
     #else
     #error "WEAK_NODE_API_LIBRARY_NAME cannot be defined for this platform"
     #endif
@@ -58,7 +60,7 @@ async function run() {
   const source = generateSource(nodeApiFunctions);
   const sourcePath = path.join(CPP_SOURCE_PATH, "WeakNodeApiInjector.cpp");
   await fs.promises.writeFile(sourcePath, source, "utf-8");
-  cp.spawnSync("clang-format", ["-i", sourcePath], { stdio: "inherit" });
+  spawnSyncCrossPlatform("clang-format", ["-i", sourcePath], { stdio: "inherit" });
 }
 
 run().catch((err) => {

packages/react-native-node-api-modules/scripts/generate-weak-node-api.ts

@@ -1,6 +1,6 @@
 import fs from "node:fs";
 import path from "node:path";
-import cp from "node:child_process";
+import { spawnSyncCrossPlatform } from "./platform-utils.js";
 
 import { FunctionDecl, getNodeApiFunctions } from "./node-api-functions";
 
@@ -74,12 +74,12 @@ async function run() {
   const header = generateHeader(nodeApiFunctions);
   const headerPath = path.join(WEAK_NODE_API_PATH, "weak_node_api.hpp");
   await fs.promises.writeFile(headerPath, header, "utf-8");
-  cp.spawnSync("clang-format", ["-i", headerPath], { stdio: "inherit" });
+  spawnSyncCrossPlatform("clang-format", ["-i", headerPath], { stdio: "inherit" });
 
   const source = generateSource(nodeApiFunctions);
   const sourcePath = path.join(WEAK_NODE_API_PATH, "weak_node_api.cpp");
   await fs.promises.writeFile(sourcePath, source, "utf-8");
-  cp.spawnSync("clang-format", ["-i", sourcePath], { stdio: "inherit" });
+  spawnSyncCrossPlatform("clang-format", ["-i", sourcePath], { stdio: "inherit" });
 }
 
 run().catch((err) => {

packages/react-native-node-api-modules/scripts/node-api-functions.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict";
 import path from "node:path";
-import cp from "node:child_process";
+import { execFileSyncCrossPlatform } from "./platform-utils.js";
 
 import {
   type NodeApiVersion,
@@ -29,7 +29,7 @@ const clangAstDump = z.object({
  * @param version
  */
 export function getNodeApiHeaderAST(version: NodeApiVersion) {
-  const output = cp.execFileSync(
+  const output = execFileSyncCrossPlatform(
     "clang",
     [
       // Declare the Node API version
@@ -50,7 +50,7 @@ export function getNodeApiHeaderAST(version: NodeApiVersion) {
       // Emitting the AST can produce a lot of output
       maxBuffer: 1024 * 1024 * 10,
     }
-  );
+  ) as string;
   const parsed = JSON.parse(output);
   return clangAstDump.parse(parsed);
 }