refactor: bumped NAPI_VERSION + removed node

paradowstack · paradowstack · commit f523909cc94b · 2025-07-24T16:19:03.000+02:00
diff --git a/packages/host/cpp/RuntimeNodeApi.cpp b/packages/host/cpp/RuntimeNodeApi.cpp
@@ -146,13 +146,8 @@ napi_status napi_get_node_version(
     return napi_invalid_arg;
   }
 
-  static napi_node_version version = {
-      .major = NODE_MAJOR_VERSION,
-      .minor = NODE_MINOR_VERSION,
-      .patch = NODE_PATCH_VERSION,
-  };
-  *result = &version;
-  return napi_ok;
+  *result = nullptr;
+  return napi_generic_failure;
 }
 
 napi_status napi_get_version(node_api_basic_env env, uint32_t* result) {
diff --git a/packages/host/cpp/Versions.hpp b/packages/host/cpp/Versions.hpp
@@ -1,7 +1,3 @@
 #pragma once
 
-#define NODE_MAJOR_VERSION 8
-#define NODE_MINOR_VERSION 6
-#define NODE_PATCH_VERSION 0
-
-#define NAPI_VERSION 1
+#define NAPI_VERSION 8

Original file line number	Diff line number	Diff line change
`@@ -146,13 +146,8 @@ napi_status napi_get_node_version(`
`146`	`146`	`return napi_invalid_arg;`
`147`	`147`	`}`
`148`	`148`
`149`		`- static napi_node_version version = {`
`150`		`- .major = NODE_MAJOR_VERSION,`
`151`		`- .minor = NODE_MINOR_VERSION,`
`152`		`- .patch = NODE_PATCH_VERSION,`
`153`		`- };`
`154`		`- *result = &version;`
`155`		`- return napi_ok;`
	`149`	`+ *result = nullptr;`
	`150`	`+ return napi_generic_failure;`
`156`	`151`	`}`
`157`	`152`
`158`	`153`	`napi_status napi_get_version(node_api_basic_env env, uint32_t* result) {`