Merge branch 'main' into reduce-ios-install-time

Author: dougg0k

.changeset/rich-donuts-mix.md

@@ -1,5 +1,5 @@
 ---
-"react-native-node-api-test-app": patch
+"@react-native-node-api/test-app": patch
 "react-native-node-api": patch
 ---
 

.github/workflows/check.yml

@@ -26,6 +26,7 @@ jobs:
           node-version: lts/jod
       - run: npm ci
       - run: npm run lint
+      - run: npm run prettier:check
   unit-tests:
     strategy:
       fail-fast: false

.prettierignore

@@ -0,0 +1,13 @@
+# Ignore artifacts
+dist
+build
+Pods
+target
+.cxx
+
+# Ignore hermes
+packages/host/hermes
+packages/node-addon-examples/examples
+packages/node-tests/node
+packages/node-tests/tests
+packages/node-tests/*.generated.js

apps/test-app/App.tsx

@@ -9,29 +9,32 @@ import {
 } from "mocha-remote-react-native";
 
 import { suites as nodeAddonExamplesSuites } from "@react-native-node-api/node-addon-examples";
+import { suites as nodeTestsSuites } from "@react-native-node-api/node-tests";
 
 function describeIf(
   condition: boolean,
   title: string,
-  fn: (this: Mocha.Suite) => void
+  fn: (this: Mocha.Suite) => void,
 ) {
   return condition ? describe(title, fn) : describe.skip(title, fn);
 }
 
 type Context = {
   allTests?: boolean;
   nodeAddonExamples?: boolean;
+  nodeTests?: boolean;
   ferricExample?: boolean;
 };
 
 function loadTests({
   allTests = false,
   nodeAddonExamples = allTests,
+  nodeTests = allTests,
   ferricExample = allTests,
 }: Context) {
   describeIf(nodeAddonExamples, "Node Addon Examples", () => {
     for (const [suiteName, examples] of Object.entries(
-      nodeAddonExamplesSuites
+      nodeAddonExamplesSuites,
     )) {
       describe(suiteName, () => {
         for (const [exampleName, requireExample] of Object.entries(examples)) {
@@ -46,6 +49,22 @@ function loadTests({
     }
   });
 
+  describeIf(nodeTests, "Node Tests", () => {
+    function registerTestSuite(suite: typeof nodeTestsSuites) {
+      for (const [name, suiteOrTest] of Object.entries(suite)) {
+        if (typeof suiteOrTest === "function") {
+          it(name, suiteOrTest);
+        } else {
+          describe(name, () => {
+            registerTestSuite(suiteOrTest);
+          });
+        }
+      }
+    }
+
+    registerTestSuite(nodeTestsSuites);
+  });
+
   describeIf(ferricExample, "ferric-example", () => {
     it("exports a callable sum function", () => {
       /* eslint-disable-next-line @typescript-eslint/no-require-imports -- TODO: Determine why a dynamic import doesn't work on Android */

apps/test-app/babel.config.js

@@ -1,5 +1,5 @@
 module.exports = {
-  presets: ['module:@react-native/babel-preset'],
+  presets: ["module:@react-native/babel-preset"],
   // plugins: [['module:react-native-node-api/babel-plugin', { stripPathSuffix: true }]],
-  plugins: ['module:react-native-node-api/babel-plugin'],
+  plugins: ["module:react-native-node-api/babel-plugin"],
 };

apps/test-app/package.json

@@ -10,10 +10,12 @@
     "test:android": "mocha-remote --exit-on-error -- concurrently --kill-others-on-fail --passthrough-arguments npm:metro 'npm:android -- {@}' --",
     "test:android:allTests": "MOCHA_REMOTE_CONTEXT=allTests npm run test:android -- ",
     "test:android:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples npm run test:android -- ",
+    "test:android:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests npm run test:android -- ",
     "test:android:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample npm run test:android -- ",
     "test:ios": "mocha-remote --exit-on-error -- concurrently --passthrough-arguments --kill-others-on-fail npm:metro 'npm:ios -- {@}' --",
     "test:ios:allTests": "MOCHA_REMOTE_CONTEXT=allTests npm run test:ios -- ",
     "test:ios:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples npm run test:ios -- ",
+    "test:ios:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests npm run test:ios -- ",
     "test:ios:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample npm run test:ios -- "
   },
   "dependencies": {
@@ -23,6 +25,8 @@
     "@react-native-community/cli": "^18.0.0",
     "@react-native-community/cli-platform-android": "^18.0.0",
     "@react-native-community/cli-platform-ios": "^18.0.0",
+    "@react-native-node-api/node-addon-examples": "*",
+    "@react-native-node-api/node-tests": "*",
     "@react-native/babel-preset": "0.79.0",
     "@react-native/metro-config": "0.79.0",
     "@react-native/typescript-config": "0.79.0",

apps/test-app/react-native.config.js

@@ -1,4 +1,3 @@
-
 const project = (() => {
   try {
     const { configureProjects } = require("react-native-test-app");
@@ -25,4 +24,4 @@ const project = (() => {
 
 module.exports = {
   ...(project ? { project } : undefined),
-};
+};

docs/HOW-IT-WORKS.md

@@ -25,7 +25,7 @@ The generated code looks something like this:
 
 ```javascript
 module.exports = require("react-native-node-api").requireNodeAddon(
-  "calculator-lib--prebuild"
+  "calculator-lib--prebuild",
 );
 ```
 

eslint.config.js

@@ -2,24 +2,30 @@
 
 import { globalIgnores } from "eslint/config";
 import globals from "globals";
-import eslint from '@eslint/js';
-import tseslint from 'typescript-eslint';
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
 
 export default tseslint.config(
-  globalIgnores([".nx/**"]),
-  globalIgnores(["**/dist/**"]),
-  globalIgnores(["apps/test-app/ios/**"]),
-  globalIgnores(["packages/host/hermes/**"]),
-  globalIgnores(["packages/node-addon-examples/examples/**"]),
-  globalIgnores(["packages/ferric-example/ferric_example.d.ts"]),
+  globalIgnores([
+    "**/dist/**",
+    "apps/test-app/ios/**",
+    "packages/host/hermes/**",
+    "packages/node-addon-examples/examples/**",
+    "packages/ferric-example/ferric_example.d.ts",
+    "packages/node-tests/node/**",
+    "packages/node-tests/tests/**",
+  ]),
   eslint.configs.recommended,
   tseslint.configs.recommended,
+  eslintConfigPrettier,
   {
     files: [
       "apps/test-app/*.js",
       "packages/node-addon-examples/*.js",
       "packages/host/babel-plugin.js",
-      "packages/host/react-native.config.js"
+      "packages/host/react-native.config.js",
+      "packages/node-tests/tests.generated.js",
     ],
     languageOptions: {
       parserOptions: {
@@ -38,7 +44,7 @@ export default tseslint.config(
     files: [
       "packages/gyp-to-cmake/bin/*.js",
       "packages/host/bin/*.mjs",
-      "packages/host/scripts/*.mjs"
+      "packages/host/scripts/*.mjs",
     ],
     languageOptions: {
       globals: {