Build and bundle node test addons

Author: kraenhansen

package-lock.json

@@ -0,0 +1 @@
+export const buildType = "Release";

packages/node-tests/common.ts

@@ -13,17 +13,18 @@
   "scripts": {
     "copy-tests": "tsx scripts/copy-tests.mts",
     "gyp-to-cmake": "gyp-to-cmake ./tests",
-    "build": "tsx scripts/build-tests.mts",
+    "build-tests": "tsx scripts/build-tests.mts",
     "bundle": "rolldown -c rolldown.config.mts",
-    "copy-and-build": "npm run copy-tests && npm run gyp-to-cmake && npm run build",
-    "test": "npm run copy-and-build"
+    "bootstrap": "npm run copy-tests && npm run gyp-to-cmake && npm run build-tests && npm run bundle"
   },
   "devDependencies": {
+    "@rollup/plugin-babel": "^6.0.4",
     "cmake-js": "^7.3.1",
     "cmake-rn": "*",
     "gyp-to-cmake": "*",
     "prebuildify": "^6.0.1",
+    "react-native-node-api": "^0.3.2",
     "read-pkg": "^9.0.1",
-    "rolldown": "1.0.0-beta.26"
+    "rolldown": "1.0.0-beta.29"
   }
 }

packages/node-tests/package.json

@@ -1,15 +1,90 @@
-import { defineConfig } from "rolldown";
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import path from "node:path";
 
-export default defineConfig([
-  {
-    input: "tests/js-native-api/2_function_arguments/test.js",
+import { defineConfig, type RolldownOptions } from "rolldown";
+import { aliasPlugin, replacePlugin } from "rolldown/experimental";
+import { babel } from "@rollup/plugin-babel";
+
+import nodeApiBabelPlugin from "react-native-node-api/babel-plugin";
+
+function readGypTargetNames(gypFilePath: string): string[] {
+  const contents = JSON.parse(fs.readFileSync(gypFilePath, "utf-8")) as unknown;
+  assert(
+    typeof contents === "object" && contents !== null,
+    "Expected gyp file to contain a valid JSON object"
+  );
+  assert("targets" in contents, "Expected targets in gyp file");
+  const { targets } = contents;
+  assert(Array.isArray(targets), "Expected targets to be an array");
+  return targets.map(({ target_name }) => {
+    assert(
+      typeof target_name === "string",
+      "Expected target_name to be a string"
+    );
+    return target_name;
+  });
+}
+
+function testBundle(
+  testDirectory: string,
+  testFiles: string[]
+): RolldownOptions[] {
+  const gypFilePath = path.join(testDirectory, "binding.gyp");
+  const targetNames = readGypTargetNames(gypFilePath);
+  return testFiles.map((testFile) => ({
+    input: path.join(testDirectory, testFile),
     output: {
-      file: "bundle.js",
+      file: path.join(
+        testDirectory,
+        path.basename(testFile, ".js") + ".bundle.js"
+      ),
     },
     resolve: {
-      alias: {
-        "../../common": "yo.ts",
-      },
+      conditionNames: ["react-native"],
     },
-  },
+    polyfillRequire: false,
+    plugins: [
+      // Replace dynamic require statements for addon targets to allow the babel plugin to handle them correctly
+      replacePlugin(
+        Object.fromEntries(
+          targetNames.map((targetName) => [
+            `require(\`./build/\${common.buildType}/${targetName}\`)`,
+            `require('./build/Release/${targetName}')`,
+          ])
+        ),
+        {
+          delimiters: ["", ""],
+        }
+      ),
+      // Use the babel plugin to transform require statements for addons before they get resolved
+      babel({
+        babelHelpers: "bundled",
+        plugins: [nodeApiBabelPlugin],
+      }),
+      replacePlugin(
+        {
+          // Replace "__require" statement with a regular "require" to allow Metro to resolve it
+          '__require("react-native-node-api")':
+            'require("react-native-node-api")',
+        },
+        {
+          delimiters: ["", ""],
+        }
+      ),
+      aliasPlugin({
+        entries: [
+          {
+            find: "../../common",
+            replacement: "./common.ts",
+          },
+        ],
+      }),
+    ],
+    external: ["react-native-node-api"],
+  }));
+}
+
+export default defineConfig([
+  ...testBundle("tests/js-native-api/2_function_arguments", ["test.js"]),
 ]);

packages/node-tests/rolldown.config.mts

@@ -1,6 +1,6 @@
 import { execSync } from "node:child_process";
 
-import { findCMakeProjects } from "./utils.mts";
+import { findCMakeProjects } from "./utils.mjs";
 
 const projectDirectories = findCMakeProjects();
 
@@ -12,11 +12,4 @@ for (const projectDirectory of projectDirectories) {
     cwd: projectDirectory,
     stdio: "inherit",
   });
-
-  console.log(`Running "cmake-js" in ${projectDirectory} to build for Node.js`);
-  execSync("cmake-js", {
-    cwd: projectDirectory,
-    stdio: "inherit",
-  });
-  console.log();
 }

packages/node-tests/scripts/build-tests.mts

@@ -2,7 +2,7 @@ import fs from "node:fs";
 import path from "node:path";
 import cp from "node:child_process";
 
-import { TESTS_DIR } from "./utils.mts";
+import { TESTS_DIR } from "./utils.mjs";
 
 const NODE_REPO_URL = "git@github.com:nodejs/node.git";
 const NODE_REPO_DIR = path.resolve(import.meta.dirname, "../node");

packages/node-tests/scripts/copy-tests.mts

@@ -0,0 +1,7 @@
+{
+  "files": [],
+  "references": [
+    { "path": "./tsconfig.tests.json" },
+    { "path": "./tsconfig.node-scripts.json" }
+  ]
+}

packages/node-tests/tsconfig.json

@@ -0,0 +1,12 @@
+{
+  "extends": "@tsconfig/node22/tsconfig.json",
+  "compilerOptions": {
+    "composite": true,
+    "emitDeclarationOnly": true,
+    "outDir": "dist",
+    "rootDir": "scripts",
+    "types": ["node", "read-pkg"]
+  },
+  "include": ["scripts/**/*.mts"],
+  "exclude": []
+}

packages/node-tests/tsconfig.node-scripts.json

@@ -0,0 +1,12 @@
+{
+  "extends": "@tsconfig/react-native",
+  "compilerOptions": {
+    "composite": true,
+    "noEmit": false,
+    "module": "commonjs",
+    "outDir": "dist",
+    "rootDir": "src",
+    "types": ["react-native"]
+  },
+  "include": ["src/*.ts"]
+}

packages/node-tests/tsconfig.tests.json

@@ -5,6 +5,7 @@
     { "path": "./packages/gyp-to-cmake/tsconfig.json" },
     { "path": "./packages/cmake-rn/tsconfig.json" },
     { "path": "./packages/ferric/tsconfig.json" },
-    { "path": "./packages/node-addon-examples/tsconfig.json" }
+    { "path": "./packages/node-addon-examples/tsconfig.json" },
+    { "path": "./packages/node-tests/tsconfig.json" }
   ]
 }