Skip to content

Commit 58c293f

Browse files
benjaminjbandrewlecuyer
authored andcommitted
PR feedback
1 parent 0bbe415 commit 58c293f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/content/guides/data-migration.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ With the above configuration in place, your existing PVC will be used when creat
5454

5555
## Considerations
5656

57-
### Removing legacy labels
57+
### Removing PGO v4 labels
5858

59-
When migrating data volumes from v4 to v5, PGO will add new required labels to the PVCs, but **it will not remove existing labels**. The result is that a PVC might have labels that identify it as both a v4 and a v5 product, which can lead to unintended behavior.
59+
When migrating data volumes from v4 to v5, PGO relabels all volumes for PGO v5, but **will not remove existing PGO v4 labels**. This results in PVCs that are labeled for both PGO v4 and v5, which can lead to unintended behavior.
6060

61-
To avoid that, you must manually remove the `pg-cluster` and `vendor` labels, which you can do with a `kubectl` command. For instance, given a cluster named `hippo` with a dedicated pgBackRest repo, the PVC will be `hippo-pgbr-repo`, and the legacy labels can be remove with the below command:
61+
To avoid that, you must manually remove the `pg-cluster` and `vendor` labels, which you can do with a `kubectl` command. For instance, given a cluster named `hippo` with a dedicated pgBackRest repo, the PVC will be `hippo-pgbr-repo`, and the PGO v4 labels can be removed with the below command:
6262

6363
```
6464
kubectl label pvc hippo-pgbr-repo \

docs/content/upgrade/v4tov5/upgrade-method-1-data-volumes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ spec:
9999
Please see the [Data Migration]({{< relref "guides/data-migration.md" >}}) section of the [tutorial]({{< relref "tutorial/_index.md" >}}) for more details on how to properly populate this section of the spec when migrating from a PGO v4 cluster.
100100

101101
{{% notice info %}}
102-
Note that when migrating data volumes from v4 to v5, PGO will add new required labels to the PVCs, but **it will not remove existing labels**. The result is that a PVC might have labels that identify it as both a v4 and a v5 product, which can lead to unintended behavior.
102+
Note that when migrating data volumes from v4 to v5, PGO relabels all volumes for PGO v5, but **will not remove existing PGO v4 labels**. This results in PVCs that are labeled for both PGO v4 and v5, which can lead to unintended behavior.
103103
<br><br>
104-
To avoid that behavior, follow the instructions in the section on [removing legacy labels]({{< ref "guides/data-migration.md#removing-legacy-labels" >}}).
104+
To avoid that behavior, follow the instructions in the section on [removing PGO v4 labels]({{< ref "guides/data-migration.md#removing-pgo-v4-labels" >}}).
105105
{{% /notice %}}
106106

107107
2\. If you customized Postgres parameters, you will need to ensure they match in the PGO v5 cluster. For more information, please review the tutorial on [customizing a Postgres cluster]({{< relref "tutorial/customize-cluster.md" >}}).

0 commit comments

Comments
 (0)