Disable errchkjson linter temporarily

The "errchkjson" linter looks specifically at calls that encode or
marshal values to JSON. It does not ignore assignments to the blank
identifier like the "errcheck" linter. Instead, it recommends ignoring
the error only when the type being marshaled is guaranteed to marshal.

Without configuration, it recommends changes to our tests. When
configured to analyze the types being marshaled, it recommends changes
to our code. Disable it entirely for now and add it to the list of
possible future linters.

Issue: [sc-13607]

Author: cbandy

.github/workflows/lint.yaml

@@ -42,9 +42,8 @@ jobs:
       # Count issues reported by disabled linters. The command always
       # exits zero to ensure it does not fail the pull request check.
       - name: Count non-blocking issues
-        run: >
-          golangci-lint run \
-            --config .golangci.next.yaml \
+        run: |
+          golangci-lint run --config .golangci.next.yaml \
             --issues-exit-code 0 \
             --max-issues-per-linter 0 \
             --max-same-issues 0 \

.golangci.next.yaml

@@ -8,6 +8,7 @@
 linters:
   disable-all: true
   enable:
+    - errchkjson
     - gocritic
     - godot
     - godox
@@ -30,6 +31,9 @@ issues:
   exclude-use-default: false
 
 linters-settings:
+  errchkjson:
+    check-error-free-encoding: true
+
   thelper:
     # https://github.com/kulti/thelper/issues/27
     tb:   { begin: true, first: true }

.golangci.yaml

@@ -2,6 +2,7 @@
 
 linters:
   disable:
+    - errchkjson
     - gofumpt
     - scopelint
   enable: