Refactor looping tests

Instead of setting an amount of time that these loops are allowed to
run, we can use an infinite loop that will fail when Kuttl hits its
timeout.

Issue [sc-18801]

Author: jmckulk

testing/kuttl/e2e/root-cert-ownership/01--check-owners.yaml

@@ -5,15 +5,13 @@ commands:
   # Get a list of the current owners of the root ca cert secret and verify that
   # both owners are listed.
   - script: |
-      for i in {1..5}; do
+      contains() { bash -ceu '[[ "$1" == *"$2"* ]]' - "$@"; }
+      while true; do
           sleep 1 # this sleep allows time for the owner reference list to be updated
           CURRENT_OWNERS=$(kubectl --namespace="${NAMESPACE}" get secret \
             pgo-root-cacert -o jsonpath='{.metadata.ownerReferences[*].name}')
           # If owner1 and owner2 are both listed, exit successfully
-          contains() { bash -ceu '[[ "$1" == *"$2"* ]]' - "$@"; }
           if contains "${CURRENT_OWNERS}" "owner1" && contains "${CURRENT_OWNERS}" "owner2"; then
               exit 0
           fi
       done
-      # proper ownership references were not found, so the test fails
-      exit 1

testing/kuttl/e2e/root-cert-ownership/03--check-owners.yaml

@@ -5,15 +5,13 @@ commands:
   # Get a list of the current owners of the root ca cert secret and verify that
   # owner1 is no longer listed and owner2 is found.
   - script: |
-      for i in {1..5}; do
+      contains() { bash -ceu '[[ "$1" == *"$2"* ]]' - "$@"; }
+      while true; do
           sleep 1 # this sleep allows time for the owner reference list to be updated
           CURRENT_OWNERS=$(kubectl --namespace="${NAMESPACE}" get secret \
             pgo-root-cacert -o jsonpath='{.metadata.ownerReferences[*].name}')
           # If owner1 is removed and owner2 is still listed, exit successfully
-          contains() { bash -ceu '[[ "$1" == *"$2"* ]]' - "$@"; }
-          if ! contains "${CURRENT_OWNERS}" "owner1" && contains "${CURRENT_OWNERS}" "owner2"; then
+          if !(contains "${CURRENT_OWNERS}" "owner1") && contains "${CURRENT_OWNERS}" "owner2"; then
               exit 0
           fi
       done
-      # proper ownership references were not found, so the test fails
-      exit 1

testing/kuttl/e2e/root-cert-ownership/05--check-secret.yaml

@@ -8,9 +8,12 @@ commands:
   # secret should be deleted.
   - script: |
       NUM_CLUSTERS=$(kubectl --namespace="${NAMESPACE}" get postgrescluster --output name | wc -l)
+      echo "Found ${NUM_CLUSTERS} clusters"
       if [ "$NUM_CLUSTERS" != 0 ]; then
-          for i in {1..5}; do
-              sleep 1 # This sleep allows time for the owner reference list to be updated
+          # Continue checking until Kuttl times out
+          # If at least one owner is never removed the test fails
+          while true; do
+              sleep 5 # This sleep allows time for the owner reference list to be updated
               CURRENT_OWNERS=$(kubectl --namespace="${NAMESPACE}" get secret \
                 pgo-root-cacert -o jsonpath='{.metadata.ownerReferences[*].name}')
               # If neither owner is listed, exit successfully
@@ -19,17 +22,15 @@ commands:
                   exit 0
               fi
           done
-          # At least one owner was never removed, so the test fails
-          exit 1
       else
-          for i in {1..5}; do
-              sleep 1 # this sleep allows time for garbage collector to delete the secret
+          # Continue checking until Kuttl times out
+          # If the secret is never removed, the test fails
+          while true; do
+              sleep 5 # this sleep allows time for garbage collector to delete the secret
               ROOT_SECRET=$(kubectl --namespace="${NAMESPACE}" get --ignore-not-found \
                 secret pgo-root-cacert --output name | wc -l)
               if [ "$ROOT_SECRET" = 0 ]; then
                   exit 0
               fi
           done
-          # The root secret was never removed, so the test fails
-          exit 1
       fi