From e91a8eb3aa477c372ecbd65552138c771f25afd2 Mon Sep 17 00:00:00 2001 From: devshinon-br Date: Mon, 10 May 2021 13:51:33 -0300 Subject: [PATCH 1/5] feat: add news functions in node-binance-api.js, tradesByDate and allOrdersByDate --- node-binance-api.js | 66 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/node-binance-api.js b/node-binance-api.js index 7c49a860..e1f558c1 100644 --- a/node-binance-api.js +++ b/node-binance-api.js @@ -3129,6 +3129,41 @@ let api = function Binance( options = {} ) { } }, + /** + * Gets all order of a given symbol + * @param {string} symbol - the symbol + * @param {number} startTime - the start time + * @param {number} endTime - the end time + * @param {function} callback - the callback function (can also accept options) + * @param {object} options - additional options + * @return {promise or undefined} - omitting the callback returns a promise + */ + allOrdersByDate: function ( symbol, startTime, endTime, callback, options = {} ) { + let parameters = Object.assign( { symbol: symbol, startTime: startTime, endTime: endTime }, options ); + if ( typeof callback == 'object' ) { + options = callback; + callback = false; + } + if ( !callback ) { + return new Promise( ( resolve, reject ) => { + callback = ( error, response ) => { + if ( error ) { + reject( error ); + } else { + resolve( response ); + } + } + signedRequest( baseTest + 'v3/allOrders', parameters, function ( error, data ) { + return callback.call( this, error, data, symbol, startTime, endTime ); + } ); + } ) + } else { + signedRequest( baseTest + 'v3/allOrders', parameters, function ( error, data ) { + return callback.call( this, error, data, symbol, startTime, endTime ); + } ); + } + }, + /** * Gets the depth information for a given symbol * @param {string} symbol - the symbol @@ -3597,6 +3632,37 @@ let api = function Binance( options = {} ) { } }, + /** + * Get trades for a given symbol and date + * @param {string} symbol - the symbol + * @param {numver} startTime - the start time + * @param {number} endTime - the end time + * @param {function} callback - the callback function + * @param {object} options - additional options + * @return {promise or undefined} - omitting the callback returns a promise + */ + tradesByDate: ( symbol, startTime, endTime, callback, options = {} ) => { + let parameters = Object.assign( { symbol: symbol, startTime: startTime, endTime: endTime}, options ); + if ( !callback ) { + return new Promise( ( resolve, reject ) => { + callback = ( error, response ) => { + if ( error ) { + reject( error ); + } else { + resolve( response ); + } + } + signedRequest( baseTest + 'v3/myTrades', parameters, function ( error, data ) { + return callback.call( this, error, data, symbol, startTime, endTime ); + } ); + } ) + } else { + signedRequest( baseTest + 'v3/myTrades', parameters, function ( error, data ) { + return callback.call( this, error, data, symbol, startTime, endTime ); + } ); + } + }, + /** * Tell api to use the server time to offset time indexes * @param {function} callback - the callback function From 00f759b8a8e40bcc556e22a834eacd62250dd587 Mon Sep 17 00:00:00 2001 From: devshinon-br Date: Tue, 11 May 2021 05:44:01 -0300 Subject: [PATCH 2/5] chore: alter name project --- package.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index e3280599..e447f82e 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "node-binance-api", + "name": "node-binance-api-with-trades-and-orders-by-date", "version": "0.12.5", "description": "Binance API for node https://github.com/jaggedsoft/node-binance-api", "main": "node-binance-api.js", @@ -48,5 +48,8 @@ "mocha": "^6.2.2", "mocha-lcov-reporter": "^1.3.0", "nyc": "^14.1.1" + }, + "directories": { + "example": "examples" } } From 096a3798ec9ef70b568a0212d6c1334b675571fe Mon Sep 17 00:00:00 2001 From: devshinon-br Date: Fri, 14 May 2021 23:29:11 -0300 Subject: [PATCH 3/5] fix: remove baseTest of parameters signedRequest --- node-binance-api.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/node-binance-api.js b/node-binance-api.js index e1f558c1..f2f5bbcf 100644 --- a/node-binance-api.js +++ b/node-binance-api.js @@ -3153,12 +3153,12 @@ let api = function Binance( options = {} ) { resolve( response ); } } - signedRequest( baseTest + 'v3/allOrders', parameters, function ( error, data ) { + signedRequest( base + 'v3/allOrders', parameters, function ( error, data ) { return callback.call( this, error, data, symbol, startTime, endTime ); } ); } ) } else { - signedRequest( baseTest + 'v3/allOrders', parameters, function ( error, data ) { + signedRequest( base + 'v3/allOrders', parameters, function ( error, data ) { return callback.call( this, error, data, symbol, startTime, endTime ); } ); } @@ -3652,12 +3652,12 @@ let api = function Binance( options = {} ) { resolve( response ); } } - signedRequest( baseTest + 'v3/myTrades', parameters, function ( error, data ) { + signedRequest( base + 'v3/myTrades', parameters, function ( error, data ) { return callback.call( this, error, data, symbol, startTime, endTime ); } ); } ) } else { - signedRequest( baseTest + 'v3/myTrades', parameters, function ( error, data ) { + signedRequest( base + 'v3/myTrades', parameters, function ( error, data ) { return callback.call( this, error, data, symbol, startTime, endTime ); } ); } From d917f142115aa1515f49ec1e8a5fb1457b1d3a92 Mon Sep 17 00:00:00 2001 From: devshinon-br Date: Fri, 14 May 2021 23:33:57 -0300 Subject: [PATCH 4/5] chore: add my git fork repository --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e447f82e..c27b0a95 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ }, "repository": { "type": "git", - "url": "git://github.com/jaggedsoft/node-binance-api.git" + "url": "https://github.com/devshinon-br/node-binance-api" }, "keywords": [ "binance", From 7f27aa133e5b47bbcf1b9497c871477b7cc10bc7 Mon Sep 17 00:00:00 2001 From: devshinon-br Date: Fri, 14 May 2021 23:38:22 -0300 Subject: [PATCH 5/5] chore: alter version project --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c27b0a95..dbe1b140 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-binance-api-with-trades-and-orders-by-date", - "version": "0.12.5", + "version": "0.12.6", "description": "Binance API for node https://github.com/jaggedsoft/node-binance-api", "main": "node-binance-api.js", "dependencies": {