Scope TCA inspections to column definitions

Author: cedricziel

src/main/java/com/cedricziel/idea/typo3/codeInspection/MissingColumnTypeInspection.java

@@ -13,6 +13,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import static com.cedricziel.idea.typo3.psi.PhpElementsUtil.extractArrayIndexFromValue;
+import static com.cedricziel.idea.typo3.util.TCAUtil.insideTCAColumnDefinition;
 
 public class MissingColumnTypeInspection extends PhpInspection {
     @Nls
@@ -40,7 +41,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, bo
             public void visitPhpElement(PhpPsiElement element) {
 
                 boolean isArrayStringValue = PhpElementsUtil.isStringArrayValue().accepts(element);
-                if (!isArrayStringValue) {
+                if (!isArrayStringValue || !insideTCAColumnDefinition(element)) {
                     return;
                 }
 

src/main/java/com/cedricziel/idea/typo3/codeInspection/MissingRenderTypeInspection.java

@@ -14,6 +14,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import static com.cedricziel.idea.typo3.psi.PhpElementsUtil.extractArrayIndexFromValue;
+import static com.cedricziel.idea.typo3.util.TCAUtil.insideTCAColumnDefinition;
 
 public class MissingRenderTypeInspection extends PhpInspection {
     @Nls
@@ -41,7 +42,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, bo
             public void visitPhpElement(PhpPsiElement element) {
 
                 boolean isArrayStringValue = PhpElementsUtil.isStringArrayValue().accepts(element);
-                if (!isArrayStringValue) {
+                if (!isArrayStringValue || !insideTCAColumnDefinition(element)) {
                     return;
                 }
 

src/main/java/com/cedricziel/idea/typo3/codeInspection/MissingTableInspection.java

@@ -13,6 +13,7 @@
 import org.jetbrains.annotations.NotNull;
 
 import static com.cedricziel.idea.typo3.util.TCAUtil.arrayIndexIsTCATableNameField;
+import static com.cedricziel.idea.typo3.util.TCAUtil.insideTCAColumnDefinition;
 
 public class MissingTableInspection extends PhpInspection {
     @Nls
@@ -40,7 +41,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, bo
             public void visitPhpElement(PhpPsiElement element) {
 
                 boolean isArrayStringValue = PhpElementsUtil.isStringArrayValue().accepts(element);
-                if (!isArrayStringValue) {
+                if (!isArrayStringValue || !insideTCAColumnDefinition(element)) {
                     return;
                 }
 

src/main/java/com/cedricziel/idea/typo3/tca/codeInspection/InvalidQuantityInspection.java

@@ -15,6 +15,7 @@
 import java.util.Arrays;
 
 import static com.cedricziel.idea.typo3.psi.PhpElementsUtil.extractArrayIndexFromValue;
+import static com.cedricziel.idea.typo3.util.TCAUtil.insideTCAColumnDefinition;
 
 public class InvalidQuantityInspection extends PhpInspection {
     @Nls
@@ -37,7 +38,7 @@ public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, bo
             public void visitPhpElement(PhpPsiElement element) {
 
                 boolean isArrayStringValue = PhpElementsUtil.isStringArrayValue().accepts(element);
-                if (!isArrayStringValue) {
+                if (!isArrayStringValue || !insideTCAColumnDefinition(element)) {
                     return;
                 }
 

src/main/java/com/cedricziel/idea/typo3/util/TCAUtil.java

@@ -142,4 +142,17 @@ private static Set<PsiElement> findAvailableRenderTypes(Project project) {
 
         return elements;
     }
+
+    public static boolean insideTCAColumnDefinition(PsiElement element) {
+        return PlatformPatterns.psiElement()
+                .withAncestor(
+                        11,
+                        PlatformPatterns
+                                .psiElement(PhpElementTypes.HASH_ARRAY_ELEMENT)
+                                .withChild(
+                                        PlatformPatterns.psiElement(PhpElementTypes.ARRAY_KEY).withText("'columns'")
+                                )
+                )
+                .accepts(element);
+    }
 }