Merge pull request #62 from cedricziel/validate-tca-types

cedricziel · web-flow · commit 7d53617abf22 · 2017-10-30T17:44:13.000+01:00
Add inspection for valid column types
diff --git a/src/main/java/com/cedricziel/idea/typo3/codeInspection/MissingColumnInspection.java b/src/main/java/com/cedricziel/idea/typo3/codeInspection/MissingColumnInspection.java
@@ -0,0 +1,62 @@
+package com.cedricziel.idea.typo3.codeInspection;
+
+import com.cedricziel.idea.typo3.psi.PhpElementsUtil;
+import com.cedricziel.idea.typo3.util.TCAUtil;
+import com.intellij.codeInsight.daemon.GroupNames;
+import com.intellij.codeInspection.ProblemsHolder;
+import com.intellij.psi.PsiElementVisitor;
+import com.jetbrains.php.lang.inspections.PhpInspection;
+import com.jetbrains.php.lang.psi.elements.PhpPsiElement;
+import com.jetbrains.php.lang.psi.elements.StringLiteralExpression;
+import com.jetbrains.php.lang.psi.visitors.PhpElementVisitor;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NotNull;
+
+import static com.cedricziel.idea.typo3.psi.PhpElementsUtil.extractArrayIndexFromValue;
+
+public class MissingColumnInspection extends PhpInspection {
+    @Nls
+    @NotNull
+    @Override
+    public String getGroupDisplayName() {
+        return GroupNames.BUGS_GROUP_NAME;
+    }
+
+    @NotNull
+    public String getDisplayName() {
+        return "Missing column type definition";
+    }
+
+    @NotNull
+    public String getShortName() {
+        return "MisssingColumnInspection";
+    }
+
+    @NotNull
+    @Override
+    public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder problemsHolder, boolean b) {
+        return new PhpElementVisitor() {
+            @Override
+            public void visitPhpElement(PhpPsiElement element) {
+
+                boolean isArrayStringValue = PhpElementsUtil.isStringArrayValue().accepts(element);
+                if (!isArrayStringValue) {
+                    return;
+                }
+
+
+                String arrayIndex = extractArrayIndexFromValue(element);
+                if (arrayIndex != null && arrayIndex.equals("type")) {
+                    if (element instanceof StringLiteralExpression) {
+                        String tableName = ((StringLiteralExpression) element).getContents();
+                        boolean isValidRenderType = TCAUtil.getAvailableColumnTypes(element).contains(tableName);
+
+                        if (!isValidRenderType) {
+                            problemsHolder.registerProblem(element, "Missing column type definition");
+                        }
+                    }
+                }
+            }
+        };
+    }
+}
diff --git a/src/main/java/com/cedricziel/idea/typo3/codeInspection/TYPO3InspectionToolProvider.java b/src/main/java/com/cedricziel/idea/typo3/codeInspection/TYPO3InspectionToolProvider.java
@@ -9,6 +9,7 @@ public Class[] getInspectionClasses() {
 
         return new Class[]{
                 ExtbasePropertyInjectionInspection.class,
+                MissingColumnInspection.class,
                 MissingRenderTypeInspection.class,
                 MissingTableInspection.class,
         };
diff --git a/src/main/resources/META-INF/plugin.xml b/src/main/resources/META-INF/plugin.xml
@@ -68,18 +68,24 @@
   <li>line marker to allow quick navigation to the route definition</li>
 </ul>
 
+<br/>
+
 <h3>TCA</h3>
 <ul>
   <li>completion for built-in TCA render types</li>
   <li>completion for built-in TCA column types</li>
 </ul>
 
+<br/>
+
 <h3>Code inspections</h3>
 
 <br/>
 
 <ul>
   <li>Extbase property injection (@inject) performance inspection</li>
+  <li>TCA renderTypes</li>
+  <li>TCA column types</li>
 </ul>
 
 <br/>
@@ -113,6 +119,7 @@ It is a great inspiration for possible solutions and parts of the code.</p>
   <li>Autocompletion for TCA renderTypes</li>
   <li>Inspection for valid renderTypes</li>
   <li>Autocompletion for TCA column types</li>
+  <li>Inspection for valid column types</li>
 </ul>
 
 <h2>0.2.9</h2>
diff --git a/src/main/resources/inspectionDescriptions/MisssingColumnInspection.html b/src/main/resources/inspectionDescriptions/MisssingColumnInspection.html
@@ -0,0 +1,5 @@
+<html>
+<body>
+<p>The TCA column type provided is invalid.</p>
+</body>
+</html>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +<html>
 +<body>
 +<p>The TCA column type provided is invalid.</p>
 +</body>
 +</html>