throw errors when sdk returns an error code

Author: dinuchiriac

android/src/main/kotlin/io/chirp/chirpsdk/ChirpsdkPlugin.kt

@@ -129,30 +129,42 @@ class ChirpsdkPlugin(private val activity: Activity) : MethodCallHandler {
     if (!isInitialised(call, result)) return
     val config: String = call.arguments as String
     val error: ChirpError = chirpSDK.setConfig(config)
-
-    //TODO: brainstorm if this is the best approach, maybe we should just report error here?
-    result.success(error.code)
-    if (error.code == 0) {
-      setCallbacks()
+    if (error.code > 0) {
+      result.error(error.code.toString(), error.message, null)
+      return
     }
+    result.success(error.code)
+    setCallbacks()
   }
 
   private fun start(call: MethodCall, result: Result) {
     if (!isInitialised(call, result)) return
     val error: ChirpError = chirpSDK.start()
+    if (error.code > 0) {
+      result.error(error.code.toString(), error.message, null)
+      return
+    }
     result.success(error.code)
   }
 
   private fun stop(call: MethodCall, result: Result) {
     if (!isInitialised(call, result)) return
     val error: ChirpError = chirpSDK.stop()
+    if (error.code > 0) {
+      result.error(error.code.toString(), error.message, null)
+      return
+    }
     result.success(error.code)
   }
 
   private fun send(call: MethodCall, result: Result) {
     if (!isInitialised(call, result)) return
     val payload =  call.arguments as ByteArray
     val error: ChirpError = chirpSDK.send(payload)
+    if (error.code > 0) {
+      result.error(error.code.toString(), error.message, null)
+      return
+    }
     result.success(error.code)
   }
 

example/android/build.gradle

@@ -1,12 +1,12 @@
 buildscript {
-    ext.kotlin_version = '1.2.71'
+    ext.kotlin_version = '1.3.10'
     repositories {
         google()
         jcenter()
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.2.1'
+        classpath 'com.android.tools.build:gradle:3.5.1'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }

example/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
-#Fri Jun 23 08:50:38 CEST 2017
+#Thu Oct 10 16:14:48 BST 2019
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

example/lib/main.dart

@@ -46,11 +46,7 @@ class _ChirpAppState extends State<ChirpApp> with WidgetsBindingObserver {
   Future<void> _initChirp() async {
     try {
       //Init ChirpSDK
-      var errorCode = await ChirpSDK.init(_appKey, _appSecret);
-      if (errorCode > 0) {
-        setErrorCode(errorCode);
-        return;
-      }
+      await ChirpSDK.init(_appKey, _appSecret);
 
       //Get and print SDK version
       final String chirpVersion = await ChirpSDK.version;
@@ -59,12 +55,7 @@ class _ChirpAppState extends State<ChirpApp> with WidgetsBindingObserver {
       });
 
       //Set SDK config
-      errorCode = await ChirpSDK.setConfig(_appConfig);
-      if (errorCode > 0) {
-        setErrorCode(errorCode);
-        return;
-      }
-
+      await ChirpSDK.setConfig(_appConfig);
       _setChirpCallbacks();
 
     } catch (err) {
@@ -87,11 +78,7 @@ class _ChirpAppState extends State<ChirpApp> with WidgetsBindingObserver {
 
   void _startSDK() async {
     try {
-      int errorCode = await ChirpSDK.start();
-      if (errorCode > 0) {
-        setErrorCode(errorCode);
-        return;
-      }
+      await ChirpSDK.start();
       setState(() {
         _startStopBtnText = "STOP";
       });
@@ -102,11 +89,7 @@ class _ChirpAppState extends State<ChirpApp> with WidgetsBindingObserver {
 
   void _stopSDK() async {
     try {
-      int errorCode = await ChirpSDK.stop();
-      if (errorCode > 0) {
-        setErrorCode(errorCode);
-        return;
-      }
+      await ChirpSDK.stop();
       setState(() {
         _startStopBtnText = "START";
       });

lib/chirpsdk.dart

@@ -32,9 +32,9 @@ class ChirpSDK {
   /// up for Chirp at the Developer Hub[1].
   ///
   /// [1]: https://developers.chirp.io
-  static Future<int> init(String key, String secret) async {
+  static Future init(String key, String secret) async {
     var parameters = {'key': key, 'secret': secret};
-    return _methods.invokeMethod('init', new Map.from(parameters));
+    _methods.invokeMethod('init', new Map.from(parameters));
   }
 
   /// Get the Chirp SDK version info as a string
@@ -48,24 +48,24 @@ class ChirpSDK {
   /// A config string can be retrieved from the Developer Hub[1].
   ///
   /// [1]: https://developers.chirp.io
-  static Future<int> setConfig(String config) async {
-    return await _methods.invokeMethod('setConfig', config);
+  static Future setConfig(String config) async {
+    await _methods.invokeMethod('setConfig', config);
   }
 
   /// Start audio processing
   ///
   /// This should be called after `setConfig`, and when
   /// resuming the app from the background. See example.
-  static Future<int> start() async {
-    return await _methods.invokeMethod('start');
+  static Future start() async {
+    await _methods.invokeMethod('start');
   }
 
   /// Stop audio processing
   ///
   /// This should be called when the app enters the background
   /// or when shutting down the app for exit. See example.
-  static Future<int> stop() async {
-    return await _methods.invokeMethod('stop');
+  static Future stop() async {
+    await _methods.invokeMethod('stop');
   }
 
   /// Send a payload to the speakers
@@ -79,8 +79,8 @@ class ChirpSDK {
   /// data[2] = 3;
   /// data[3] = 4;
   /// sdk.send(data);
-  static Future<int> send(Uint8List payload) async {
-    return await _methods.invokeMethod('send', payload);
+  static Future send(Uint8List payload) async {
+    await _methods.invokeMethod('send', payload);
   }
 
   /// Returns a randomly generated payload