Skip to content
This repository was archived by the owner on Oct 5, 2020. It is now read-only.

Commit 8647837

Browse files
committed
Fixes for chirpsdk plugin
1 parent 865e771 commit 8647837

File tree

1 file changed

+19
-43
lines changed

1 file changed

+19
-43
lines changed

ios/Classes/ChirpsdkPlugin.m

Lines changed: 19 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ - (BOOL)isInitialised:(FlutterMethodCall*)call result:(FlutterResult)result {
4646
if (self.chirp) {
4747
return YES;
4848
} else {
49-
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%d", CHIRP_SDK_NOT_INITIALISED]
49+
result([FlutterError errorWithCode:@"-1"
5050
message:@"ChirpSDK not initialised"
5151
details:nil]);
5252
return NO;
@@ -55,11 +55,11 @@ - (BOOL)isInitialised:(FlutterMethodCall*)call result:(FlutterResult)result {
5555

5656
- (void)handleError:(FlutterMethodCall*)call result:(FlutterResult)result withError:(NSError *)error {
5757
if (error) {
58-
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%d", error.code]
58+
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%ld", (long)error.code]
5959
message:error.description
6060
details:nil]);
6161
} else {
62-
result();
62+
result(nil);
6363
}
6464
}
6565

@@ -121,76 +121,76 @@ - (void)init:(FlutterMethodCall*)call result:(FlutterResult)result {
121121
self.chirp = [[ChirpSDK alloc] initWithAppKey:key
122122
andSecret:secret];
123123
if (self.chirp) {
124-
result();
124+
result(nil);
125125
} else {
126-
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%d", CHIRP_SDK_NOT_INITIALISED]
126+
result([FlutterError errorWithCode:@"-1"
127127
message:@"Failed to initialise ChirpSDK"
128128
details:nil]);
129129
}
130130
}
131131

132132
- (void)version:(FlutterMethodCall*)call result:(FlutterResult)result {
133-
if (![self isInitialised]) return;
133+
if (![self isInitialised:call result:result]) return;
134134
result([self.chirp version]);
135135
}
136136

137137
- (void)setConfig:(FlutterMethodCall*)call result:(FlutterResult)result {
138-
if (![self isInitialised]) return;
138+
if (![self isInitialised:call result:result]) return;
139139
NSString *config = call.arguments;
140140
NSError *error = [self.chirp setConfig:config];
141141
if (error) {
142-
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%d", error.code]
142+
result([FlutterError errorWithCode:[NSString stringWithFormat:@"%ld", (long)error.code]
143143
message:error.description
144144
details:nil]);
145145
} else {
146146
[self setCallbacks];
147-
result();
147+
result(nil);
148148
}
149149
}
150150

151151
- (void)start:(FlutterMethodCall*)call result:(FlutterResult)result {
152-
if (![self isInitialised]) return;
152+
if (![self isInitialised:call result:result]) return;
153153
NSError *error = [self.chirp start];
154154
[self handleError:call result:result withError:error];
155155
}
156156

157157
- (void)stop:(FlutterMethodCall*)call result:(FlutterResult)result {
158-
if (![self isInitialised]) return;
158+
if (![self isInitialised:call result:result]) return;
159159
NSError *error = [self.chirp stop];
160160
[self handleError:call result:result withError:error];
161161
}
162162

163163
- (void)send:(FlutterMethodCall*)call result:(FlutterResult)result {
164-
if (![self isInitialised]) return;
164+
if (![self isInitialised:call result:result]) return;
165165
NSData *payload = [(FlutterStandardTypedData *)call.arguments data];
166166
NSError *error = [self.chirp send:payload];
167167
[self handleError:call result:result withError:error];
168168
}
169169

170170
- (void)sendRandom:(FlutterMethodCall*)call result:(FlutterResult)result {
171-
if (![self isInitialised]) return;
171+
if (![self isInitialised:call result:result]) return;
172172
NSData *payload = [self.chirp randomPayloadWithRandomLength];
173173
NSError *error = [self.chirp send:payload];
174174
[self handleError:call result:result withError:error];
175175
}
176176

177177
- (void)getState:(FlutterMethodCall*)call result:(FlutterResult)result {
178-
if (![self isInitialised]) return;
178+
if (![self isInitialised:call result:result]) return;
179179
result([NSNumber numberWithInt:[self.chirp state]]);
180180
}
181181

182182
- (void)maxPayloadLength:(FlutterMethodCall*)call result:(FlutterResult)result {
183-
if (![self isInitialised]) return;
184-
result([NSNumber numberWithInt:[self.chirp maxPayloadLength]]);
183+
if (![self isInitialised:call result:result]) return;
184+
result(@([self.chirp maxPayloadLength]));
185185
}
186186

187187
- (void)channelCount:(FlutterMethodCall*)call result:(FlutterResult)result {
188-
if (![self isInitialised]) return;
189-
result([NSNumber numberWithInt:[self.chirp channelCount]]);
188+
if (![self isInitialised:call result:result]) return;
189+
result(@([self.chirp channelCount]));
190190
}
191191

192192
- (void)isValidPayload:(FlutterMethodCall*)call result:(FlutterResult)result {
193-
if (![self isInitialised]) return;
193+
if (![self isInitialised:call result:result]) return;
194194
NSData *payload = [(FlutterStandardTypedData *)call.arguments data];
195195
result([NSNumber numberWithBool:[self.chirp isValidPayload:payload]]);
196196
}
@@ -365,27 +365,3 @@ - (FlutterError * _Nullable)onCancelWithArguments:(id _Nullable)arguments {
365365
}
366366

367367
@end
368-
369-
370-
@implementation ErrorStreamHandler {
371-
FlutterEventSink _eventSink;
372-
}
373-
374-
- (FlutterError *_Nullable)onListenWithArguments:(id _Nullable)arguments eventSink:(FlutterEventSink)events {
375-
_eventSink = events;
376-
return nil;
377-
}
378-
379-
- (void)send:(NSNumber *)code message:(NSString *)message {
380-
if (_eventSink) {
381-
NSDictionary *dictionary = @{ @"code": code, @"message": message };
382-
_eventSink(dictionary);
383-
}
384-
}
385-
386-
- (FlutterError * _Nullable)onCancelWithArguments:(id _Nullable)arguments {
387-
_eventSink = nil;
388-
return nil;
389-
}
390-
391-
@end

0 commit comments

Comments
 (0)