From ea309d8e0fa993461f3cae8019955e184aa28f48 Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 10 Jan 2026 16:36:47 +0100 Subject: [PATCH 1/4] Remove type reexport --- src/components/basic-dropdown.gts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/components/basic-dropdown.gts b/src/components/basic-dropdown.gts index 6166577a..35e7f917 100644 --- a/src/components/basic-dropdown.gts +++ b/src/components/basic-dropdown.gts @@ -27,9 +27,6 @@ import type { TRootEventType, } from '../types.ts'; -// To avoid breaking the current types export we need this -export type { Dropdown, DropdownActions, TRootEventType }; - const UNINITIALIZED = {}; const IGNORED_STYLES = ['top', 'left', 'right', 'width', 'height']; From 6f0e9c6012c8bdf8b523f63290c280f2f62615ff Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 10 Jan 2026 16:39:08 +0100 Subject: [PATCH 2/4] Fix type import --- src/components/basic-dropdown-trigger.gts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/basic-dropdown-trigger.gts b/src/components/basic-dropdown-trigger.gts index f8070aba..d228ec35 100644 --- a/src/components/basic-dropdown-trigger.gts +++ b/src/components/basic-dropdown-trigger.gts @@ -6,8 +6,7 @@ import { concat } from '@ember/helper'; import basicDropdownTriggerModifier from '../modifiers/basic-dropdown-trigger.ts'; import { on } from '@ember/modifier'; import { fn } from '@ember/helper'; -import type { Dropdown } from './basic-dropdown'; -import type { HorizontalPosition, VerticalPosition } from '../types.ts'; +import type { Dropdown, HorizontalPosition, VerticalPosition } from '../types.ts'; export interface BasicDropdownTriggerSignature< T extends keyof HTMLElementTagNameMap = 'div', From f96f89370d84e35a498782b1b63a9e1b80a05edd Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 10 Jan 2026 16:42:17 +0100 Subject: [PATCH 3/4] run format --- src/components/basic-dropdown-trigger.gts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/basic-dropdown-trigger.gts b/src/components/basic-dropdown-trigger.gts index d228ec35..cfb62506 100644 --- a/src/components/basic-dropdown-trigger.gts +++ b/src/components/basic-dropdown-trigger.gts @@ -6,7 +6,11 @@ import { concat } from '@ember/helper'; import basicDropdownTriggerModifier from '../modifiers/basic-dropdown-trigger.ts'; import { on } from '@ember/modifier'; import { fn } from '@ember/helper'; -import type { Dropdown, HorizontalPosition, VerticalPosition } from '../types.ts'; +import type { + Dropdown, + HorizontalPosition, + VerticalPosition, +} from '../types.ts'; export interface BasicDropdownTriggerSignature< T extends keyof HTMLElementTagNameMap = 'div', From 0e244fff9b3c74899cd0308b242798d177d128b4 Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 10 Jan 2026 16:44:50 +0100 Subject: [PATCH 4/4] Fix type import --- docs/app/components/snippets/dropdown-events-2.gts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/app/components/snippets/dropdown-events-2.gts b/docs/app/components/snippets/dropdown-events-2.gts index cd5c7ac1..9b747a12 100644 --- a/docs/app/components/snippets/dropdown-events-2.gts +++ b/docs/app/components/snippets/dropdown-events-2.gts @@ -1,9 +1,8 @@ import Component from '@glimmer/component'; import { action } from '@ember/object'; import { task, timeout } from 'ember-concurrency'; -import BasicDropdown, { - type Dropdown, -} from 'ember-basic-dropdown/components/basic-dropdown'; +import BasicDropdown from 'ember-basic-dropdown/components/basic-dropdown'; +import type { Dropdown } from 'ember-basic-dropdown/types'; const users = [ { name: 'Nathan', assignment: 'CLI' },