Skip to content
This repository was archived by the owner on May 4, 2025. It is now read-only.

Commit 53290bb

Browse files
authored
Merge pull request #53 from ckipp01/10
refactor: ensure everything works with all 0.10.x
2 parents 0c8d84b + 22f4527 commit 53290bb

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ The main benifits of doing this are:
1717

1818
## Requirements
1919

20-
- Right now this plugin requires **at least Mill 0.10.3**.
20+
- Right now this plugin only supports the **Mill 0.10.x series**.
2121
- Make sure in your repo settings the Dependency Graph feature is enabled as
2222
well as Dependabot Alerts if you'd like them. (Settings -> Code security and
2323
analysis)

build.sc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ import mill.scalalib.api.Util.scalaNativeBinaryVersion
1515
import de.tobiasroeser.mill.integrationtest._
1616
import de.tobiasroeser.mill.vcs.version.VcsVersion
1717

18-
// TODO Should probably drop this to 0.10.0, but when I did a bunch of stuff breaks
19-
val millVersion = "0.10.3"
18+
val millVersion = "0.10.0"
2019
val scala213 = "2.13.8"
2120
val artifactBase = "mill-github-dependency-graph"
2221

plugin/src/io/kipp/mill/github/dependency/graph/Resolver.scala

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import mill.eval.Evaluator
66
import mill.scalalib.Dep
77
import mill.scalalib.JavaModule
88
import mill.scalalib.Lib
9-
import mill.scalalib.internal.ModuleUtils
109

1110
/** Utils to help find all your modules and resolve their dependencies.
1211
*/
@@ -33,7 +32,6 @@ object Resolver {
3332
val repos = javaModule.repositoriesTask()
3433
val mapDeps = javaModule.mapDependencies()
3534
val custom = javaModule.resolutionCustomizer()
36-
val cacheCustom = javaModule.coursierCacheCustomizer()
3735

3836
val (dependencies, resolution) =
3937
Lib.resolveDependenciesMetadata(
@@ -42,7 +40,6 @@ object Resolver {
4240
deps = deps,
4341
mapDependencies = Some(mapDeps),
4442
customizer = custom,
45-
coursierCacheCustomizer = cacheCustom,
4643
ctx = Some(T.log)
4744
)
4845

@@ -57,12 +54,6 @@ object Resolver {
5754
}
5855
}
5956

60-
/** Quick and dirty, give me all the JavaModules.
61-
*/
62-
private[graph] def computeModules(ev: Evaluator): Seq[JavaModule] = {
63-
ModuleUtils
64-
.transitiveModules(ev.rootModule)
65-
.collect { case jm: JavaModule => jm }
66-
}
67-
57+
private[graph] def computeModules(ev: Evaluator) =
58+
ev.rootModule.millInternal.modules.collect { case j: JavaModule => j }
6859
}

0 commit comments

Comments
 (0)