From cd29781b89cb50ca14749290ba990e77d998c662 Mon Sep 17 00:00:00 2001
From: Julian Ladisch <julianladisch@users.noreply.github.com>
Date: Sat, 28 Jun 2025 19:09:11 +0200
Subject: [PATCH] Fix broken external links in Footer, replace `<Link>` with
 `<a>`

`<Link>` doesn't support external links in react-router versions before 6.8.0:
https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v680

We use react-router version 4.3.1 resulting in broken links to
Terms, Privacy, and Notices.

This gets fixed by replacing `<Link>` with `<a>`.

Fixes #995.
---
 src/components/Footer.js | 30 +++---------------------------
 1 file changed, 3 insertions(+), 27 deletions(-)

diff --git a/src/components/Footer.js b/src/components/Footer.js
index 69c5a4f4..433901c7 100644
--- a/src/components/Footer.js
+++ b/src/components/Footer.js
@@ -3,7 +3,6 @@
 
 import React, { Component } from 'react'
 import { SocialIcons } from './'
-import { Link } from 'react-router-dom'
 
 // import { API_DEVELOP, API_PROD, API_LOCAL } from '../api/clearlyDefined';
 // function colorize(content) {
@@ -40,36 +39,13 @@ export default class Footer extends Component {
               </p>
             </div>
             <div className="col-md-4 footer-links col-12 ml-md-auto mt-md-0 mt-4">
-              <Link to="https://docs.clearlydefined.io/docs/legal/terms" className="text-decoration-underline mx-2 d-inline text-white">Terms</Link>
-              <Link to="https://docs.clearlydefined.io/docs/legal/privacy" className="text-decoration-underline mx-2 d-inline  text-white">Privacy</Link>
-              <Link to="https://docs.clearlydefined.io/docs/legal/NOTICES" className="text-decoration-underline mx-2 d-inline text-white">Notices</Link>
+              <a href="https://docs.clearlydefined.io/docs/legal/terms" className="text-decoration-underline mx-2 d-inline text-white">Terms</a>
+              <a href="https://docs.clearlydefined.io/docs/legal/privacy" className="text-decoration-underline mx-2 d-inline text-white">Privacy</a>
+              <a href="https://docs.clearlydefined.io/docs/legal/NOTICES" className="text-decoration-underline mx-2 d-inline text-white">Notices</a>
             </div>
           </div>
         </div>
       </footer>
-      // <footer className="Footer">
-      //   <Grid>
-      //     <Col sm={4} xs={3} className="vcenter">
-      //       <SocialIcons className="socials" entity={socials} />
-      //     </Col>
-      //     <Col sm={4} xs={5} className="text-center vcenter">
-      //       Are you ClearlyDefined?
-      //     </Col>
-      //     <Col sm={4} xs={4} className="vcenter">
-      //       <div className="pull-right right">
-      //         <a href="https://docs.clearlydefined.io/legal/terms" target="_blank" rel="noopener noreferrer">
-      //           Terms of use
-      //         </a>{' '}
-      //         <span>| </span>
-      //         <a href="https://docs.clearlydefined.io/legal/privacy" target="_blank" rel="noopener noreferrer">
-      //           Privacy policy
-      //         </a>{' '}
-      //         <span>| </span>
-      //         <a href="https://docs.clearlydefined.io/legal/NOTICES">Notices</a>
-      //       </div>
-      //     </Col>
-      //   </Grid>
-      // </footer>
     )
   }
 }