Code style

Author: cichli

src/cider/nrepl/middleware/stacktrace.clj

@@ -199,7 +199,7 @@
   Include relative path for simpler reporting."
   [{:keys [class message location] :as cause}]
   (if (= class "clojure.lang.Compiler$CompilerException")
-    (if-not (empty? location)
+    (if (seq location)
       (assoc cause
              :file (:clojure.error/source location)
              :file-url (some-> (:clojure.error/source location)
@@ -260,18 +260,18 @@
                              pred reason
                              via path]
                       :as prob} problems]
-                 (->> {:in (when-not (empty? in) (pr-str in))
+                 (->> {:in (when (seq in) (pr-str in))
                        :val (pp-str val)
                        :predicate (pr-str (@spec-abbrev pred))
-                       :reason reason ; <- always nil or string
-                       :spec (when-not (empty? via) (pr-str (last via)))
-                       :at (when-not (empty? path) (pr-str path))
+                       :reason reason
+                       :spec (when (seq via) (pr-str (last via)))
+                       :at (when (seq path) (pr-str path))
                        :extra (let [extras (->> #{:in :val :pred :reason :via :path
                                                   :clojure.spec/failure
                                                   :clojure.spec.alpha/failure}
                                                 (set/difference (set (keys prob)))
                                                 (select-keys prob))]
-                                (when-not (empty? extras)
+                                (when (seq extras)
                                   (pp-str extras)))}
                       (filter clojure.core/val)
                       (into {})))}))

test/clj/cider/nrepl/middleware/resource_test.clj

@@ -14,11 +14,11 @@
   (testing "Basic checks"
     (let [response (session/message {:op "resources-list"})]
       (is (= #{"done"} (:status response)))
-      (is (not (empty? (:resources-list response))))
-      (is (not (empty? (filter #(re-matches #"test\.txt" (:relpath %))
-                               (:resources-list response)))))
-      (is (not (empty? (filter #(re-matches #".*test/resources/test\.txt" (:file %))
-                               (:resources-list response))))))))
+      (is (seq (:resources-list response)))
+      (is (seq (filter #(re-matches #"test\.txt" (:relpath %))
+                       (:resources-list response))))
+      (is (seq (filter #(re-matches #".*test/resources/test\.txt" (:file %))
+                       (:resources-list response)))))))
 
 (deftest resource-op-error-handling-test
   (with-redefs [r/resource-path (fn [& _] (throw (Exception. "resource")))]

test/clj/cider/nrepl/middleware/stacktrace_test.clj

@@ -83,7 +83,7 @@
       (is (some #(re-find #"(clojure|nrepl|run)" (:name %))
                 (filter (comp :tooling :flags) frames2))))
     (testing "for project"
-      (is (not-empty (filter (comp :project :flags) frames4))))
+      (is (seq (filter (comp :project :flags) frames4))))
     (testing "for duplicate frames"
       ;; Index frames. For all frames flagged as :dup, the frame above it in
       ;; the stack (index i - 1) should be substantially the same source info.