Skip to content

Commit 164ae12

Browse files
committed
fix test
1 parent 0ddeefb commit 164ae12

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

tests/commands/test_api_error.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,9 @@ def test_record_tests(self):
378378
@responses.activate
379379
@mock.patch.dict(os.environ, {"LAUNCHABLE_TOKEN": CliTestCase.launchable_token})
380380
def test_all_workflow_when_server_down(self):
381+
# Note(Konboi): reset mock requests once and re-register it to make sure it’s not affected by other tests.
382+
responses.reset()
383+
381384
# setup verify
382385
responses.add(
383386
responses.GET,
@@ -392,23 +395,23 @@ def test_all_workflow_when_server_down(self):
392395
base=get_base_url()),
393396
body=ReadTimeout("error"))
394397
# setup state
395-
responses.replace(
398+
responses.add(
396399
responses.GET,
397400
"{base}/intake/organizations/{org}/workspaces/{ws}/state".format(
398401
base=get_base_url(),
399402
org=self.organization,
400403
ws=self.workspace),
401404
body=ReadTimeout("error"))
402405
# setup build
403-
responses.replace(
406+
responses.add(
404407
responses.POST,
405408
"{base}/intake/organizations/{org}/workspaces/{ws}/builds".format(
406409
base=get_base_url(),
407410
org=self.organization,
408411
ws=self.workspace),
409412
body=ReadTimeout("error"))
410413
# setup subset
411-
responses.replace(
414+
responses.add(
412415
responses.GET,
413416
"{base}/intake/organizations/{org}/workspaces/{ws}/builds/{build}/test_sessions/{session_id}".format(
414417
base=get_base_url(),
@@ -418,7 +421,7 @@ def test_all_workflow_when_server_down(self):
418421
session_id=self.session_id),
419422
body=ReadTimeout("error"))
420423
# setup recording tests
421-
responses.replace(
424+
responses.add(
422425
responses.POST,
423426
"{base}/intake/organizations/{org}/workspaces/{ws}/builds/{build}/test_sessions/{session_id}/events".format(
424427
base=get_base_url(),
@@ -438,7 +441,7 @@ def test_all_workflow_when_server_down(self):
438441
self.assert_success(result)
439442

440443
# Since Timeout error is caught inside of LaunchableClient, the tracking event is sent twice.
441-
self.assert_tracking_count(tracking=tracking, count=6)
444+
self.assert_tracking_count(tracking=tracking, count=8)
442445

443446
# set delete=False to solve the error `PermissionError: [Errno 13] Permission denied:` on Windows.
444447
with tempfile.NamedTemporaryFile(delete=False) as rest_file:

tests/utils/test_fail_fast_mode.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import io
22
from contextlib import contextmanager, redirect_stderr
3+
from unittest import TestCase
34

45
from launchable.utils.commands import Command
56
from launchable.utils.fail_fast_mode import FailFastModeValidateParams, fail_fast_mode_validate
6-
from tests.cli_test_case import CliTestCase
77

88

9-
class FailFastModeTest(CliTestCase):
9+
class FailFastModeTest(TestCase):
1010
def test_fail_fast_mode_validate(self):
1111
params = FailFastModeValidateParams(
1212
command=Command.SUBSET,

0 commit comments

Comments
 (0)