From 4c867ec2a0c238e17d4c0b32af4aded8d055afe7 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 5 Sep 2025 10:37:14 -0700 Subject: [PATCH] [chore] report an error in subset call It looks like c41d9a6270d448168e722155b25ac04b7bdad5fa removed the `raise_for_status` check, without which error message from the server won't be reported, even as a warning. This breaks the subset call in case of the server failure, since `res.json()` looks as if it's returning an empty subset --- launchable/commands/subset.py | 1 + 1 file changed, 1 insertion(+) diff --git a/launchable/commands/subset.py b/launchable/commands/subset.py index e0ec48e4a..39cb0df6b 100644 --- a/launchable/commands/subset.py +++ b/launchable/commands/subset.py @@ -560,6 +560,7 @@ def request_subset(self) -> SubsetResult: # The status code 422 is returned when validation error of the test mapping file occurs. if res.status_code == 422: print_error_and_die("Error: {}".format(res.reason), Tracking.ErrorEvent.USER_ERROR) + res.raise_for_status() return SubsetResult.from_response(res.json()) except Exception as e: