Catch or explicitly ignore unhandled errors

Author: geofffranks

src/code.cloudfoundry.org/bosh-dns-adapter/config/config.go

@@ -27,6 +27,7 @@ type Config struct {
 }
 
 func init() {
+	// #nosec G104 - don't handle error here - only thing that would be returned is if we had an empty name passed in, and we're in an init block with limitid handling capability
 	validator.SetValidationFunc("cidr", func(v interface{}, param string) error {
 		cidr, ok := v.(string)
 		if !ok {

src/code.cloudfoundry.org/bosh-dns-adapter/main.go

@@ -93,7 +93,8 @@ func main() {
 	}
 
 	go func() {
-		http.Serve(l, metricsWrap("GetIPs", http.HandlerFunc(getIPsHandler.ServeHTTP)))
+		err = http.Serve(l, metricsWrap("GetIPs", http.HandlerFunc(getIPsHandler.ServeHTTP)))
+		logger.Info("http-server-returned", lager.Data{"error": err})
 	}()
 
 	uptimeSource := metrics.NewUptimeSource()
@@ -122,6 +123,9 @@ func main() {
 	logger.Info("server-started")
 	sig := <-signalChannel
 	monitor.Signal(sig)
-	l.Close()
+	err = l.Close()
+	if err != nil {
+		logger.Error("erro-closing-server", err)
+	}
 	logger.Info("server-stopped")
 }

src/code.cloudfoundry.org/bosh-dns-adapter/sdcclient/service_discovery_client.go

@@ -86,7 +86,9 @@ func (s *ServiceDiscoveryClient) IPs(infrastructureName string) ([]string, error
 		}
 
 		defer func(httpResp *http.Response) {
+			// #nosec G104 - ignore errors in the defer block, this response was bad anyway and we just want to best-effort clean it up
 			io.Copy(io.Discard, httpResp.Body)
+			// #nosec G104 - ignore errors in the defer block, this response was bad anyway and we just want to best-effort clean it up
 			httpResp.Body.Close()
 		}(httpResp)
 
@@ -102,6 +104,7 @@ func (s *ServiceDiscoveryClient) IPs(infrastructureName string) ([]string, error
 	}
 
 	bytes, err := io.ReadAll(httpResp.Body)
+	// #nosec G104 - ignore closing body errors. we either have all the data and can keep going
 	httpResp.Body.Close()
 	if err != nil {
 		return []string{}, err

src/code.cloudfoundry.org/cf-pusher/cmd/cf-pusher/main.go

@@ -231,8 +231,13 @@ func main() {
 	if err := apiConnector.Connect(); err != nil {
 		log.Fatalf("connecting to api: %s", err)
 	}
-	adapter.TargetOrg(scaleGroup.Org)
-	adapter.TargetSpace(scaleGroup.Space)
+	if err := adapter.TargetOrg(scaleGroup.Org); err != nil {
+		log.Fatalf("targeting org %s: %s", scaleGroup.Org, err)
+	}
+
+	if err := adapter.TargetSpace(scaleGroup.Space); err != nil {
+		log.Fatalf("targeting space %s: %s", scaleGroup.Space, err)
+	}
 
 	// declare what apps we expect
 	expectedApps := map[string]int{

src/code.cloudfoundry.org/policy-server/cmd/policy-server-asg-syncer/main.go

@@ -158,7 +158,10 @@ func main() {
 
 	err = <-monitor.Wait()
 	if connectionPool != nil {
-		connectionPool.Close()
+		closeErr := connectionPool.Close()
+		if closeErr != nil {
+			logger.Error("error-closing-connection-pool", err)
+		}
 	}
 	if err != nil {
 		logger.Error("exited-with-failure", err)

src/code.cloudfoundry.org/policy-server/cmd/policy-server-internal/main.go

@@ -202,7 +202,10 @@ func main() {
 
 	err = <-monitor.Wait()
 	if connectionPool != nil {
-		connectionPool.Close()
+		closeErr := connectionPool.Close()
+		if closeErr != nil {
+			logger.Error("error-closing-connection-pool", err)
+		}
 	}
 	if err != nil {
 		logger.Error("exited-with-failure", err)

src/code.cloudfoundry.org/policy-server/cmd/policy-server/main.go

@@ -324,7 +324,10 @@ func main() {
 
 	err = <-monitor.Wait()
 	if connectionPool != nil {
-		connectionPool.Close()
+		closeErr := connectionPool.Close()
+		if closeErr != nil {
+			logger.Error("error-closing-connection-pool", err)
+		}
 	}
 	if err != nil {
 		logger.Error("exited-with-failure", err)

src/code.cloudfoundry.org/policy-server/handlers/asgs_index.go

@@ -52,6 +52,7 @@ func (h *AsgsIndex) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 	}
 
 	w.WriteHeader(http.StatusOK)
+	// #nosec G104 - ignore errors writing http responses to avoid spamming logs during a DoS
 	w.Write(bytes)
 }
 

src/code.cloudfoundry.org/policy-server/handlers/policies_cleanup.go

@@ -59,5 +59,6 @@ func (h *PoliciesCleanup) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 	}
 
 	w.WriteHeader(http.StatusOK)
+	// #nosec G104 - ignore errors writing http responses to avoid spamming logs during a DoS
 	w.Write(bytes)
 }

src/code.cloudfoundry.org/policy-server/handlers/policies_create.go

@@ -96,5 +96,6 @@ func (h *PoliciesCreate) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 
 	logger.Info("created-policies", lager.Data{"policies": policies, "userName": tokenData.UserName})
 	w.WriteHeader(http.StatusOK)
+	// #nosec G104 - ignore error writing http response to avoid spamming logs on a DoS
 	w.Write([]byte("{}"))
 }